All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: workflows@vger.kernel.org, ksummit@lists.linux.dev
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Mark Brown <broonie@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Leon Romanovsky <leon@kernel.org>,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	Thorsten Leemhuis <linux@leemhuis.info>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Sasha Levin <sashal@kernel.org>
Subject: [PATCH v2 0/5] agents: add skills for Fixes tags, stable tags, similar bugs, and commit messages
Date: Mon, 12 Oct 2026 17:34:47 -0400	[thread overview]
Message-ID: <20261012213452.1863248-1-sashal@kernel.org> (raw)

At the Maintainers Summit, Ted asked whether the stable trees have a way
to deal with incorrect Fixes tags. Hannes estimated that 15-20% of them
are wrong, often because the author ran git blame and took the first
commit that touched the line [1]. We use LLM workflows to find the
commit that actually introduced a bug, and others asked us to share
them.

This series adds them as agent skills under agents/skills/, together
with a skill for writing commit messages:

 - find-fixes determines the commit for a Fixes tag, following the
   history past code moves and refactors.

 - stable-tag decides whether a fix should go to stable and generates the
   tag. It follows the criteria AUTOSEL applies in practice, finds the
   first release with the bug using git tag --contains, and checks that
   the fix applies there, adding prerequisites or a version floor if
   needed.

 - find-siblings looks for the same bug elsewhere in the tree and
   verifies each candidate.

 - commit-message writes, rewrites, or reviews a commit message or cover
   letter, and writes the signed tag and email text for a pull request.
   It follows the P: profiles that get_maintainer.pl reports for the
   changed files, reads the related list discussions with lei when it is
   available, and keeps the text short and in the imperative voice.

The skills are read-only and return a result with evidence. The calling
workflow writes the commit, creates the tag, and sends the mail.
coding-assistants.rst tells agents when to use each skill.

I tested the skills with two different agents on an array of upstream
commits and pull requests.

Changes since v1:
 - Switch the MAINTAINERS list to workflows@vger.kernel.org (Leon,
   Konstantin).
 - Add the stable-tag, find-siblings, and commit-message skills.
 - find-fixes: point to the stable-tag skill for stable decisions.

v1: https://lore.kernel.org/r/cover.1791499378.git.sashal@kernel.org
[1] https://lore.kernel.org/r/askTmFZC6RJKAE_p@mit.edu
[2] https://lore.kernel.org/r/CAHk-=wgXU50=KgZNZc1JDxsSxg9Z+DjG1_2yU-fNXpZtUe4XDw@mail.gmail.com

Sasha Levin (5):
  agents: add infrastructure for agent resources
  agents: add a skill to determine Fixes tags
  agents: add a skill to determine stable tags
  agents: add a skill to find other instances of a fixed bug
  agents: add a skill to write commit messages

 Documentation/process/coding-assistants.rst   |  79 +++++-
 MAINTAINERS                                   |   6 +
 agents/skills/commit-message/SKILL.md         |  29 +++
 agents/skills/commit-message/guide.rst        | 200 +++++++++++++++
 agents/skills/commit-message/pull-request.rst | 113 +++++++++
 agents/skills/find-fixes/SKILL.md             |  23 ++
 agents/skills/find-fixes/guide.rst            | 178 ++++++++++++++
 agents/skills/find-siblings/SKILL.md          |  22 ++
 agents/skills/find-siblings/guide.rst         | 138 +++++++++++
 agents/skills/stable-tag/SKILL.md             |  25 ++
 agents/skills/stable-tag/guide.rst            | 229 ++++++++++++++++++
 11 files changed, 1039 insertions(+), 3 deletions(-)
 create mode 100644 agents/skills/commit-message/SKILL.md
 create mode 100644 agents/skills/commit-message/guide.rst
 create mode 100644 agents/skills/commit-message/pull-request.rst
 create mode 100644 agents/skills/find-fixes/SKILL.md
 create mode 100644 agents/skills/find-fixes/guide.rst
 create mode 100644 agents/skills/find-siblings/SKILL.md
 create mode 100644 agents/skills/find-siblings/guide.rst
 create mode 100644 agents/skills/stable-tag/SKILL.md
 create mode 100644 agents/skills/stable-tag/guide.rst


base-commit: 3857c2fe5449541e24afc5efdb0f81a8a8f9a3a0
--
2.53.0


             reply	other threads:[~2026-10-12 21:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 21:34 Sasha Levin [this message]
2026-10-12 21:34 ` [PATCH v2 1/5] agents: add infrastructure for agent resources Sasha Levin
2026-10-12 21:34 ` [PATCH v2 2/5] agents: add a skill to determine Fixes tags Sasha Levin
2026-10-13  3:55   ` Kees Cook
2026-10-13  4:42   ` Michael S. Tsirkin
2026-10-12 21:34 ` [PATCH v2 3/5] agents: add a skill to determine stable tags Sasha Levin
2026-10-13  3:59   ` Kees Cook
2026-10-13 11:30     ` Sasha Levin
2026-10-12 21:34 ` [PATCH v2 4/5] agents: add a skill to find other instances of a fixed bug Sasha Levin
2026-10-13  4:02   ` Kees Cook
2026-10-13 11:14     ` Sasha Levin
2026-10-12 21:34 ` [PATCH v2 5/5] agents: add a skill to write commit messages Sasha Levin
2026-10-12 22:47 ` [PATCH v2 0/5] agents: add skills for Fixes tags, stable tags, similar bugs, and " Jonathan Corbet
2026-10-13  3:48   ` Kees Cook
2026-10-13 11:22     ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261012213452.1863248-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=broonie@kernel.org \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=ksummit@lists.linux.dev \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=leon@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=mst@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tytso@mit.edu \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.