Re: [PATCH v2 2/3] mmc: k1: let the SPL read SD cards more than one block at a time

[Yixun Lan <dlan@kernel.org>]

Hi Anand Moon,

On 21:37 Mon 12 Oct     , Anand Moon wrote:
> Hi Zixian, Tanmay,
> 
> On Mon, 12 Oct 2026 at 18:49, Zixian Zeng <sycamoremoon376@gmail.com> wrote:
> >
...
> > On the pinctrl side I had already run the SPL with standalone
> > CONFIG_SPL_PINCTRL=y, with bootph-pre-ram on &pinctrl, mmc1_cfg and
> > mmc1_uhs_cfg plus their pin groups. I confirmed that
> > pinctrl_select_state() return successfully. The multi-block read still
> > failed the same way with the rail at 1.8V.
> >
> > Therefore, I suspect that configuring the MMC signal voltage to 1.8V
> > in pmic_init() may need to be modified.
> >
> > Thanks for your suggestions and guidance.
> >
> I have also made some changes related to SPL GPIO and pinctrl support.
> On the Banana Pi BPI-F3, the MMC controller uses the following
> regulator references,
> which are not currently configured in `k1-musepi-pro-u-boot.dtsi`:
> vmmc-supply = <&buck4>;
> vqmmc-supply = <&aldo1>;
> 
> To address this, I updated `k1-bananapi-f3-u-boot.dtsi` to include the
> required regulator
> configuration and make it available during SPL initialization.
> 
> Could you review these changes and assess whether they can be integrated
> into the mainline U-Boot code? I would also appreciate feedback on any
> changes needed
> to make the implementation suitable for upstream submission.
Hey, I'm confused, are you trying to prepare a patch here? I thought
it's Dave Klotz who would do this, let's not hijack this thread but
coordinate together, and please be patient, give Dave some time to
respond.. I think what Zexian done here is trying to investigate and
test the patches..

> [1] https://gist.github.com/moonlinux/2ae03be59f263b0797acb138bed226b5
> 
No, It's not a proper way for people to review and comment..

-- 
Yixun Lan (dlan)