From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,ziy@nvidia.com,vbabka@kernel.org,usama.arif@linux.dev,usama.anjum@arm.com,surenb@google.com,shuah@kernel.org,ryan.roberts@arm.com,rppt@kernel.org,nico.pache@linux.dev,mhocko@suse.com,ljs@kernel.org,liam@infradead.org,leon@kernel.org,lance.yang@linux.dev,kernel-team@meta.com,jgg@ziepe.ca,hughd@google.com,dev.jain@arm.com,david@kernel.org,baolin.wang@linux.alibaba.com,baohua@kernel.org,agordeev@linux.ibm.com,kas@kernel.org,akpm@linux-foundation.org
Subject: [merged mm-stable] selftests-mm-add-order-parameterized-khugepaged-collapse-cases.patch removed from -mm tree
Date: Mon, 12 Oct 2026 21:33:48 -0700 [thread overview]
Message-ID: <20261013043349.39F781F00893@smtp.kernel.org> (raw)
The quilt patch titled
Subject: selftests/mm: add order-parameterized khugepaged collapse cases
has been removed from the -mm tree. Its filename was
selftests-mm-add-order-parameterized-khugepaged-collapse-cases.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: "Kiryl Shutsemau (Meta)" <kas@kernel.org>
Subject: selftests/mm: add order-parameterized khugepaged collapse cases
Date: Sat, 19 Sep 2026 01:24:41 +0100
The mthp_khugepaged context runs the generic cases at a sub-PMD order,
which answers how many folios of that order a range ends up with. It
cannot say which order-sized window they landed in, so "the populated
window collapsed" and "the empty window next to it collapsed instead" look
alike.
Add four cases that check each window on its own, with the folio-order
helpers in vm_util:
- collapse_order_single_window(): only the populated window collapses;
- collapse_order_partial_window(): the default max_ptes_none lets a window
with one present PTE collapse;
- collapse_order_max_ptes_none(): with max_ptes_none=0 a full window
collapses and one missing a page does not;
- collapse_order_mixed_sources(): sources that are already large folios of
a smaller order collapse to the target.
Each case faults its region before MADV_HUGEPAGE with only the target
order enabled, so the sources are order 0 and the result can only come
from khugepaged. They wait for a full pass rather than for the result to
appear: without a completed pass, "not collapsed" and "not scanned yet"
are the same thing.
Link: https://lore.kernel.org/20260919002451.496763-12-kirill@shutemov.name
Signed-off-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Tested-by: Muhammad Usama Anjum <usama.anjum@arm.com>
Tested-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Assisted-by: LLM
Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Barry Song <baohua@kernel.org>
Cc: "David Hildenbrand (arm)" <david@kernel.org>
Cc: Dev Jain <dev.jain@arm.com>
Cc: Hugh Dickens <hughd@google.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: kernel-team@meta.com
Cc: Lance Yang <lance.yang@linux.dev>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: Liam Howlett <liam@infradead.org>
Cc: Lorenzo Stoakes (ARM) <ljs@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport (Microsoft) <rppt@kernel.org>
Cc: Nico Pache (Red Hat) <nico.pache@linux.dev>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Shuah Khan (Samsung OSG) <shuah@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Usama Arif <usama.arif@linux.dev>
Cc: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Cc: Zi Yan <ziy@nvidia.com>
---
tools/testing/selftests/mm/khugepaged.c | 212 ++++++++++++++++++++++
1 file changed, 212 insertions(+)
--- a/tools/testing/selftests/mm/khugepaged.c~selftests-mm-add-order-parameterized-khugepaged-collapse-cases
+++ a/tools/testing/selftests/mm/khugepaged.c
@@ -30,6 +30,8 @@ static unsigned long page_size;
static int hpage_pmd_nr;
static int anon_order;
static int collapse_order;
+static int pagemap_fd = -1;
+static int kpageflags_fd = -1;
#define PID_SMAPS "/proc/self/smaps"
#define TEST_FILE "collapse_test_file"
@@ -1209,6 +1211,198 @@ static void madvise_retracted_page_table
ksft_test_result_report(exit_status, "%s\n", __func__);
}
+/* Smallest order khugepaged will consider for mTHP collapse */
+#define MIN_MTHP_ORDER 2
+
+/* Time budget for one khugepaged pass in the collapse_order_* cases */
+#define MTHP_PASS_TIMEOUT_S 30
+
+static size_t mthp_window_size(void)
+{
+ return page_size << collapse_order;
+}
+
+static void mthp_push_target_order(void)
+{
+ struct thp_settings settings = *thp_current_settings();
+ int i;
+
+ /*
+ * Only the target order, and only for madvise: the cases fault their
+ * region first, so the sources stay order 0 whatever -s asked for.
+ */
+ settings.thp_enabled = THP_NEVER;
+ for (i = 0; i < NR_ORDERS; i++)
+ settings.hugepages[i].enabled = THP_NEVER;
+ settings.hugepages[collapse_order].enabled = THP_MADVISE;
+ thp_push_settings(&settings);
+}
+
+static bool all_windows_at_order(void *p, size_t len)
+{
+ return is_range_backed_by_order(p, len, collapse_order,
+ pagemap_fd, kpageflags_fd);
+}
+
+static bool any_window_at_order(void *p, size_t len)
+{
+ size_t window = mthp_window_size();
+ char *addr = p;
+
+ for (; len >= window; addr += window, len -= window) {
+ if (all_windows_at_order(addr, window))
+ return true;
+ }
+ return false;
+}
+
+static void collapse_order_single_window(struct collapse_context *c,
+ struct mem_ops *ops)
+{
+ size_t window = mthp_window_size();
+ void *p;
+
+ mthp_push_target_order();
+
+ p = ops->setup_area(1);
+ ops->fault(p, window, 2 * window);
+ if (any_window_at_order(p, hpage_pmd_size))
+ ksft_exit_fail_msg("Unexpected large folio after fault\n");
+
+ if (madvise(p, hpage_pmd_size, MADV_HUGEPAGE))
+ ksft_exit_fail_perror("madvise(MADV_HUGEPAGE)");
+ ksft_print_msg("Collapse one fully populated window...");
+ if (!khugepaged_full_pass(MTHP_PASS_TIMEOUT_S))
+ fail("Timeout");
+ else if (all_windows_at_order(p + window, window) &&
+ !any_window_at_order(p, window) &&
+ !any_window_at_order(p + 2 * window,
+ hpage_pmd_size - 2 * window))
+ success("OK");
+ else
+ fail("Fail");
+
+ validate_memory(p, window, 2 * window);
+ ops->cleanup_area(p, hpage_pmd_size);
+ thp_pop_settings();
+ ksft_test_result_report(exit_status, "%s\n", __func__);
+}
+
+static void collapse_order_partial_window(struct collapse_context *c,
+ struct mem_ops *ops)
+{
+ void *p;
+
+ mthp_push_target_order();
+
+ p = ops->setup_area(1);
+ ops->fault(p, 0, page_size);
+ if (any_window_at_order(p, hpage_pmd_size))
+ ksft_exit_fail_msg("Unexpected large folio after fault\n");
+
+ if (madvise(p, hpage_pmd_size, MADV_HUGEPAGE))
+ ksft_exit_fail_perror("madvise(MADV_HUGEPAGE)");
+ ksft_print_msg("Collapse window with single PTE entry present...");
+ if (!khugepaged_full_pass(MTHP_PASS_TIMEOUT_S))
+ fail("Timeout");
+ else if (all_windows_at_order(p, mthp_window_size()))
+ success("OK");
+ else
+ fail("Fail");
+
+ validate_memory(p, 0, page_size);
+ ops->cleanup_area(p, hpage_pmd_size);
+ thp_pop_settings();
+ ksft_test_result_report(exit_status, "%s\n", __func__);
+}
+
+static void collapse_order_max_ptes_none(struct collapse_context *c,
+ struct mem_ops *ops)
+{
+ struct thp_settings settings;
+ size_t window = mthp_window_size();
+ void *p;
+
+ mthp_push_target_order();
+ settings = *thp_current_settings();
+ settings.khugepaged.max_ptes_none = 0;
+ thp_push_settings(&settings);
+
+ p = ops->setup_area(1);
+ ops->fault(p, 0, 2 * window - page_size);
+ if (any_window_at_order(p, hpage_pmd_size))
+ ksft_exit_fail_msg("Unexpected large folio after fault\n");
+
+ if (madvise(p, hpage_pmd_size, MADV_HUGEPAGE))
+ ksft_exit_fail_perror("madvise(MADV_HUGEPAGE)");
+ ksft_print_msg("Collapse full window, not the one missing a page...");
+ if (!khugepaged_full_pass(MTHP_PASS_TIMEOUT_S))
+ fail("Timeout");
+ else if (all_windows_at_order(p, window) &&
+ !any_window_at_order(p + window, window))
+ success("OK");
+ else
+ fail("Fail");
+
+ validate_memory(p, 0, 2 * window - page_size);
+ ops->cleanup_area(p, hpage_pmd_size);
+ thp_pop_settings();
+ thp_pop_settings();
+ ksft_test_result_report(exit_status, "%s\n", __func__);
+}
+
+static void collapse_order_mixed_sources(struct collapse_context *c,
+ struct mem_ops *ops)
+{
+ struct thp_settings settings;
+ void *p;
+
+ if (collapse_order <= MIN_MTHP_ORDER) {
+ ksft_test_result_skip("%s: no source order below target\n",
+ __func__);
+ return;
+ }
+
+ mthp_push_target_order();
+
+ settings = *thp_current_settings();
+ settings.hugepages[MIN_MTHP_ORDER].enabled = THP_ALWAYS;
+ thp_push_settings(&settings);
+ p = ops->setup_area(1);
+ ops->fault(p, 0, hpage_pmd_size);
+ thp_pop_settings();
+
+ /*
+ * The allocator can fall back to smaller folios under fragmentation;
+ * having nothing to collapse from is not a failure.
+ */
+ if (!is_range_backed_by_order(p, hpage_pmd_size, MIN_MTHP_ORDER,
+ pagemap_fd, kpageflags_fd)) {
+ ksft_print_msg("No order-%d sources to collapse...",
+ MIN_MTHP_ORDER);
+ skip("Skip");
+ ops->cleanup_area(p, hpage_pmd_size);
+ thp_pop_settings();
+ ksft_test_result_report(exit_status, "%s\n", __func__);
+ return;
+ }
+
+ if (madvise(p, hpage_pmd_size, MADV_HUGEPAGE))
+ ksft_exit_fail_perror("madvise(MADV_HUGEPAGE)");
+ ksft_print_msg("Collapse region backed by smaller large folios...");
+ if (!khugepaged_full_pass(MTHP_PASS_TIMEOUT_S))
+ fail("Timeout");
+ else if (all_windows_at_order(p, hpage_pmd_size))
+ success("OK");
+ else
+ fail("Fail");
+
+ validate_memory(p, 0, hpage_pmd_size);
+ ops->cleanup_area(p, hpage_pmd_size);
+ thp_pop_settings();
+ ksft_test_result_report(exit_status, "%s\n", __func__);
+}
+
static void usage(void)
{
fprintf(stderr, "\nUsage: ./khugepaged [OPTIONS] <test type> [dir]\n\n");
@@ -1377,6 +1571,20 @@ int main(int argc, char **argv)
parse_test_type(argc, argv);
+ if (mthp_khugepaged_context &&
+ !(thp_supported_orders() & (1UL << collapse_order)))
+ ksft_exit_skip("Order %d is not a supported anon THP order\n",
+ collapse_order);
+
+ if (mthp_khugepaged_context) {
+ pagemap_fd = open("/proc/self/pagemap", O_RDONLY);
+ if (pagemap_fd < 0)
+ ksft_exit_fail_perror("open(/proc/self/pagemap)");
+ kpageflags_fd = open("/proc/kpageflags", O_RDONLY);
+ if (kpageflags_fd < 0)
+ ksft_exit_fail_perror("open(/proc/kpageflags)");
+ }
+
setbuf(stdout, NULL);
/*
@@ -1427,6 +1635,10 @@ int main(int argc, char **argv)
TEST(collapse_empty, madvise_context, anon_ops);
TEST(collapse_single_mthp, mthp_khugepaged_context, anon_ops);
+ TEST(collapse_order_single_window, mthp_khugepaged_context, anon_ops);
+ TEST(collapse_order_partial_window, mthp_khugepaged_context, anon_ops);
+ TEST(collapse_order_max_ptes_none, mthp_khugepaged_context, anon_ops);
+ TEST(collapse_order_mixed_sources, mthp_khugepaged_context, anon_ops);
TEST(collapse_single_pte_entry, khugepaged_context, anon_ops);
TEST(collapse_single_pte_entry, khugepaged_context, read_only_file_ops);
_
Patches currently in -mm which might be from kas@kernel.org are
mm-page_alloc-make-defrag_mode-retries-follow-the-promoted-order.patch
mm-khugepaged-drop-redundant-mm_struct-pin-in-madvise_collapse.patch
mm-khugepaged-count-collapses-where-khugepaged-makes-them.patch
mm-khugepaged-rename-mthp_present_ptes-bitmap-to-eligible_ptes.patch
mm-collapse-add-collapseh-for-the-collapse-interface.patch
mm-collapse-state-what-a-collapse-may-do-in-the-policy.patch
mm-collapse-drop-the-collapse_possible-wrapper.patch
mm-collapse-name-the-per-table-scan-reset-for-what-it-resets.patch
mm-collapse-call-collapse_file-from-collapse_single_pmd.patch
mm-collapse-separate-scanning-a-pte-table-from-collapsing-it.patch
mm-collapse-open-code-collapse_single_pmd-in-its-two-callers.patch
mm-collapse-work-out-the-orders-a-vma-allows-once-per-vma.patch
mm-collapse-declare-the-collapse-interface-in-collapseh.patch
mm-collapse-implement-madv_collapse-in-madvisec.patch
reply other threads:[~2026-10-13 4:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013043349.39F781F00893@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=agordeev@linux.ibm.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=jgg@ziepe.ca \
--cc=kas@kernel.org \
--cc=kernel-team@meta.com \
--cc=lance.yang@linux.dev \
--cc=leon@kernel.org \
--cc=liam@infradead.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=mm-commits@vger.kernel.org \
--cc=nico.pache@linux.dev \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=usama.anjum@arm.com \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.