All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	David Ahern <dsahern@kernel.org>, Simon Horman <horms@kernel.org>,
	Kuniyuki Iwashima <kuni1840@gmail.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH v1 net-next 0/4] neighbour: Misc follow-ups on per-netns neigh_table series.
Date: Tue, 13 Oct 2026 10:00:33 +0300	[thread overview]
Message-ID: <20261013070033.GA852441@shredder> (raw)
In-Reply-To: <20261012194530.3751034-1-kuniyu@google.com>

On Mon, Oct 12, 2026 at 07:44:55PM +0000, Kuniyuki Iwashima wrote:
> Patch 1 updates the switchdev doc, s/arp_tbl/arp_table(net)/.
> 
> Patch 2 updates a selftest for per-netns sysctl knobs, though this
> is not an actual issue since the test does not hit gc_thresh by
> default.
> 
> Patches 3 & 4 are based on a suggestion by Ido Schimmel to make
> neigh_managed_work CPU-friendly:
> 
>   https://lore.kernel.org/netdev/20260902143023.GA3966681@shredder/

Thanks for the follow-up, but I think you missed my first point... My
comment was about the GC work that doesn't have a floor at all. An
unprivileged user can set the base reachable time to 0 and
neigh_periodic_work() will hog the CPU.

> 
> Given it's rc7, I'll defer RTNL removal to the next cycle.
> 
> 
> Kuniyuki Iwashima (4):
>   Documentation: networking: switchdev: Replace arp_tbl with
>     arp_table(net).
>   selftests: netfilter: Set gc_thresh[123] for gw netns in
>     nft_nat_zones.sh.
>   neighbour: Schedule neigh_managed_work only when needed.
>   neighbour: Floor INTERVAL_PROBE_TIME_MS at 1000.
> 
>  Documentation/netlink/specs/rt-neigh.yaml     |  2 +-
>  Documentation/networking/ip-sysctl.rst        |  2 +-
>  Documentation/networking/switchdev.rst        | 11 +++---
>  net/core/neighbour.c                          | 26 ++++++++++----
>  .../selftests/net/netfilter/nft_nat_zones.sh  | 34 +++++--------------
>  5 files changed, 35 insertions(+), 40 deletions(-)
> 
> -- 
> 2.56.0.385.gd3acb90ef8-goog
> 

  parent reply	other threads:[~2026-10-13  7:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 19:44 [PATCH v1 net-next 0/4] neighbour: Misc follow-ups on per-netns neigh_table series Kuniyuki Iwashima
2026-10-12 19:44 ` [PATCH v1 net-next 1/4] Documentation: networking: switchdev: Replace arp_tbl with arp_table(net) Kuniyuki Iwashima
2026-10-12 19:44 ` [PATCH v1 net-next 2/4] selftests: netfilter: Set gc_thresh[123] for gw netns in nft_nat_zones.sh Kuniyuki Iwashima
2026-10-13 20:00   ` netdev-bot+sashiko
2026-10-12 19:44 ` [PATCH v1 net-next 3/4] neighbour: Schedule neigh_managed_work only when needed Kuniyuki Iwashima
2026-10-12 19:44 ` [PATCH v1 net-next 4/4] neighbour: Floor INTERVAL_PROBE_TIME_MS at 1000 Kuniyuki Iwashima
2026-10-13  7:16   ` Ido Schimmel
2026-10-13  7:27     ` Kuniyuki Iwashima
2026-10-13 20:00   ` netdev-bot+sashiko
2026-10-13 20:29     ` Kuniyuki Iwashima
2026-10-13 20:30       ` Kuniyuki Iwashima
2026-10-13  7:00 ` Ido Schimmel [this message]
2026-10-13  7:23   ` [PATCH v1 net-next 0/4] neighbour: Misc follow-ups on per-netns neigh_table series Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261013070033.GA852441@shredder \
    --to=idosch@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuni1840@gmail.com \
    --cc=kuniyu@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.