From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: raffaele.tranfaglia@gmail.com, "Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux@analog.com, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: addac: adt7316: use dev_err_probe() for ldac GPIO
Date: Tue, 13 Oct 2026 09:50:07 +0200 [thread overview]
Message-ID: <20261013095007.000052ae@gmail.com> (raw)
In-Reply-To: <as1Q-au8dpp9YFeG@ashevche-desk.local>
On Tue, 13 Oct 2026 00:28:25 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Sun, Oct 11, 2026 at 07:56:22PM +0100, Raffaele Tranfaglia via B4 Relay wrote:
>
> > Use dev_err_probe() when requesting the ldac GPIO fails. This
> > avoids logging an error when the GPIO controller is not ready yet
> > and the request returns -EPROBE_DEFER, and records the deferral
> > reason. It also simplifies the error path.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> Although not sure if we need a Fixes tag as it might be an annoying (but quite
> rare) case of flooding in the dmesg.
AFAIC this is a cleanup rather than a fix. dev_err_probe() conversions
don't add Fixes tags.
--
Kind regards,
Joshua Crofts
next prev parent reply other threads:[~2026-10-13 7:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 18:56 [PATCH] staging: iio: addac: adt7316: use dev_err_probe() for ldac GPIO Raffaele Tranfaglia via B4 Relay
2026-10-11 18:56 ` Raffaele Tranfaglia
2026-10-12 14:35 ` Nuno Sá
2026-10-12 21:27 ` Andy Shevchenko
2026-10-12 21:28 ` Andy Shevchenko
2026-10-13 7:50 ` Joshua Crofts [this message]
2026-10-13 8:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013095007.000052ae@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
--cc=raffaele.tranfaglia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.