All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Ho Jie Feng <hjf3108@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] wifi: rt2x00: use VCO_IC 0x2 for RF3053 on 2.4 GHz
Date: Tue, 13 Oct 2026 12:23:05 +0200	[thread overview]
Message-ID: <20261013102305.GA58849@wp.pl> (raw)
In-Reply-To: <20261012133728.77780-1-hjf3108@gmail.com>

Hi

On Mon, Oct 12, 2026 at 09:37:27PM +0800, Ho Jie Feng wrote:
> Using the 0x1, the VCO calibration result is 0x7f on channels 6
> and below. Using 0x2 fixes it.
>
> Hardware: Netgear WNDA4100 (USB 0846:9013, RT3593 rev 0402, RF3053)
> 
> Signed-off-by: Ho Jie Feng <hjf3108@gmail.com>
> ---
> RFC for this since I am not sure if it is a generic fix, since the
> vendor driver also doesn't use VCO_IC=0x2.
> Is this also a known issue?

Could you elaborate what is the issue and what you mean by
"VCO calibration result is 0x7f" ?

Regards
Stanislaw

> Testing on different hardware would be appreciated.
> 
>  drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> index 2e2e382b62475..4a44a0222210d 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> @@ -2979,7 +2979,7 @@ static void rt2800_config_channel_rf3053(struct rt2x00_dev *rt2x00dev,
>  
>  	rfcsr = rt2800_rfcsr_read(rt2x00dev, 6);
>  	if (rf->channel >= 1 && rf->channel <= 14)
> -		rt2x00_set_field8(&rfcsr, RFCSR6_VCO_IC, 1);
> +		rt2x00_set_field8(&rfcsr, RFCSR6_VCO_IC, 2);
>  	else if (rf->channel >= 36 && rf->channel <= 64)
>  		rt2x00_set_field8(&rfcsr, RFCSR6_VCO_IC, 2);
>  	else if (rf->channel >= 100 && rf->channel <= 128)
> 
> base-commit: af32da41b0327b9c6a37856ba82b6760d6c8d10e
> -- 
> 2.55.0
> 

  reply	other threads:[~2026-10-13 10:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 13:37 [RFC PATCH] wifi: rt2x00: use VCO_IC 0x2 for RF3053 on 2.4 GHz Ho Jie Feng
2026-10-13 10:23 ` Stanislaw Gruszka [this message]
2026-10-13 12:49   ` Jie Feng
2026-10-14  8:31     ` Stanislaw Gruszka
2026-10-14 16:23       ` Jie Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261013102305.GA58849@wp.pl \
    --to=stf_xl@wp.pl \
    --cc=hjf3108@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.