From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C88B4389104; Tue, 13 Oct 2026 11:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791892282; cv=none; b=bHXBZXU/1F8ROvAcadllFyAwZMQ2hbVtBTa9cqwwxlGwI4yHwiy4Qf9zegpyRxHmg/Si9lesZUFfqaJFstnciIguVKS3ox2Lad5qgf7vruLMm7WkvyLxKf4FtgDh1o0MPuh4Q6Fai5s1w7KFyQOYxmxTA0q78ojldwONnyZObLM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791892282; c=relaxed/simple; bh=BJ0NwXc7tHEi9O0Gsaa968SFCkzGvex8H8sVW1mOtBs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fdf7cOlmrHNLUivgfcurYIeTR9p5bb5QHpWKgSTeAap3D/758r45iIhovmIBYNOpTsqTgf/l0vsCXC0WetkOdsXlW8DouGy82Wn79knurNf/qVucJEjIBs1cuPh3SY4lQeEMNkoljXiRSwhAOx1ZInl16AUh3OAiFPrBXBVgkDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CJvszqvt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CJvszqvt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CA941F000FF; Tue, 13 Oct 2026 11:51:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1791892281; bh=ccd28b0XcfC603Z0KPf8ZUazjbe0/nALGCrZbudRnIE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CJvszqvtHi5STC8tHGh6eaDfoEio6xusAtpXScppPskuUAsHZ6GtoQB7v59g30dc2 kf+XDbqoHv5GmYQ6+ARzlBzu8XUp4Vu/4RzsknWX07lcsrN3Y5ZVQeBf2VZX9SidEM C0xgr7NCz0yOAZvvbsBlLX1ZAkBPe68Oy80NeYL8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Iaroslav Voitovych , Luiz Augusto von Dentz Subject: [PATCH 7.2 119/281] Bluetooth: MGMT: Fix status of pending commands flushed on power off Date: Tue, 13 Oct 2026 13:37:15 +0200 Message-ID: <20261013112858.037706235@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261013112855.045212108@linuxfoundation.org> References: <20261013112855.045212108@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Iaroslav Voitovych commit 86ef0f58bdecdedb3a1240971c56d71b7e4ce3fc upstream. cmd_complete_rsp() receives a struct cmd_lookup and, for a pending command that has no cmd_complete callback, falls through to cmd_status_rsp(cmd, data). cmd_status_rsp() reads data as a u8 *, so the status sent comes from the first byte of match->sk's representation, not from match->mgmt_status. commit f53e1c9c726d ("Bluetooth: MGMT: Fix possible crash on mgmt_index_removed") changed the callers' data from &status to &match and updated the cmd_complete branch to match->mgmt_status, but left the fall-through passing data unchanged. In mgmt_index_removed() match->sk is NULL, so every such command is answered with status 0x00 (Success) instead of MGMT_STATUS_INVALID_INDEX. In __mgmt_power_off() it is NULL too, unless a Set Powered command was pending: then settings_rsp() has stored that command's socket in match->sk, and the byte sent comes from the socket pointer. Either way the status the caller set, MGMT_STATUS_NOT_POWERED (or MGMT_STATUS_INVALID_INDEX when the device is being unregistered), is lost. Pass the status the callers set. This was seen on a QCA9377 laptop: bluetoothd's Start Discovery, pending when the adapter was powered off, was answered with Command Status 0x00 and no parameters, and bluetoothd 5.72 crashed on the zero-length success. BlueZ master has since added the length check on that path ("adapter: Fix crash on short start discovery reply", BlueZ a734b06059cb), but userspace should still be told Not Powered, not Success. Tested on Ubuntu 7.0.0-31 with a virtual controller (hci_vhci): power off is held in HCI Write Scan Enable while a Start Discovery is submitted, and the flush answers it with status 0x00 before this change and 0x0f (Not Powered) after. Fixes: f53e1c9c726d ("Bluetooth: MGMT: Fix possible crash on mgmt_index_removed") Cc: stable@vger.kernel.org Signed-off-by: Iaroslav Voitovych Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Greg Kroah-Hartman --- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -1489,7 +1489,7 @@ static void cmd_complete_rsp(struct mgmt return; } - cmd_status_rsp(cmd, data); + cmd_status_rsp(cmd, &match->mgmt_status); } static int generic_cmd_complete(struct mgmt_pending_cmd *cmd, u8 status)