From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BBB74F472E; Tue, 13 Oct 2026 11:51:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791892312; cv=none; b=fKGlSFlkS7ZYNOBJU+UXCCl/vjoZ4mSXgxY1raGSLpvJBIjrCrcjxaPywxT8q92y9WP+JOVHnf0fz/4VQVMGa92YUExYU2uUK95IPxzgRugDszCLtmsukKyjzDKAWbjRFbAkIbHXMpvV3AwFRE0WM19INgcBR2Xn9eKsvs1DOI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791892312; c=relaxed/simple; bh=Y6teyfzU9Tz3FiOowDRK/9NUaLS1d3MnJmKFH8pHNIw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MvTRB503LcH0mGcG0tH5WW8CCdzOKdASVG7Y1FVRlDJeKm2uGbk6m1/bbkcRCX47LhbF4jYjea3EqCDvyPWs+effV1EGM2JAsZ6KBUT80+B5oHKqhKA2myJOpnOexo+FQsI1iMeHL3pa0l+NZqomziyE/G8rHoMIIEm0mTXbRnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SN/eYwUc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SN/eYwUc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AD521F0089A; Tue, 13 Oct 2026 11:51:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1791892308; bh=6ORWzmf6XFqNniwme5mNdh1DMLD5weTzAJIofXvdezY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=SN/eYwUcFP3xYGWuNq7+o4dahHT+y7hVMDqgSJbHoIgNgl0VgcjDr/p8YfoeJNHRx x9c8HzhUqKu3kAQFrnUeQd2PjtbWpIML8Qanw178zHOfagk0JWQOGEDaf9HXpAULWf 2m+A0zEccaemwe/vtigBUBWhp21NmYu0e2MwoWgc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+4a807caf7680652d53b6@syzkaller.appspotmail.com, Palla Raghunath , Luiz Augusto von Dentz Subject: [PATCH 7.2 123/281] Bluetooth: RFCOMM: Fix NULL tty_dev dereference in rfcomm_dev_shutdown Date: Tue, 13 Oct 2026 13:37:19 +0200 Message-ID: <20261013112858.134721569@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261013112855.045212108@linuxfoundation.org> References: <20261013112855.045212108@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Palla Raghunath commit 08e90633377f1b2567ab5ad6810b74c552246a07 upstream. syzbot hit a NULL pointer dereference in rfcomm_dev_shutdown() when an RFCOMM tty is closed. rfcomm_dev_add() puts the new device on rfcomm_dev_list first and only then registers the tty device and saves it in dev->tty_dev. If that registration fails, dev->tty_dev is never set at all. The device can be looked up in the meantime, so an open() of /dev/rfcommN gets through rfcomm_tty_install() and attaches to it. When that tty is closed again, rfcomm_dev_shutdown() uses dev->tty_dev without checking it: Oops: general protection fault, probably for non-canonical address KASAN: null-ptr-deref in range [0x0000000000000040-0x0000000000000047] RIP: 0010:rfcomm_dev_shutdown+0x48/0xb0 net/bluetooth/rfcomm/tty.c:131 Call Trace: tty_port_shutdown+0x1bf/0x220 drivers/tty/tty_port.c:372 tty_port_close+0x4e/0x150 drivers/tty/tty_port.c:705 tty_release+0x359/0x1670 drivers/tty/tty_io.c:1718 __fput+0x418/0xa50 fs/file_table.c:512 rfcomm_dev_destruct() already copes with a NULL dev->tty_dev. Add the same check to rfcomm_dev_shutdown(), so the tty device is only moved when it was actually registered. Fixes: cad348a17e17 ("Bluetooth: Implement .activate, .shutdown and .carrier_raised methods") Reported-by: syzbot+4a807caf7680652d53b6@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=4a807caf7680652d53b6 Cc: stable@vger.kernel.org Signed-off-by: Palla Raghunath Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Greg Kroah-Hartman --- net/bluetooth/rfcomm/tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/bluetooth/rfcomm/tty.c +++ b/net/bluetooth/rfcomm/tty.c @@ -128,7 +128,7 @@ static void rfcomm_dev_shutdown(struct t { struct rfcomm_dev *dev = container_of(port, struct rfcomm_dev, port); - if (dev->tty_dev->parent) + if (dev->tty_dev && dev->tty_dev->parent) device_move(dev->tty_dev, NULL, DPM_ORDER_DEV_LAST); /* close the dlc */