From: Ido Schimmel <idosch@nvidia.com>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: Anirudh Virdi <avirdi@redhat.com>,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, kees@kernel.org,
horms@kernel.org, linux-kernel@vger.kernel.org,
Vadim Pasternak <vadimp@nvidia.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: qede: initialize extack in qede_flow_spec_to_rule()
Date: Tue, 13 Oct 2026 16:12:50 +0300 [thread overview]
Message-ID: <20261013131250.GA1038950@shredder> (raw)
In-Reply-To: <9189f66d-7ce5-4f79-a55b-f73776c7c0bc@fiberby.net>
On Tue, Oct 13, 2026 at 12:50:50PM +0000, Asbjørn Sloth Tønnesen wrote:
> CC Vadim and Ido:
> As stated in the blamed commit message, my implementation was based on
> mlxsw_env_linecard_modules_power_mode_apply() by commit 06a0fc43bb10
> ("mlxsw: core_env: Add interfaces for line card initialization and
> de-initialization"), so likely that also needs to be fixed. I don't
> have the hardware to prove/test that it can be triggered.
Unlike qede_flow_spec_to_rule(),
mlxsw_env_linecard_modules_power_mode_apply() only prints extack on
error and mlxsw_env_set_module_power_mode_apply() sets the extack on all
the error paths.
next prev parent reply other threads:[~2026-10-13 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 10:54 [PATCH net] net: qede: initialize extack in qede_flow_spec_to_rule() Anirudh Virdi
2026-10-13 12:50 ` Asbjørn Sloth Tønnesen
2026-10-13 13:12 ` Ido Schimmel [this message]
2026-10-13 19:49 ` Daniel Machon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013131250.GA1038950@shredder \
--to=idosch@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@fiberby.net \
--cc=avirdi@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.