All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Fabiano Rosas" <farosas@suse.de>, "Peter Xu" <peterx@redhat.com>
Subject: [PATCH 2/4] Revert "io: add support for activating TLS thread safety workaround"
Date: Tue, 13 Oct 2026 14:36:20 +0100	[thread overview]
Message-ID: <20261013133622.993935-3-berrange@redhat.com> (raw)
In-Reply-To: <20261013133622.993935-1-berrange@redhat.com>

This reverts commit edea818371bd7179b55f38d3b113d342251d8f9b.

The workaround for the GNUTLS bug was not correct and it was
decided to rely on GNUTLS being patched by distros instead,
or users manually disabling use of the problematic ciphers.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 include/io/channel.h | 1 -
 io/channel-tls.c     | 5 -----
 2 files changed, 6 deletions(-)

diff --git a/include/io/channel.h b/include/io/channel.h
index c90ace20d53..834ba7c3098 100644
--- a/include/io/channel.h
+++ b/include/io/channel.h
@@ -47,7 +47,6 @@ enum QIOChannelFeature {
     QIO_CHANNEL_FEATURE_WRITE_ZERO_COPY,
     QIO_CHANNEL_FEATURE_READ_MSG_PEEK,
     QIO_CHANNEL_FEATURE_SEEKABLE,
-    QIO_CHANNEL_FEATURE_CONCURRENT_IO,
 };
 
 
diff --git a/io/channel-tls.c b/io/channel-tls.c
index 05317ed5a38..5b0524e68dd 100644
--- a/io/channel-tls.c
+++ b/io/channel-tls.c
@@ -261,11 +261,6 @@ void qio_channel_tls_handshake(QIOChannelTLS *ioc,
 {
     QIOTask *task;
 
-    if (qio_channel_has_feature(QIO_CHANNEL(ioc),
-                                QIO_CHANNEL_FEATURE_CONCURRENT_IO)) {
-        qcrypto_tls_session_require_thread_safety(ioc->session);
-    }
-
     task = qio_task_new(OBJECT(ioc),
                         func, opaque, destroy);
 
-- 
2.56.0



  parent reply	other threads:[~2026-10-13 13:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 13:36 [PATCH 0/4] Revert obsolete & broken workaround for GNUTLS thread safety bug Daniel P. Berrangé
2026-10-13 13:36 ` [PATCH 1/4] Revert "migration: activate TLS thread safety workaround" Daniel P. Berrangé
2026-10-13 13:36 ` Daniel P. Berrangé [this message]
2026-10-13 13:36 ` [PATCH 3/4] Revert "crypto: add tracing & warning about GNUTLS countermeasures" Daniel P. Berrangé
2026-10-13 13:36 ` [PATCH 4/4] Revert "crypto: implement workaround for GNUTLS thread safety problems" Daniel P. Berrangé
2026-10-13 19:29 ` [PATCH 0/4] Revert obsolete & broken workaround for GNUTLS thread safety bug Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261013133622.993935-3-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=farosas@suse.de \
    --cc=marcandre.lureau@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.