Re: [PATCH 0/3] lib/crypto: x86/sha: Follow the normal %rbp convention

[Eric Biggers <ebiggers@kernel.org>]

On Sun, Oct 11, 2026 at 03:48:40PM +0200, Eric Biggers wrote:
> This series updates the x86 SHA-1, SHA-256, and SHA-512 assembly code to
> set up %rbp before pushing GPRs rather than after, so that the frame
> pointer unwinder will generate call traces reliably.
> 
> This doesn't matter much, given that the ORC unwinder is the default,
> and the fallback to scanning the stack made call traces sort of "work"
> anyway.  But it annoyed me that these assembly functions use the "wrong"
> %rbp convention, differing from the C code.
> 
> This series is targeting libcrypto-next.
> 
> Eric Biggers (3):
>   lib/crypto: x86/sha1: Follow the normal %rbp convention
>   lib/crypto: x86/sha256: Follow the normal %rbp convention
>   lib/crypto: x86/sha512: Follow the normal %rbp convention
> 
>  lib/crypto/x86/sha1-avx2-asm.S      | 10 +++++-----
>  lib/crypto/x86/sha1-ssse3-and-avx.S |  9 +++++----
>  lib/crypto/x86/sha256-avx-asm.S     | 10 +++++-----
>  lib/crypto/x86/sha256-avx2-asm.S    | 10 ++++------
>  lib/crypto/x86/sha256-ni-asm.S      |  9 +++++----
>  lib/crypto/x86/sha256-ssse3-asm.S   |  8 ++++----
>  lib/crypto/x86/sha512-avx-asm.S     | 11 ++++++-----
>  lib/crypto/x86/sha512-avx2-asm.S    | 11 ++++++-----
>  lib/crypto/x86/sha512-ssse3-asm.S   | 11 ++++++-----
>  9 files changed, 46 insertions(+), 43 deletions(-)

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next

- Eric