Re: [PATCH 1/2] xfs: add missing cursor status check after xfs_get_rec

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Oct 13, 2026 at 04:07:46PM -0500, Eric Sandeen wrote:
> The xfs_inobt_get_rec() call in xfs_ialloc_count_ondisk fails to check
> the &has_record return - if the record is not found, the next
> conditional will read an uninitialized  or stale irec. Fix that.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Yeah, we had better check has_record before using irec...
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/libxfs/xfs_ialloc.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/fs/xfs/libxfs/xfs_ialloc.c b/fs/xfs/libxfs/xfs_ialloc.c
> index e705f681ed44..17699f7c009f 100644
> --- a/fs/xfs/libxfs/xfs_ialloc.c
> +++ b/fs/xfs/libxfs/xfs_ialloc.c
> @@ -2843,6 +2843,11 @@ xfs_ialloc_count_ondisk(
>  		error = xfs_inobt_get_rec(cur, &irec, &has_record);
>  		if (error)
>  			return error;
> +		if (XFS_IS_CORRUPT(cur->bc_mp, has_record != 1)) {
> +			xfs_btree_mark_sick(cur);
> +			return -EFSCORRUPTED;
> +		}
> +
>  		if (irec.ir_startino > high)
>  			break;
>  
> -- 
> 2.55.0
> 
>