From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48DE65650E1 for ; Tue, 13 Oct 2026 22:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791931227; cv=none; b=QiftOZhFHq2ea7vJu7w65M+9Cy8tzD+6Gbf3jE2yW7/i+vHpH77NXurLVQJLP0+Y67dZcmbGmfohNplw0Bk+R4LJn2DMKUOcHU4dp6slLLMxnJ4EhLWlVtkinASf1PHsOxGOYfCMkDxFuipNnwXqleVIftoHAquHSFLbUVnVbI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791931227; c=relaxed/simple; bh=uNMrTEMgpiVDbGIrdW7hNuAL0UJnSkmxUybVeT9BNfA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=uAhlhxDIcVkGEGG5gfjZ2b8ISMN9XziWxlMX1z041QaugjotuJTb90Bsxy4j0/S9guWCLr8t8aPVfPdpPsDZt+ECDshykSDHgGEB/j7Z0IVqNObx6d9OVQQBtUVkkQdNBKHprZoTy4MiM8EgB+Fp+ZGCra5nQarmzIJ68YpISNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=uVvvOODh; arc=none smtp.client-ip=74.125.82.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="uVvvOODh" Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-35a4d2e39acso1187136eec.1 for ; Tue, 13 Oct 2026 15:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1791931221; x=1792536021; darn=lists.linux.dev; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4r3hXDLd6Bqk9XmcFR/JS5uHIdkPs2TN+2FSnsngXIE=; b=uVvvOODhSSWYvKAN4SKaRn4WD+9BRml4a6HpX984YXCpv6kQRl28DcPEYIrWVSyEEe LSfr0T5HJMcqQz6CcdNi/suoN1b3Ck4RrPpUiVNT3TPcbttNJtcidi/Uk2DRWCACCpNj ZJf81+3ogiofUX29yLFgvxC0ZpmiCk+VCutGS5Vda9EadOUIaUvbu0xF7GozvRuZ0W4l ZHooT77HPsYIVVtmUDZTBY2kyrQhUKL2TqeE17YKbKNj/DzsS2TqHpnRbUjEgIPrHUpn NEgd4+tjzHESsdloz0Y5CKp9vvuCoT7go47BQ7ogZwbptTaBSxnIGEMtVh/DtNzwqmGy 9zXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791931221; x=1792536021; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4r3hXDLd6Bqk9XmcFR/JS5uHIdkPs2TN+2FSnsngXIE=; b=JAKpYx7wIjiBJUJXXQ8A7ATE5OL5e10ummzR2mT7Abm+A6jGLUqy+9PD3sRpcwAn06 dip/ydkOgorOHPBCWQYT4mbZD2LZBmHTW9/2Y+i0WAJB/SSbkwhAXZsUAKHcpvOU1NoS e+b3pxmBEMEEDHcZPZayguSdPoJm7PRJ4ONG7uFY5FRnn2HFUPCJt18bFYsaWV+LA7Hg W7NR6GBzsDoPTLFTDoVvFOUWLEoo+lgEkmiG3Od/U0B/uOOn0bV56hoTQoTzYKiLUHAi T1Nl08Q8SWQVeCPFQTFrOJ3Re/PykkC26uPi8oaEeZC3YcBGYmFzEoSgtpYNTkZ2RxzL OjMQ== X-Forwarded-Encrypted: i=1; AKwUvBxnSQNhmVY86K5wmZ8lB6OzS3q7NmmDINDS1llqAl2Tkh0I5kV8ZhNgkomqMta/i5sDF/X7@lists.linux.dev X-Gm-Message-State: AFq9FYI72w7Kw9hf0o+jhsWOzgVkI3ztBVAjhBtpj2AkVuT//EO/5l0T rPMq9T+d6vMH7lNZNY9R5DBmRnwEUPicQv1Yc7yHkHyy+QU9Fh8TEc3n+Rkyt+cyp32zGtxOIn2 YgThU3nVlvw== X-Received: from dyu6.prod.google.com ([2002:a05:693c:8106:b0:352:94e:a8c9]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7301:71a8:b0:358:f717:ff61 with SMTP id 5a478bee46e88-358f717ff90mr13337962eec.6.1791931219210; Tue, 13 Oct 2026 15:40:19 -0700 (PDT) Date: Tue, 13 Oct 2026 15:39:38 -0700 In-Reply-To: <20261013223946.1836757-1-irogers@google.com> Precedence: bulk X-Mailing-List: gfs2@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20261013223946.1836757-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.385.gd3acb90ef8-goog Message-ID: <20261013223946.1836757-4-irogers@google.com> Subject: [PATCH 03/11] sh: sq: Add missing kobject release callback to ktype_percpu_entry From: Ian Rogers To: Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Miguel Ojeda , Kees Cook , Nathan Chancellor Cc: Nick Desaulniers , Bill Wendling , Justin Stitt , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Viresh Kumar , David Teigland , Alexander Aring , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Richard Weinberger , Zhihao Cheng , Felix Kuehling , Alex Deucher , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-s390@vger.kernel.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" In sq_dev_add(), sq_kobject[cpu] is dynamically allocated with kzalloc_obj() and initialized with ktype_percpu_entry. When sq_dev_remove() calls kobject_put(kobj), the kobject is never freed because ktype_percpu_entry lacks a .release callback. Provide a sq_kobj_release() callback that calls kfree(kobj). Fixes: d7c30c682a27 ("sh: Store Queue API rework.") Assisted-by: Antigravity:gemini-3.1-pro Signed-off-by: Ian Rogers --- arch/sh/kernel/cpu/sh4/sq.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c index 908a8e09113b..f33864958487 100644 --- a/arch/sh/kernel/cpu/sh4/sq.c +++ b/arch/sh/kernel/cpu/sh4/sq.c @@ -331,7 +331,13 @@ static const struct sysfs_ops sq_sysfs_ops = { .store = sq_sysfs_store, }; +static void sq_kobj_release(struct kobject *kobj) +{ + kfree(kobj); +} + static struct kobj_type ktype_percpu_entry = { + .release = sq_kobj_release, .sysfs_ops = &sq_sysfs_ops, .default_groups = sq_sysfs_groups, }; -- 2.56.0.385.gd3acb90ef8-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33A39CC6B1E for ; Tue, 13 Oct 2026 22:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=h+V+mQtc3RoqyD+a0wCyX+dDbe1PtTzirh1DzJaj6oM=; b=UXNkf7nfgjC0STrVUVPZw7As/B ILBEssWEHx4eMC3krhhKegqjfTEmLWv8GkQ5Tg/MeAuet80pWTJN21KrLRT2hP/cRVWtcKIygbrdK wA+Ohg0vz0yd4ompoHTv9771X/wtcQei8kYbpNIOns11s/r+bOZYwdArkyk08RWuecti736zo0oCN NuogS84WQ5vrRxV/H3I/2AYBVusrqtG8ZZ6tBYODk0TH3aAP8BguIBwwnq+ehMhmmoB90KXIYh6mJ gLa4ZHyRBk7L6aABYLWa6LpTGbpkOYm1Uo0ukB4JvGKOFrHghZiqLPd8q1no8TEq2qPlImL7HyOry fub/AZiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGlAW-0000000E9RX-2P3q; Tue, 13 Oct 2026 22:40:24 +0000 Received: from mail-dy1-x1347.google.com ([2607:f8b0:4864:20::1347]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGlAT-0000000E9PO-0A5f for linux-mtd@lists.infradead.org; Tue, 13 Oct 2026 22:40:22 +0000 Received: by mail-dy1-x1347.google.com with SMTP id 5a478bee46e88-35c5aef2a74so1454360eec.0 for ; Tue, 13 Oct 2026 15:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1791931220; x=1792536020; darn=lists.infradead.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4r3hXDLd6Bqk9XmcFR/JS5uHIdkPs2TN+2FSnsngXIE=; b=JrNFOBL72a7hnPpDIii6M/FChwe8PLCrsTCD9/B8NlAFPPF3unsO8oOxJ0u+1nc3Kw 1+xpbWxoaPP4vthUF7OikdhkThDO5d/F6j91yZTXCw4a+w/2gXcVNwEGDIQa1ZqFvHkY u2Jvt5cUqpY08HPkx+I7FYd+EUK+SAxKJAjTEf/6btgx0L66SiZXVJO/LJJM8JUWGS93 1iGw6O6t3kUkILuxnBY0DXC0OCzc81V/Kjf8gc9xXUOxSk7L7jIlpyH8JApzU+meRQHg 1CD7eIQM575Ja04we5CNTeHR/VVbL8nVtgXpdxP6rq4xxRdboNQBaRVccFkIbmiIeI2A gUuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791931220; x=1792536020; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4r3hXDLd6Bqk9XmcFR/JS5uHIdkPs2TN+2FSnsngXIE=; b=Fa//uhIThDrBtbNIASkj4q8snnpwu2xqEAVjO0bKmkLUhaD3ttZu9w3fWI0SiGGn4P i9QkKUBNY6cOO4AZikZICuPBCeapo6+e243BrZfJdyZZuYn8nxvXF8ZOeC4lwXWd0MR3 +xDbEE+iVhKslyO1B+ZBaOKlbPJwwVrYpDbW9HjpzjqmpbkZitP0B6CEw0DeV1Eef2VR W3w9GoJgp9DSSA407zdNlTfFo/BxcRKSvL9I2cQxQMtWOfVJ5qgxaGv8X/8rOyuvyh6l d0I1kuUQtvB87un+4Iidjvg7K3TXLmx21gtiLjhL36S6OMj9ghifM6iU3yNkPxtTV8Q+ 6FbA== X-Forwarded-Encrypted: i=1; AKwUvBxYYna6OOjQgkt1P038sF/MjYRvPZWAFvtCSv9QpuUfknt8Mh2D2ToU2tG5PFDG5fmWmOkj/ROzk9U=@lists.infradead.org X-Gm-Message-State: AFq9FYKDOwQ2m7Qv1N3EgkQEubQgodPWWo0+sGfDSxibn6fKfIoTFIlp potSem2zaQMFbsgBxUX6gx3gA8JLqW18QulGcUQgaW23w4K+a9EPl6jgNR083LmBmy+AEbXXLlN rrnYtjFeIrA== X-Received: from dyu6.prod.google.com ([2002:a05:693c:8106:b0:352:94e:a8c9]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7301:71a8:b0:358:f717:ff61 with SMTP id 5a478bee46e88-358f717ff90mr13337962eec.6.1791931219210; Tue, 13 Oct 2026 15:40:19 -0700 (PDT) Date: Tue, 13 Oct 2026 15:39:38 -0700 In-Reply-To: <20261013223946.1836757-1-irogers@google.com> Mime-Version: 1.0 References: <20261013223946.1836757-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.385.gd3acb90ef8-goog Message-ID: <20261013223946.1836757-4-irogers@google.com> Subject: [PATCH 03/11] sh: sq: Add missing kobject release callback to ktype_percpu_entry From: Ian Rogers To: Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Miguel Ojeda , Kees Cook , Nathan Chancellor Cc: Nick Desaulniers , Bill Wendling , Justin Stitt , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Viresh Kumar , David Teigland , Alexander Aring , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Richard Weinberger , Zhihao Cheng , Felix Kuehling , Alex Deucher , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-s390@vger.kernel.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261013_154021_100220_6EEDBFA4 X-CRM114-Status: GOOD ( 10.85 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org In sq_dev_add(), sq_kobject[cpu] is dynamically allocated with kzalloc_obj() and initialized with ktype_percpu_entry. When sq_dev_remove() calls kobject_put(kobj), the kobject is never freed because ktype_percpu_entry lacks a .release callback. Provide a sq_kobj_release() callback that calls kfree(kobj). Fixes: d7c30c682a27 ("sh: Store Queue API rework.") Assisted-by: Antigravity:gemini-3.1-pro Signed-off-by: Ian Rogers --- arch/sh/kernel/cpu/sh4/sq.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c index 908a8e09113b..f33864958487 100644 --- a/arch/sh/kernel/cpu/sh4/sq.c +++ b/arch/sh/kernel/cpu/sh4/sq.c @@ -331,7 +331,13 @@ static const struct sysfs_ops sq_sysfs_ops = { .store = sq_sysfs_store, }; +static void sq_kobj_release(struct kobject *kobj) +{ + kfree(kobj); +} + static struct kobj_type ktype_percpu_entry = { + .release = sq_kobj_release, .sysfs_ops = &sq_sysfs_ops, .default_groups = sq_sysfs_groups, }; -- 2.56.0.385.gd3acb90ef8-goog ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/