Re: [LTP] [PATCH v4 4/4] testcases: drop manual tst_modprobe() now handled by tst_kconfig

[Wake Liu via ltp <ltp@lists.linux.it>]

Hi Li,

> Drop the explicit tst_modprobe() calls, and the now unused
> tst_module.h includes, from:
>
> - cve-2026-46331.c: sch_ingress, cls_matchall, act_pedit
> - sctphantom.c: sctp
> - keyctl29.c: x509_key_parser
> - keyctl30.c: pkcs8_key_parser

Could you please drop the tst_modprobe() call from keyctl23.c in this
patch as well?

keyctl23 still calls tst_modprobe("x509_key_parser", NULL) in setup(),
but it requires CONFIG_X509_CERTIFICATE_PARSER=y, so the parser is
always built in and there is nothing to load. With the call gone, the
tst_module.h include and the "Requires root (CAP_SYS_MODULE) to load
the x509_key_parser module" line in the doc comment can go as well.

On most distributions the call is harmless, since modprobe returns 0
for built-in modules, but on Android it breaks the test. Without -d,
Android's modprobe scans /lib/modules/, which does not exist on Android
devices, so it always fails and tst_modprobe() turns that into TBROK:

  modprobe: Failed to scan dir /lib/modules/: No such file or directory
  lib/tst_cmd.c:114: TBROK: 'modprobe' exited with a non-zero code 1

keyctl29 fails the same way today, and this series fixes it since
modprobe is no longer called when the parser is built in. With keyctl23
covered too, we can re-enable both tests in Android VTS. If you would
rather keep this series as is, I can send a separate patch for keyctl23.

Thanks,
Wake

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp