From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61C99388379; Wed, 14 Oct 2026 16:37:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791995868; cv=none; b=uLHAiLxeEHZmBC+d++sSKHA2PHePH18k3PKMHCTAhQe/H4WBaOhBreOAWOwAu/vrMURJinJmBc9V8OgKY+mvCQ6SSZHC0pCRRxpwC4jC6om0RJQb9wpIm4KnhHG1GfFLz/8DtwcTs3HaJh6sZ9k7kh4a5gkPpLQh1KVryw1+4Sw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791995868; c=relaxed/simple; bh=cGSxF91ewmP3BSDbm46gFmGwE83pD8gx4uyracVUMG4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HHOa/kfjcpXjs7G5urZFprHsMvgEiTlw+H80WJ95sPDmRveOYOd/NERJpTUJhCYLsGk99SuTdjIdsrf7prtlXZE517HOmsnvw6fUoOR9p8ol+Tx41uUVT+l1qM6T7TdUnEA8X4Ya5Np3yel5WDIupHRWPGjGvSFNICDx9P3Uxko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GwrpOxog; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GwrpOxog" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3E201F000C4; Wed, 14 Oct 2026 16:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791995864; bh=ovAqcUcR1GnKTtcInlqEnrexmz1gsb8w6q2FfK1T5r4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=GwrpOxogXrqhTXQ0pfmjgGMR/nhqs689d6d2T2UbxyqwEi+VJ/4ET2F3bxSsa/yCN EaglIPzBQ4qutHm/Eihe0pPBAWe+NlyY72FoJLC4Rcx8zYnrd+VBcodEifrd7JTzwT 8EqOjY6NHHc/4uGTfqT13dIP1aP05fs1tpq0wWe/LFtLEAv3fcER387/hVuHvXtsuD UxSDlOug9/2BlYA6zAYEAL+qTg5TM5momYM01f0IFfrqT1XCvpcIhwvzWCD/yfd3Rd ixvRP2r8X3I5Gfn87O/r4tNbn1q5lLdLD9Jj9tp7JpRRBzFzF6fUQnw/3GazF0kGmz Z7FdXtLFV/36A== Date: Wed, 14 Oct 2026 09:37:44 -0700 From: Kees Cook To: Miguel Ojeda Cc: Ian Rogers , Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Miguel Ojeda , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Viresh Kumar , David Teigland , Alexander Aring , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Richard Weinberger , Zhihao Cheng , Felix Kuehling , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-s390@vger.kernel.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/11] Compiler Attributes: Add __require_explicit_initialization macro Message-ID: <202610140937.B68C8C9AAC@keescook> References: <20261013223946.1836757-1-irogers@google.com> <20261013223946.1836757-2-irogers@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Oct 14, 2026 at 01:28:55PM +0200, Miguel Ojeda wrote: > On Wed, Oct 14, 2026 at 12:40 AM Ian Rogers wrote: > > > > +/* > > + * Optional: not supported by gcc > > + * > > + * clang: https://clang.llvm.org/docs/AttributeReference.html#require-explicit-initialization > > + */ > > +#if __has_attribute(__require_explicit_initialization__) > > +# define __require_explicit_initialization __attribute__((__require_explicit_initialization__)) > > +#else > > +# define __require_explicit_initialization > > +#endif > > The LPC slides mention Clang 14+, but from a quick test in Compiler > Explorer and a `git log --grep` on the LLVM repository to confirm, it > seems the attribute was introduced in Clang 20+, no? > > If that is correct, then it is not available in all LLVM versions we > support (LLVM 17+), so we should add: > > * Optional: only supported since clang >= 20.0 > > With that: > > Acked-by: Miguel Ojeda Yup, I can confirm, I only see it with 20+ too. -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D665ACC6B1A for ; Wed, 14 Oct 2026 16:37:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pijDe9CNRZkxIPiO6kOxQjz2S0bjOq+SrdeqghtPB4o=; b=WfZPzzjD0+YGHp 2sYUEtZCAZ+2AtUEqAgay7cgM8hY8691O5w5ggZc+0mkMJ3fSjNaNeDLsPuOm5whC8L665EEkHfnI 1+AqnnnYpWbX8qOvCHLJZ2MjQpMUEXjpMN8wIY79ok327KcCpK/KpN+FXioVWLdIM+ko83mKGg5jR +x6npya0a06dKPy6fW6xGjRqEZfY6YD+lLUFZKs/vqwfdyGroArYkMYJp8TnSL/rVI2mcSHjR9cOl rrrNS2dNM47J/b9VXUBoT9TuqT4MrtPrDVTT70EYj5rbqtO/yJvR6Jbl+V4bMCOWra/Ll6q21Ixi6 EHUohSt1nFTW5ptU1oFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xH1z9-0000000G0gc-1xJ3; Wed, 14 Oct 2026 16:37:47 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xH1z7-0000000G0gM-0XqA for linux-mtd@lists.infradead.org; Wed, 14 Oct 2026 16:37:45 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id C9B3E4094A; Wed, 14 Oct 2026 16:37:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3E201F000C4; Wed, 14 Oct 2026 16:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791995864; bh=ovAqcUcR1GnKTtcInlqEnrexmz1gsb8w6q2FfK1T5r4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=GwrpOxogXrqhTXQ0pfmjgGMR/nhqs689d6d2T2UbxyqwEi+VJ/4ET2F3bxSsa/yCN EaglIPzBQ4qutHm/Eihe0pPBAWe+NlyY72FoJLC4Rcx8zYnrd+VBcodEifrd7JTzwT 8EqOjY6NHHc/4uGTfqT13dIP1aP05fs1tpq0wWe/LFtLEAv3fcER387/hVuHvXtsuD UxSDlOug9/2BlYA6zAYEAL+qTg5TM5momYM01f0IFfrqT1XCvpcIhwvzWCD/yfd3Rd ixvRP2r8X3I5Gfn87O/r4tNbn1q5lLdLD9Jj9tp7JpRRBzFzF6fUQnw/3GazF0kGmz Z7FdXtLFV/36A== Date: Wed, 14 Oct 2026 09:37:44 -0700 From: Kees Cook To: Miguel Ojeda Cc: Ian Rogers , Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Miguel Ojeda , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Viresh Kumar , David Teigland , Alexander Aring , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Richard Weinberger , Zhihao Cheng , Felix Kuehling , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-s390@vger.kernel.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/11] Compiler Attributes: Add __require_explicit_initialization macro Message-ID: <202610140937.B68C8C9AAC@keescook> References: <20261013223946.1836757-1-irogers@google.com> <20261013223946.1836757-2-irogers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gV2VkLCBPY3QgMTQsIDIwMjYgYXQgMDE6Mjg6NTVQTSArMDIwMCwgTWlndWVsIE9qZWRhIHdy b3RlOgo+IE9uIFdlZCwgT2N0IDE0LCAyMDI2IGF0IDEyOjQw4oCvQU0gSWFuIFJvZ2VycyA8aXJv Z2Vyc0Bnb29nbGUuY29tPiB3cm90ZToKPiA+Cj4gPiArLyoKPiA+ICsgKiBPcHRpb25hbDogbm90 IHN1cHBvcnRlZCBieSBnY2MKPiA+ICsgKgo+ID4gKyAqIGNsYW5nOiBodHRwczovL2NsYW5nLmxs dm0ub3JnL2RvY3MvQXR0cmlidXRlUmVmZXJlbmNlLmh0bWwjcmVxdWlyZS1leHBsaWNpdC1pbml0 aWFsaXphdGlvbgo+ID4gKyAqLwo+ID4gKyNpZiBfX2hhc19hdHRyaWJ1dGUoX19yZXF1aXJlX2V4 cGxpY2l0X2luaXRpYWxpemF0aW9uX18pCj4gPiArIyBkZWZpbmUgX19yZXF1aXJlX2V4cGxpY2l0 X2luaXRpYWxpemF0aW9uIF9fYXR0cmlidXRlX18oKF9fcmVxdWlyZV9leHBsaWNpdF9pbml0aWFs aXphdGlvbl9fKSkKPiA+ICsjZWxzZQo+ID4gKyMgZGVmaW5lIF9fcmVxdWlyZV9leHBsaWNpdF9p bml0aWFsaXphdGlvbgo+ID4gKyNlbmRpZgo+IAo+IFRoZSBMUEMgc2xpZGVzIG1lbnRpb24gQ2xh bmcgMTQrLCBidXQgZnJvbSBhIHF1aWNrIHRlc3QgaW4gQ29tcGlsZXIKPiBFeHBsb3JlciBhbmQg YSBgZ2l0IGxvZyAtLWdyZXBgIG9uIHRoZSBMTFZNIHJlcG9zaXRvcnkgdG8gY29uZmlybSwgaXQK PiBzZWVtcyB0aGUgYXR0cmlidXRlIHdhcyBpbnRyb2R1Y2VkIGluIENsYW5nIDIwKywgbm8/Cj4g Cj4gSWYgdGhhdCBpcyBjb3JyZWN0LCB0aGVuIGl0IGlzIG5vdCBhdmFpbGFibGUgaW4gYWxsIExM Vk0gdmVyc2lvbnMgd2UKPiBzdXBwb3J0IChMTFZNIDE3KyksIHNvIHdlIHNob3VsZCBhZGQ6Cj4g Cj4gICAgICAqIE9wdGlvbmFsOiBvbmx5IHN1cHBvcnRlZCBzaW5jZSBjbGFuZyA+PSAyMC4wCj4g Cj4gV2l0aCB0aGF0Ogo+IAo+IEFja2VkLWJ5OiBNaWd1ZWwgT2plZGEgPG9qZWRhQGtlcm5lbC5v cmc+CgpZdXAsIEkgY2FuIGNvbmZpcm0sIEkgb25seSBzZWUgaXQgd2l0aCAyMCsgdG9vLgoKLS0g CktlZXMgQ29vawoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K