From: Christoph Hellwig <hch@lst.de>
To: Daejun Park <daejun7.park@samsung.com>
Cc: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Dave Chinner <dgc@kernel.org>, Chuck Lever <cel@kernel.org>,
Jeff Layton <jlayton@kernel.org>, Dai Ngo <Dai.Ngo@oracle.com>,
Sergey Bashirov <sergeybashirov@gmail.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: (2) [PATCH] xfs: make pNFS LAYOUTCOMMIT stable the way fdatasync does
Date: Wed, 14 Oct 2026 15:01:24 +0200 [thread overview]
Message-ID: <20261014130124.GA15407@lst.de> (raw)
In-Reply-To: <20261014014056epcms2p5df940cfbe097b8cccce16080e482e422@epcms2p5>
On Wed, Oct 14, 2026 at 10:40:56AM +0900, Daejun Park wrote:
> On Tue, Oct 13, 2026 at 02:08:46PM +0200, Christoph Hellwig wrote:
> > That feels like a bit of overkill, given that the shared code is
> > just two function calls.
>
> OK, no helper then.
>
> > ... but maybe this helper should move to xfs_log.c and renamed to
> > something like xfs_log_force_inode?
>
> Makes sense now that it is used outside xfs_file.c. There already is an
> xfs_log_force_inode() in xfs_inode.c, which is the !datasync case of
> this one, so in v2 I'll move xfs_fsync_flush_log() next to it and make
> xfs_log_force_inode() a wrapper around it.
Oh, I should have thought of xfs_log_force_inode as I added it.
I think adding the datasync argument to it is probably the best idea.
prev parent reply other threads:[~2026-10-14 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 8:54 [PATCH] xfs: make pNFS LAYOUTCOMMIT stable the way fdatasync does Daejun Park via B4 Relay
2026-10-13 8:54 ` Daejun Park
2026-10-13 12:08 ` Christoph Hellwig
2026-10-14 1:40 ` Daejun Park
2026-10-14 13:01 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014130124.GA15407@lst.de \
--to=hch@lst.de \
--cc=Dai.Ngo@oracle.com \
--cc=cel@kernel.org \
--cc=cem@kernel.org \
--cc=daejun7.park@samsung.com \
--cc=dgc@kernel.org \
--cc=djwong@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sergeybashirov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.