From: Jakub Kicinski <kuba@kernel.org>
To: Nicolai Buchwitz <nb@tipi-net.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Dragos Tatulea <dtatulea@nvidia.com>,
Alexei Lazar <alazar@nvidia.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next 0/3] net: use skb_share_check() in loopback selftest hooks
Date: Wed, 14 Oct 2026 13:06:18 -0700 [thread overview]
Message-ID: <20261014130618.4c50f817@kernel.org> (raw)
In-Reply-To: <20261007-nb-net-selftest-shared-net-v1-0-458369bfa1ba@tipi-net.de>
On Wed, 07 Oct 2026 20:29:21 +0200 Nicolai Buchwitz wrote:
> The loopback selftest hooks can get a shared skb when another handler
> is bound to the device. Linearizing a non-linear frame then hits
> BUG_ON(skb_shared()) in pskb_expand_head().
>
> Stumbled over this on RPi CM4 (bcmgenet, with jumbo series applied +
> WIP selftest patches) with a packet socket open at the same time as
> running ethtool -t.
>
> stmmac and mlx5 seem to have the same pattern, xgbe already handles
> shared skbs. Patches 2 and 3 are compile tested only.
>
> As the impact is pretty limited and doesn't seem to bother anyone in
> the wild, I've chosen net-next, but kept the Fixes tags. That matches
> what Paolo suggested during the LPC track.
Wonder if we should follow up and rename skb_unshare to skb_unclone_full
or some such? The "share" in the name is quite confusing for people who
haven't been around for 10+ years..
next prev parent reply other threads:[~2026-10-14 20:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 18:29 [PATCH net-next 0/3] net: use skb_share_check() in loopback selftest hooks Nicolai Buchwitz
2026-10-07 18:29 ` [PATCH net-next 1/3] net: selftests: use skb_share_check() in the loopback receive hook Nicolai Buchwitz
2026-10-07 18:43 ` sashiko-bot
2026-10-08 21:31 ` netdev-bot+sashiko
2026-10-09 6:49 ` Nicolai Buchwitz
2026-10-15 7:46 ` Maxime Chevallier
2026-10-15 8:01 ` Nicolai Buchwitz
2026-10-09 16:59 ` Simon Horman
2026-10-07 18:29 ` [PATCH net-next 2/3] net: stmmac: " Nicolai Buchwitz
2026-10-07 18:43 ` sashiko-bot
2026-10-09 16:59 ` Simon Horman
2026-10-07 18:29 ` [PATCH net-next 3/3] net/mlx5e: use skb_share_check() in the loopback selftest hook Nicolai Buchwitz
2026-10-07 18:43 ` sashiko-bot
2026-10-08 21:31 ` netdev-bot+sashiko
2026-10-09 8:37 ` Nicolai Buchwitz
2026-10-09 17:00 ` Simon Horman
2026-10-12 19:07 ` Tariq Toukan
2026-10-14 20:06 ` Jakub Kicinski [this message]
2026-10-14 21:02 ` [PATCH net-next 0/3] net: use skb_share_check() in loopback selftest hooks Nicolai Buchwitz
2026-10-14 21:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014130618.4c50f817@kernel.org \
--to=kuba@kernel.org \
--cc=Jose.Abreu@synopsys.com \
--cc=alazar@nvidia.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mbloch@nvidia.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.