From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15FE751C077 for ; Wed, 14 Oct 2026 13:23:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791984211; cv=none; b=RkDk4zCokpRrTm8xHsLMC3e6qHO/xIUzxLX7hmRKnZjzK5Mep0ZFtegJ7KJvdIMyoQ5YILRZR5+GXqdQRhRpnjXEJ/uSDfqIQNdffkstZzl5/D4Lxu+ZIpMfGF/sjm8YU1PDpJlaIzWeOu/efXUjHgAhWkbbg0swWt7LM6KfrLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791984211; c=relaxed/simple; bh=vHlNApf1n0eU2OktVinpI4zv/MZunnjQ95s6jli1xzM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j6pj1PBL0yYzrmejpaDz+gmzWspNmmmvXjyXWVYAJ2A7keoIr5aMW6qkB2Kt14R/cTLjZxGVakoJ21TihtH6yRtmtIAjW/p1k7Xwe2K93HEDNDOmgCcHiynPtQYGpXf/W0Y90BXgLhfRU9g975jRFu5cFtwZOKkAliZ482Aig+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eSAuN/BQ; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eSAuN/BQ" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4a1635f7c89so9792415e9.2 for ; Wed, 14 Oct 2026 06:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791984206; x=1792589006; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jdTRy1oUzdTMPfJnHsa0F48c4vY6O6GHObHAbcTX0Q8=; b=eSAuN/BQJo2nCqQLjw+pMDp7TroyRIUh+tG2RNt+y5srWj/0zFtSD++KkSyhc02vvc mCKQjPKqgWZk0vdxuoncN3EZU6PNpLHRUfXKwQ9Y2DBSqiqnaw8wVgyStiEWcmOcM3NN hh08pFqprCRzonKlZ7QEuIcU8C0opY7TWJlBU1dgCTA54/A7KXRLPEQSwKIpNnTCNSi1 NFw6wNNBHkwipQdDOWbgMd0qH93Q0tjg/9drwaY6u48xOTYlB/mgfxrSuksz6KzAbwal vsANlIkHCUO5p7SdGQ3MagGK2VyzuUBNcrVpf9amwnD6OjLxaguOfGKEfmsS7yuSIYVb 8hyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791984206; x=1792589006; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jdTRy1oUzdTMPfJnHsa0F48c4vY6O6GHObHAbcTX0Q8=; b=10Yr6hzrB+9aKvupbhMbzDI5LwHTf8xYQyhd6aNcXx3jOK+hrAlnHyf+owBbRT2y1q Hj4q4ZKfXLiIOHpMNWadOrX30Z6A1UUtbcadrcTxWpoAp1z432NB/ZFsH6iGPRMs9EBX g5x//Pz6e+XAfHM74fiiHU7pu3XXX0SyyAnJ9KNgXDViEFtXtOP22/gzaNDez26Ge/gj +UMOX6xBSZ00yfoa0nTD1ouWjKK9QW9G4GqUDXzlH6TGJoMiqN2F7oCJCtHwHqVRkB7h WGF5kOyzpJTCtteeL0R9wGuQJQs3r6JSST9mODrSSMNw/s2orl2BVK7RxmwTTUv1CioG lKVg== X-Forwarded-Encrypted: i=1; AKwUvByU6+Vtleh1lq+wOF9PY0MgZIlJ+t2pDZD6u8tR5jigoJOHA/JZJZbgQ2hrFpEuyQTGKRC+A0tUojynDyqDhpnfsnnH@vger.kernel.org X-Gm-Message-State: AFq9FYI0v6seb3IE0zAXFmBEZnTKMDqzRmprSo9jFh0wJOl+KTm7Ds+A fbQTY80vSQLguSmuvJmDMLRP6v+kFGdC4Q9R9HbZXnOuSGTtznIvgDfg X-Gm-Gg: AYBFou1X8n+szuAblvF4ScvVDF8HbA5+Wd4jaJ1ZcTjWJJlNXtv9tL3pi4np4621Fmh Rqp9i83NM5tDgMks7BPoEnGfm0occaLDln8eJ2P0xPKSFy/wvAHpgk2cQqx04YnZsC/SVds5lwG q2yf8kdkJ+Orc90RYcxSMg2Cc1ei3mRFiPj4GwmJaapPy/z1Z+hq7cU0eJ727/7KwLtOuLYJNCT yqgnoEpM8epF1nuaCnsyBCMl2DT+Wa/eOieDAr4kCqzjo/K5utxZEuJn6zPE421l7g05OJDrq19 oXEAJnDGljZB8zwYYPq7Dd03wKN+prOHEjUaY/aa2x3AYh1Vg5kaRSSy8mF0mCmUQXHIIEQ9U3c RXwY+B8u6JtYzxVC7k50QpOpPa1tC8VWYzRiaDTA/gONP2F/+YQjRbxzSv/GEfrtRQNpIV0VP5s LosAt74JU206nlrbItYNqS6ZnhyS5S2Oh7hakFXUhr1K8fD9PocwdYLlO0w/x8r46mXsZi08kc1 ScAx5coKjcYSQ== X-Received: by 2002:a05:600c:5489:b0:4a0:1c94:7042 with SMTP id 5b1f17b1804b1-4a18e4a5244mr306911845e9.8.1791984206139; Wed, 14 Oct 2026 06:23:26 -0700 (PDT) Received: from localhost.localdomain ([194.154.195.114]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4a1bcf69402sm782515e9.14.2026.10.14.06.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 06:23:25 -0700 (PDT) From: Oleg Keri To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Bryan O'Donoghue , Guenter Roeck , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, Konrad Dybcio , Abel Vesa Subject: [PATCH v6 3/3] arm64: dts: qcom: glymur-lenovo-yoga-slim7x: add the embedded controller Date: Wed, 14 Oct 2026 15:23:15 +0200 Message-ID: <20261014132315.4659-4-okerixx@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261014132315.4659-1-okerixx@gmail.com> References: <20261014132315.4659-1-okerixx@gmail.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Describe the Compal embedded controller on I2C at address 0x70. It provides the board thermistors and the CPU fan speed, and drives the keyboard backlight. Its interrupt line is TLMM gpio66, falling edge, for which the file already carries a pin state. That state leaves the pin without a bias. gpio66 has no external pull and floats when the EC is not driving it, which shows up as a steady stream of spurious edges; the vendor ACPI tables describe the same pin as GpioInt(Edge, ActiveLow, Exclusive, PullUp). Enable the pull-up. Signed-off-by: Oleg Keri Reviewed-by: Konrad Dybcio Reviewed-by: Abel Vesa --- .../boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts index 769f195c99d9..bc840fd8e458 100644 --- a/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts +++ b/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts @@ -659,7 +659,15 @@ &i2c9 { status = "okay"; - /* EC @ 0x70, irq = TLMM 66 */ + embedded-controller@70 { + compatible = "lenovo,yoga-slim7x-gen11-ec"; + reg = <0x70>; + + interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>; + + pinctrl-0 = <&ec_int_n_default>; + pinctrl-names = "default"; + }; }; &lpass_vamacro { @@ -990,7 +998,7 @@ reset-n-pins { ec_int_n_default: ec-int-n-state { pins = "gpio66"; function = "gpio"; - bias-disable; + bias-pull-up; }; kybd_default: kybd-default-state { -- 2.55.0