From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A46834B1A3 for ; Thu, 15 Oct 2026 01:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028674; cv=none; b=qKZcoFCXnFPcSEecuWaMtptxuzjeqD9HbBAfe5nVOctueHj+mKuD/ZIvegSneHG5THRCDzzoTY6s4UMjmjPzqidnRVQyHlp/sJB7o4Esfdv6Ncp6DG9j+6ZBdP4hnG25r6ICZDdXjMMIN3lWxu5eQQj8sAeTYHM9Du3q2AgElL8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028674; c=relaxed/simple; bh=PxltNMQY4Mwf0miBiwGdcHoJbpALYxNGOELj9h3ky6E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rvLqNeBpg4J0tTMvOE06r/IStaKR72dz24bpX9DY6un3jb46yCiB+bvkmsdJ6QoIxViunEdIPOahwTWFnQuGPSt9Y++lO+WDw0A6Cx4h6lrUyeNAPek8AZw+MLqWc037bmjRwLY2sxCNpz65gr1d9ZpRJGXXRIy4fUuAe4mdEUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Uq5+qEYv; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Uq5+qEYv" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2e5d0ee1951so29990205ad.0 for ; Wed, 14 Oct 2026 18:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028672; x=1792633472; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0f9CDxT7c2yfniMxJX6Z2S0DK8dovzfteRrAqStY2sw=; b=Uq5+qEYvwfWDk8Q0cEn3cjiTxsuEsWqqMF9aRESUlyCRQCAi6Q/7/uFLWTIiYMguvF njikad8iNQQrnR1BcuWVAxQd5VZs2XhOM4Pm1HYwMpkwVuTc+joXuwohlTUUcxtzoLEM rSYDist9KhrbBYFV6KMimYzhslVZYbhoh/K8xWa/BlL6CKvHrIsrAaeqBw43420ysoa0 FYmbBWSKq42DbQt5zkV+m3x7XTAl8xCyDqeZiNNfjs7m3chkNsWU4zEVnRUJCq9TuAJ/ ESySVUKpXL6leSSdr8ZX1UlOWzbIejmccNVgJpHGULSFKbSokQOKycuBu+++Efd+hOvr prbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028672; x=1792633472; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0f9CDxT7c2yfniMxJX6Z2S0DK8dovzfteRrAqStY2sw=; b=ytO0P/4wztfoF/Ro/AHnod6loPBDqNyiuxt1GZU0FRjS0xIfEuOTqbQtI/63mSOS0y 8Dfyqw/ZFcFWWblkkEQxN3c3TWowkgkTCswITlBhcq5EJZLLav6C5OfHXNrdt9QIgwdV wkysl7Ehvdi7KhSNNQIgkPFIMkJ7fSgrAPmyooGfRaGBwRPWr4i4hJczJxWBwsfNnvSq CY/mLA6pMA19PLTaOIg/9nV/Umt89fKPmZ04HrYZiJuQwjYtSotBnlXlqQN/du3TcNVw +2sAmVM9cpzHl21urS+kFjnFV9YPq477lF5yMOUg7sy7qWE7hhUeJL/z5C1h7i5QTDdg PblQ== X-Forwarded-Encrypted: i=1; AKwUvBwcx2RXBoYaD9iEbcZDPuIDTGQ6j4jGHolf0gD5DScbeoVzKqYjxMiRq5MxmTuO9jWvIjZOwg==@lists.linux.dev X-Gm-Message-State: AFq9FYLsenD5lPLIEKnnzPyS8AUJpYblEWdpBddA4j07Ye4EU35ItURC nZt5e9bo48WK0Jp05RRX2j8hLlIm0SxKo4ZYAwt0VjH3VvNvuDOhxY8E X-Gm-Gg: AYBFou0nrDG5BSbYlwxv1R3fMdY0XzNNaE+MJOggryHLyDtqSxipaoQBadjUyCu7u9C r3z4DULjuULg9OhPpmABiQDksclJuEwFV5MmHvZGrW0+rFz7z8DORa91gMitqyEmaV+sCXdFdDs 2BrFwNvmzE5R9fMcAQ0FH1Wyi2o66k4kVbAApWya3LKvGSOkVFWlYZPp+UEQbOah2IxzZ5htJhn coYlkbofjELiRDIY+2jXzf0cHUt3fILcGXNg478lGsieXasBkl9+45T2t5PyRJX8ESQA+oMMlnP YH580rZLjGAL1Hg5Utks8zCZ2bYwCe/Kl0n9yaQ05HEF2sjTLt14kHpsIAbmHPxCj55DFECy519 LS3OMZKTWlSWBri785y42ORDWpAtnXnpoTp6OZ6Osjw1usU+Qyu97iE2QnSl+YW2CAQCZL3Hg0X c07FYdzPest1gPrriXkX5oUJAB3uav/T84/QI1bPLtvEkBZV4xBgWUe3TBjXBgE8ZODIVO4lQcQ ZY55RKiBtQK34hR2Q1/jj6IWE43ganHaUubIsvqMzU9ZK+suImGhVi0jE1as3NljqcJEdUTsX0o TRHgHtxJ46Z/Kw== X-Received: by 2002:a17:902:f541:b0:2dd:ad73:c938 with SMTP id d9443c01a7336-2e842abebd7mr158700385ad.25.1792028671728; Wed, 14 Oct 2026 18:44:31 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:44:31 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 01/25] ASoC: amd: acp: Fix .close() being skipped on rollback Date: Thu, 15 Oct 2026 08:43:00 +0700 Message-ID: <20261015014324.5569-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: 623621a9f9e1 ("ASoC: amd: Add common framework to support I2S on ACP SOC") Reviewed-by: Vijendar Mukunda Signed-off-by: bui duc phuc --- sound/soc/amd/acp/acp-platform.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c index 6b1e18b31c1c..f2c8853775ad 100644 --- a/sound/soc/amd/acp/acp-platform.c +++ b/sound/soc/amd/acp/acp-platform.c @@ -248,7 +248,12 @@ static int acp_dma_open(struct snd_soc_component *component, struct snd_pcm_subs list_add_tail(&stream->list, &chip->stream_list); spin_unlock_irq(&chip->acp_lock); - return ret; + /* + * ASoC only marks the component as opened when .open() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure .close() is not skipped on rollback. + */ + return 0; } static int acp_dma_hw_params(struct snd_soc_component *component, -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B9A1CC6B30 for ; Thu, 15 Oct 2026 01:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1kxWcIKigoDDnAD4XGXVbxvrzP+wuRtEma9yiIUwS1k=; b=jCwS8ju0MC2l/Z /k4rxNjBWkPk+3REpo+Ff73z78DETje9cwbOtwQqvFSV0YIOzmiALT0gaT62SiojWdPUrVKlIbCt9 +uZ1nn7sCWtu53XiK/8EONRJMqzqk4tzYUQV8C4SDKCCO95N4+b9XlKbYzU0dhoE175+ijYVaidZ3 l7eHvqqDRCXKuGpIkhgufFlgtZgEXXUuPwceCsBvp4q9bbNIHQV4+zD7+LDypAISA8KVltKVlf9SU yeMkXZeyrYGBuTeFM29FS8gWwOrwnKuuLoPZCWkxgClN/cW3O26WMVzM5QNnQHUd3Vzpcrt49uQf9 k17QiUv8//htDyvSjhUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHAWK-0000000Gb14-2XIL; Thu, 15 Oct 2026 01:44:36 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHAWG-0000000Gazr-3JBi for linux-rockchip@lists.infradead.org; Thu, 15 Oct 2026 01:44:35 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-2e946155442so9570815ad.3 for ; Wed, 14 Oct 2026 18:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028672; x=1792633472; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0f9CDxT7c2yfniMxJX6Z2S0DK8dovzfteRrAqStY2sw=; b=p1Ym0fRnPqLNrXPeepi41Kyfo+e3tCqMAqQzMO2bhFBUxcw93XUbKRa7H2itL+nJ31 MC4ILqqdFWHLV8bS5Igwmwv40HWcEZPWGl+SHLrETk+vHSWRzwNnbr0s/UOIZjqA0PH6 gnpJmCqKJeGX2wF0WjlkbUQvpn6W05IyW373/ldKZv91b/p5C0q7cLA38vuSxbvSB73E y2oAl+oHEvO6hLhx+vFXVG7Uv23jZ/aQHk/YKO93WLcS4YaaXS83jYmhzap2JyzQff2I oCgFT20Q2S6NhmdML8j4G7nCMTeohPc9AJO+Tlmvm+PqytA9O9p0Hbl59tVwBcpAWaYP 50lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028672; x=1792633472; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0f9CDxT7c2yfniMxJX6Z2S0DK8dovzfteRrAqStY2sw=; b=2qTbinjgnRSHH9eiG6CNySbtxQS/KfFVZKeOEmygt7WoBHSHgQ3G1IsyudWNLciuXA YUZ5PI5irt02IDyJKtjKhU+lo0awpykYuhkVHj+fZTb9hjV5iJNfldCFfQ+bEzGZRE5d 1mNvdNhGrwqFlThmWdLwo7ruHa8IeM7KLUsJg6SzuslemEbnCLGEMQ8VOja0+eSu5kQk 5hr5mEkI/T42K3HXZtEV1dxj+z8OJf19R2CirKNJYJAbQyAW4/fl6Pgg/Fc11ytVLSQp EYMNSEaS+MkBnAlTqOhGCSxVqfAbFy4qhQN7+BEWLlqTBsux1lOubp4cIGwFjPExw/ja /9QA== X-Forwarded-Encrypted: i=1; AKwUvBymsCVKfaZgEieUzeNxBLjO42nx3zbOLUA7px0o57Um7ul/U/D/2mdmJX1jpB9tGgCb0ZgNTtrPFqa2BjAJuw==@lists.infradead.org X-Gm-Message-State: AFq9FYLg8wWy7MK9HUhvnxqV9mYgX4jGdL4WQwOy5UquFSKeyJztH8ba h9/ftpWMcaVPHuKr7oPwEY28BWJPUarwBYsgkUKi9PsNF4ESrCSUZX0R X-Gm-Gg: AYBFou3dsXfPqLo8f5TLBSeeLZQR8041UNw+QnmyGsy5DUjMbGCJUW803CTmeGLUZDh Qwbp7vUL9WMyZ3dHj+fIRju5ohZNKNPu7xAJnNP6PEc3q0AL81Nxr7gBt8D/EF0R82C9VdpAyeG Jiz+aqF/2mUZhkwR6Oow61iOQf8hzwZasIzeWJwHbrJFJGoGfAQQZINY92yvJKXhmhA0/wAWBhn t4v/38syIuCarQrclIqrRZzv4omLRVW7VLTzg6MhZgJY2BULYZJCWpmEddTLeGhOc3KcoppAZ1o 16hLU0/5EuQpK74vUEIcEHrjOG/7dOse7BZH+VOQaSVrz08O8poa/nFMqngEPvfP3iDXgMRtWZ7 428v98NT599JCxP0oly6Tpuwr9+3fwXGySE1F4DUu8v7JfS2DP6aBzKcmjMK7Hu2ooT62AOTS2b EmIFioZ4hWE4RB6cVPT6NozWLSbNZDlVBYa9jwjuyI8xggbdIwVhrqgt8RZ68xzIR+3y/4shNXy 6EXU/5F8/F2uEMDDDFAL1IKhcdh7k2i9uCkf6qMaQ1xr9Fz2GE4T9QI0F7rFhmOg3hS0wIgvoHI KOzutJ3wxotraA== X-Received: by 2002:a17:902:f541:b0:2dd:ad73:c938 with SMTP id d9443c01a7336-2e842abebd7mr158700385ad.25.1792028671728; Wed, 14 Oct 2026 18:44:31 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:44:31 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Subject: [PATCH v2 01/25] ASoC: amd: acp: Fix .close() being skipped on rollback Date: Thu, 15 Oct 2026 08:43:00 +0700 Message-ID: <20261015014324.5569-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261014_184432_857887_7876347E X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, wangdicheng , Kees Cook , Sang-Heon Jeon , Pengpeng Hou , Bo Shen , Neo Chang , linux-rockchip@lists.infradead.org, bui duc phuc , Chris Bainbridge , Charles Keepax , linux-sound@vger.kernel.org, u.kleine-koenig@baylibre.com, Zain Aboobacker , Bjorn Helgaas , Md Shofiqul Islam , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , patches@opensource.cirrus.com, Linus Walleij , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , asahi@lists.linux.dev, Hemanth Selam , linuxppc-dev@lists.ozlabs.org, Syed Saba Kareem Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: 623621a9f9e1 ("ASoC: amd: Add common framework to support I2S on ACP SOC") Reviewed-by: Vijendar Mukunda Signed-off-by: bui duc phuc --- sound/soc/amd/acp/acp-platform.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c index 6b1e18b31c1c..f2c8853775ad 100644 --- a/sound/soc/amd/acp/acp-platform.c +++ b/sound/soc/amd/acp/acp-platform.c @@ -248,7 +248,12 @@ static int acp_dma_open(struct snd_soc_component *component, struct snd_pcm_subs list_add_tail(&stream->list, &chip->stream_list); spin_unlock_irq(&chip->acp_lock); - return ret; + /* + * ASoC only marks the component as opened when .open() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure .close() is not skipped on rollback. + */ + return 0; } static int acp_dma_hw_params(struct snd_soc_component *component, -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip