From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61581364E84 for ; Thu, 15 Oct 2026 01:49:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028982; cv=none; b=tNNHTgKHtwZe0McTwKmu4Fq6wosBzBFj4aCWXQe6j1OkuBx43ahFlhcMQNFC3KqSsD76BZt2nYnkAKj1y4y0IY5wEHtau9RGS/HGsugHlsDUaoJSVXV+oI7ViVCg+mt/uXxXRKdXZO2Km+uvK46sarZFMaCvWWhMqwA/aAjOJjg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028982; c=relaxed/simple; bh=jlEb+ienncM3LL+BnYDTqkV/y1oGhTtwElRku4Cmr6c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O9JlZpr/g7XVthCpM85m83QTI8FAepzKJG0w8xEgFjrfjjNSByo4H+UI/uMWKG5IzHjCq6IBN84Txc3vd52bb/DEU9YQEVJhFmgX4VC11K68udf76B+x3UybiFumkSN1Vd1UuoXOh1aW+E24RIBOaCWiXIUDlMir3wVDo58RVbs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V4+BOBkC; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V4+BOBkC" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2e7006bbf77so10086725ad.0 for ; Wed, 14 Oct 2026 18:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028978; x=1792633778; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FVU2me1+3bnamRCjCl3aeaOsDD74U7zM2YYw6HaRgfo=; b=V4+BOBkCcVFDOF1oErC3PeurvYWSyTu6yuYe9GubVrhefUyUQMFa1XYlu0vwZvcsha DRTcoyiw2GXHmwfcdbRotSfR0/2ejJ85tomLYYCFeHIPFurFSlwt5d1Onp/oZX/JhHDw PGZsyhQgMIqN1Qwwhapl9SPj0Ym6unO9BMFdwDAGBw80vJ5X3McHjsn4zYBN7ehNQOlo g5TS9xLFTup3+d6PoQ7pzDAXV8Kdn4vZZc9p9sYfqCPIUzwEZJVD5eIPIh2avw6X4x+l /Nzs4BxenfyQa3BW8bLn/qpDLMMjm297eFfQqA/PHZC6De+/7aoIKk+Ahu5yi6oGtfi2 B2Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028978; x=1792633778; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=FVU2me1+3bnamRCjCl3aeaOsDD74U7zM2YYw6HaRgfo=; b=p87xTIBFffgEpMjcxrDkApqMqAx2JVCLt/zBEIm4j+au5qMCH1CubYAMqYIIPZZUDz x4fQWGYjXOzP1tBt/e1OH4dNFubYiewHojYnMzuoPfXPoFqbS/LYQgc+08o0R9upEYmo VrW5/tlCMob5N7ZzSft/ERAWx++gGC70YIgWTaK6VAW5q1RzGs2yhTcqIYZCH7EdFm19 0xY/nQJ5V0B73EmIxd36HgjYTjbGoaQvZkg5Xw5a+SPaVn24qGpG/Wsnd/aYkeM8P5uG Pbmgg/+WlRkG2noWuoNXpZtoMNZulY0z/s+cprd5m5kFO38GtgifgYPJohnkZ150jfIE qRQQ== X-Forwarded-Encrypted: i=1; AKwUvBwMgy3ZpZ4x5FmTg0HAwDAuZryySo+W1XCOFXszL2dTdqUbK84ZGnw+OCLMBphX7U5y5UGJfCLj8Z5YmA==@vger.kernel.org X-Gm-Message-State: AFq9FYI9vuBg7q2Md+jW1vGMuKLlgxOBTiWeHMwzieQiBlBl5wOlPYKQ STPJJljlWsnKkJquKteTQir5hlz1SN60UfvqsYKyI25L0XGDC9HfwmvI8c5SIw== X-Gm-Gg: AYBFou3OJOnsz5zNuQemv3eQvKVSlZnLjDvt197aqjrTECWym0nSoAtvRmQz8JhPuNH 8eX/7sp2MFyFzTwfG8m9bvGujhAgVEZQgwm2gybLZlRF6F2K9rGjJf83mpgAYphP+cCCzUELcGV PmOWxgIKvDCu5vSvskXQtYYSVhL26HiWyJ5qQDJjAnnPQ+BeGPa4Snsjo04kfNYq6qLU7KfirTZ LqK+ObRSEd6dcHGhz1lag844fzYSyyJ2MgSjJItdrE3xKq3fZbZYYNglgAZGf8DzFy1FYmvCpwB HQpRwgUPCaRLOCBnuBJIftfn/iG93gB9+N8KcooWc1AWJlMHMypoQs6JprYrPQZpVRauOa3omwG V+hGWq3ZOPQAd4kjJMTxBDPdyl1qvZfuiLz5YzP1IKvL/ThbBPf4M27gNlaV1Rt+xSayFPVXQIz IOCRYKM1iMeJuWlhHFWW/Ic5y4DuZgK9es+MMhcUsjI3+b0KUI0BSx6G5IwsJKz2jPTUY15KBLv znwx9s0xqxf4kgcG4oDkqRvzmySMEGQq/2B2iCn1mPfc69fbQ2NQ2w+zWmPgx9xTJgAwZmRebGy cJspfxgmNq+4Cg== X-Received: by 2002:a17:903:3243:b0:2dd:ad74:ac32 with SMTP id d9443c01a7336-2e842bc61a1mr152460415ad.27.1792028978441; Wed, 14 Oct 2026 18:49:38 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:49:37 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 20/25] ASoC: renesas: fsi: Ensure the component is marked as opened on success Date: Thu, 15 Oct 2026 08:43:19 +0700 Message-ID: <20261015014324.5569-21-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from fsi_pcm_open(). ASoC only marks the component as opened when .open() returns 0. This currently has no functional impact, as fsi_soc_component has no .close() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the component is correctly marked as opened. Signed-off-by: bui duc phuc --- sound/soc/renesas/fsi.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/sound/soc/renesas/fsi.c b/sound/soc/renesas/fsi.c index 23b7e63596d3..74e2ea002fbb 100644 --- a/sound/soc/renesas/fsi.c +++ b/sound/soc/renesas/fsi.c @@ -1811,14 +1811,21 @@ static int fsi_pcm_open(struct snd_soc_component *component, struct snd_pcm_substream *substream) { struct snd_pcm_runtime *runtime = substream->runtime; - int ret = 0; + int ret; snd_soc_set_runtime_hwparams(substream, &fsi_pcm_hardware); ret = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS); + if (ret < 0) + return ret; - return ret; + /* + * ASoC only marks the component as opened when .open() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure the component is correctly marked as opened. + */ + return 0; } static snd_pcm_uframes_t fsi_pointer(struct snd_soc_component *component, -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC5B4CC6B30 for ; Thu, 15 Oct 2026 01:49:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+aK5qSRGo/MwuSQUyJB9saQX8kO5Tr7wjHzkS5dAlT0=; b=cjmjE6QWsmLi+k yh9fcVG3ZZVWan9J/xxBFroNNqtUUeYYInO7mjwJxnCRhJA5sMEMAB0Zoe363M8Z3m/9FKw6VRvn+ ZyPDyIndG9U15OOhHNeUrGF6EFoBW9GWg5xfxYkT3ASmqIB1crP5Rj2RIIE+vYYvM95krsTqoABSW OXHxHwodqRiShyGkxOVEN7WxQ0btHBN6BDZ0amYPdnriE+Ss8PYIYVTwSzdtHooLv0Lg0XQ3kAY5S noyBjesYhkAMu6+M4cAXaKqQKvu4v8uCrXqtL9w7JpVf7S6putnZT0xx+ttBHNXoal/MwqIewYsip 2qApphJ+AQaRS1Gnzsog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHAbF-0000000GcSS-2ptv; Thu, 15 Oct 2026 01:49:41 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHAbD-0000000GcRN-15PZ for linux-rockchip@lists.infradead.org; Thu, 15 Oct 2026 01:49:40 +0000 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-2e7006bbf77so10086735ad.0 for ; Wed, 14 Oct 2026 18:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028978; x=1792633778; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FVU2me1+3bnamRCjCl3aeaOsDD74U7zM2YYw6HaRgfo=; b=eIXCdJUqQ5+vwR+1jCz5oiy8vvN3/jIYTiWS6xrid9iYiMvGNOvFZYacxE2pzk9Fx/ ddJsiBbqBBLKPZQFHVQj2s0CYXfSYrkHp+TJbjRP+cr+4OUR6bRKGmYBC5LffKMqtXF8 k2RtD1ApQBwb2vkeyjWYC3p+uDIELPASUK0qQeRRDcY66zAVbJVjRsgYvbFDnI4v+f6/ clNfY/gNBNPVACPuUEyY79TQiThK9uMSt/3/27CIOajLTCPb9Vi5DVqdiL0EYErPtl4Z mPNf02pzot/4qbYRpbPjQAblkgWpJsTK2NSZrIxHo7qmT/3d9iZjAHuNTBaHVdXEJ1WD ieTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028978; x=1792633778; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=FVU2me1+3bnamRCjCl3aeaOsDD74U7zM2YYw6HaRgfo=; b=aa4kn6y1NzmJ+8ZHL1JVnruudD4sfgQUMXU6gc9INGgEKiAkpSq5mrlfDfGZg+AJix AoQEegc+Z2s3MALkq6IGkV50aHI2lWil3gcyOrYTA9T85F0092xT9ehUGMe41y3Jeld2 Khf0h2PZOvpiu4Ha7igDFI7Mupl9zogx3JGKwbRHCEXa5BlTtD5wd3ibWyCtePQ7IaX8 wDQd9QtdYgKDpfqM425miLMGHK4AVwTJNbhv4tUTfjosOBd8eLKSjPym3md8wxw9z50B epe/ffJc2iIltf+bjBDd0/O1IruGVQ8hzRiIRwKUqEUnmJsZULXoVmmPVyAsam1H95Y5 6EBQ== X-Forwarded-Encrypted: i=1; AKwUvByckjFqIT/WSG1T0EMAza5D65354lKzl2ja5RnntljkPhUYpGIYvucq56d/llCpJCl/gZBvxXpxv07PFRF1jw==@lists.infradead.org X-Gm-Message-State: AFq9FYLyxWV8BTGNmD8g9+wRF36v+JheuFd25B0rLW/dxH9q/H3njIaI nfzWupKKsevPjG95w1v0+R1xGAFEfIpGrGhC97ko5iEocZW/N9X6eKi+ X-Gm-Gg: AYBFou3oYa1wvNNItjnIZH9nL/DlcfovMj5Q4BrVHJ+5I0RqgVtg8eQGHek+1lgIgpa MTCpY/axBo9CRhabyAdK+HrNEuOT9+byzGNNZHgGuNrTwYNMars1iwqhXKUaxG4SxHFckKV1T6m bFnkJiuzmLAb5jj3GaeQcS917DLQeGav+ZRojOzJYT6dqOjbHKwfUZEDqeS18euI3ZynJV4sfzH VQmdS3SiyHjo59gsLcUiT4T3ToOpfdKg8CPVEFyRryOGR3J75SpT0FD/PAAK2gzmonv5XIsNIuc lKubFt+GKr4zYTAO966dbs0RxX0JTOrh/m8hTSZvi3MisfVO97y8qHicFC8uMjZ+LD8aMdwdAwz 9I8RwuOB4N0pKH5wfY/VhYPl+eGvoIR8XO6h4OduLKMGJKuJtfyHztZ7V5bHvzois0TVX2SOFf2 pOwrczpabZbFZ9qQbXtsFaeT5oreD5GkP0F8NZvStkhYnK4/ovu9FjEljQP5ILRQZAXbi7COQyC Lwi+0bpInrWBNka2ewZjr+ZAY42oo0KppfFNe/WUVwRrldB/YBbiFs6i75LrIy4U1VNhTXChY2w DQ5sk3mksvZ60w== X-Received: by 2002:a17:903:3243:b0:2dd:ad74:ac32 with SMTP id d9443c01a7336-2e842bc61a1mr152460415ad.27.1792028978441; Wed, 14 Oct 2026 18:49:38 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:49:37 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Subject: [PATCH v2 20/25] ASoC: renesas: fsi: Ensure the component is marked as opened on success Date: Thu, 15 Oct 2026 08:43:19 +0700 Message-ID: <20261015014324.5569-21-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261014_184939_306092_F2A9FD76 X-CRM114-Status: GOOD ( 13.88 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, wangdicheng , Kees Cook , Sang-Heon Jeon , Pengpeng Hou , Bo Shen , Neo Chang , linux-rockchip@lists.infradead.org, bui duc phuc , Chris Bainbridge , Charles Keepax , linux-sound@vger.kernel.org, u.kleine-koenig@baylibre.com, Zain Aboobacker , Bjorn Helgaas , Md Shofiqul Islam , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , patches@opensource.cirrus.com, Linus Walleij , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , asahi@lists.linux.dev, Hemanth Selam , linuxppc-dev@lists.ozlabs.org, Syed Saba Kareem Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from fsi_pcm_open(). ASoC only marks the component as opened when .open() returns 0. This currently has no functional impact, as fsi_soc_component has no .close() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the component is correctly marked as opened. Signed-off-by: bui duc phuc --- sound/soc/renesas/fsi.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/sound/soc/renesas/fsi.c b/sound/soc/renesas/fsi.c index 23b7e63596d3..74e2ea002fbb 100644 --- a/sound/soc/renesas/fsi.c +++ b/sound/soc/renesas/fsi.c @@ -1811,14 +1811,21 @@ static int fsi_pcm_open(struct snd_soc_component *component, struct snd_pcm_substream *substream) { struct snd_pcm_runtime *runtime = substream->runtime; - int ret = 0; + int ret; snd_soc_set_runtime_hwparams(substream, &fsi_pcm_hardware); ret = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS); + if (ret < 0) + return ret; - return ret; + /* + * ASoC only marks the component as opened when .open() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure the component is correctly marked as opened. + */ + return 0; } static snd_pcm_uframes_t fsi_pointer(struct snd_soc_component *component, -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip