From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15D2A31E82B for ; Thu, 15 Oct 2026 01:49:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028995; cv=none; b=kITnNsv6DuIuy7tsCdiZnjrUBOdw8MADiZzWbH7OFd0x9bLYis42jkfOVi0BNLpQnvieWUBspWKcnUwXj5PFmNBuuU53+H9B1dFkruQNtL1+jNK1pdCvFv7qUNOMMoON4Viyje8DYEfEeOCgYMUzh3faRpgS0PoypOk3VWf82W0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028995; c=relaxed/simple; bh=AsRVQlxF+563JjvP+sFHOx3JXC5esmyVVxsSsw++eA0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jhZf5jaOOyONNMjIu0jUN1DMzuyhDWehf62jQr7h6N0ahGbO/CgeuIpL6YUjGkNzOWAO6RV63sN6DBiRMF04Eh1catxDRo2a7jST9Yfs0cWmyzAJzFlWqDuNjtnwe0PHvwkhGPmp1qwGdZi1hQAPq0x8Zo7NNr372+tyLb0so5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DkryIyzC; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DkryIyzC" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2e5378b281aso26430765ad.2 for ; Wed, 14 Oct 2026 18:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028993; x=1792633793; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=X8N5wvVyB4OZfrBnjP1FYFZJGH9J4CpZz0KjhM2upoM=; b=DkryIyzC+tv082WDmMQVrsewKeXzE+KPZ/8Rtaq55xHkoolmBLF6D8VQkhpDkg0yaX 9urOZ0d86+xDQyQF/bsvafRWucB57vuCF+QHRewLl4IP8cLnLRERa+kOXa9DSDQ08K/g 0CpIVlIGoGgbAx+ewQGE+reu+FSmknkzmwtzyzB7IfbRDhNg+7krNbddFWa/xyuGONXO E6LmGZrVUH4+BF9TSKjblghioSp0R0qxut2ay0ZEZJxf6rnYmLBlCMBkemVrgyxLeKZc vNQQPYkuuwhBZKo/kOP5Vlr+qV95A/Sku2JGzWTN720DL0We0k8+JiIvEkWbgg++3lkw uHZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028993; x=1792633793; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=X8N5wvVyB4OZfrBnjP1FYFZJGH9J4CpZz0KjhM2upoM=; b=NGZMX5Y+nEeQ93hzVX0JGd0MP8aG/zoz65q7a4+aqDEM51tGX1BfE1IOeC98Uktqsg bqwq0DDB7k5zKvKLq0edNHCEfa8jThrQl3m7cpTBOgp7kQy3l6z2u7GxBNU83ke0SVSR X9T7wkiZwwbKIYAKHl3gX8MlMcb0XTr3dFDPYcAuuz0ZKxC/oVGUbrh2ZBkc4i0N/mgY VpFRmogdOqBYNpv/usIDxYdVrijk78iPY2N9oj1+DJ2RV7dkl9Pb9PYLgBKiVGtSewHP WhP1m15W7A6k6g0OkEC5ZIFx3g6FuofpGLcaa/s+Y63WOOUNTZoIJwEhzpE61c4mVXV4 BnYA== X-Forwarded-Encrypted: i=1; AKwUvBwA3RCRsQz8h2/lw3URc7YtUzFNMGtSglvQqyM78GTXTkza7oU/+yThxwvdz6TKM0wRbgzCqdiObObY6w==@vger.kernel.org X-Gm-Message-State: AFq9FYIhOJm0F0FFHIAVop8fwuKWb4G75duesx6eNZ847IUEPrQZxqjl pthCALSI0h8NiQ4+zqTgUfAC9BAuIx0wvnfn/Jz7+ZztDomSZuCEWI3z X-Gm-Gg: AYBFou0kRf3Qnz2FXHk8MGWozZNgzSC/ihAwmDa0D3Ssj8Z751J7lqgy6bKbsnhfLuN CAuAihjguT4ANSlNIzLSd2byf2DIMyNO3ITq03Mg/X/ii9T/F+S8RM9o0bVzQH20r1q96XR016W ucA9QTkoi+0AQAI091YQScl9K3OcaQfIi+dWXMd4rCQOXGPW1sv8N2old7HJqQR7g6hWotkbzps WOldK1xgneoBOwISfAFxbrJ3TXt1TrgRfRjgxl7HV/5A3fYF881yuSXIkwNaB6PxellysyGe4/i Ag4kl5Ac6+NO+FGbONqJajBd7wxGT9jq3WIp0xOu1fk0snkZX5ZiRtmsG3FsAScBdTrMuT9WD5j YFRXz+aettoXXAQ6/BYSt0aFZfOd/Owj+XhGmTebWst22CSTaBQhL++ynkyh7CQypEj6D2/swE0 Tqb0of9hqEr1Hm9DJDO5izL98gDcDbrZ3YZJ7AIzYBi25VSV8In7VEkXack98vc4iWaetRaxlpG QxS6Wd/wCbnTnFcn8tJIVLu7oBBgMvtRrxinuC8OFA1r/SOw9HF7JiHpHaG4itloylz9Co+FX0w s3uDD0ifDIACFQ== X-Received: by 2002:a17:902:ef4f:b0:2e5:c563:c0dc with SMTP id d9443c01a7336-2e842cdb0f8mr158108285ad.42.1792028993312; Wed, 14 Oct 2026 18:49:53 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.49.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:49:52 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 21/25] ASoC: renesas: msiof: Remove redundant period constraint Date: Thu, 15 Oct 2026 08:43:20 +0700 Message-ID: <20261015014324.5569-22-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() is already called by snd_dmaengine_pcm_open(). Calling it again in msiof_open() is unnecessary, as the constraint is already applied and the second call returns 0. Remove the redundant constraint call. Signed-off-by: bui duc phuc --- Changes in v2: - Remove redundant integer constraints already applied by snd_dmaengine_pcm_open(). sound/soc/renesas/rcar/msiof.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/soc/renesas/rcar/msiof.c b/sound/soc/renesas/rcar/msiof.c index 128543fc4fc9..11a6f22ec0ad 100644 --- a/sound/soc/renesas/rcar/msiof.c +++ b/sound/soc/renesas/rcar/msiof.c @@ -419,18 +419,14 @@ static int msiof_open(struct snd_soc_component *component, return PTR_ERR(chan); ret = snd_dmaengine_pcm_open(substream, chan); - if (ret < 0) - goto open_err_dma; - - snd_soc_set_runtime_hwparams(substream, &msiof_pcm_hardware); - - ret = snd_pcm_hw_constraint_integer(substream->runtime, SNDRV_PCM_HW_PARAM_PERIODS); - -open_err_dma: - if (ret < 0) + if (ret < 0) { dma_release_channel(chan); + return ret; + } - return ret; + snd_soc_set_runtime_hwparams(substream, &msiof_pcm_hardware); + + return 0; } static int msiof_close(struct snd_soc_component *component, -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F381CC6B2D for ; Thu, 15 Oct 2026 01:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zWvAZ5T34zEEWXC/eTPzR6cCUEEDoeBV89U4jJlW5W8=; b=YZDtcDXkchpn8r z4jQ3pGbYBk6HC2wPVZ0/AnQh79ABOABiO4D/6w5kGftDFejrll0aZdNF7WSbTRPTJAjjm0PPEofd Tn6zG/DJP0p7RvcqKco9/G/C/JbFq0aBTCqhU+qUnVSHv9pvCHhOi5YmTRy2eQh9QtF85Wxk825Hx FFZ1WuKC/saM25L1aJkHqBJfwzGBl74ntctlov3X5zrQjFHh5VCKiIJv9uGhqn/buEXfbnRVUU6pQ /uYznXVHyDgdCHuHAAdA/6PEVpAsd+i6/0XqPrtw5cNIE9ECadWZih087xU95Ev3Vj7cPt4Dj9Kti maaQZiAqgL9EsOTOrgkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHAbU-0000000GcXQ-0rri; Thu, 15 Oct 2026 01:49:56 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHAbS-0000000GcWW-0Qqq for linux-rockchip@lists.infradead.org; Thu, 15 Oct 2026 01:49:55 +0000 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-2e5378b281aso26430755ad.2 for ; Wed, 14 Oct 2026 18:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028993; x=1792633793; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=X8N5wvVyB4OZfrBnjP1FYFZJGH9J4CpZz0KjhM2upoM=; b=gMgT86iLmc5xSkNBB70JuMvB4i09s2RID2CLUg4J6lbif0b5Wjui7MPnvdpMg63QAe SH6yQ/kP39Jz6u2tbge4BdSA/XEaW4pfnyENOOr8CkJJ9itGw6yXkKarICrlJITD1nK/ b+3ThhauyI3qMeDDT39CwA6p0rMJfypzD6rY1nyDgSwGN3/SaxqXcDia/9UfUj/RMWZH +1DwmSwUlmqFvJLWeaf1YaLnTLOaHei4lD97DoSW5Cfbeod6DJU3wsX2Ln1uQz2H2VtF DVM9DFcuV4XjEyhCZwjLJN+bYp20U/CabUuJm63o91xbWQSYhOLXCMEMEdBwMJ1uwBCm fL6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028993; x=1792633793; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=X8N5wvVyB4OZfrBnjP1FYFZJGH9J4CpZz0KjhM2upoM=; b=tHBzh8jOp1EZ3V3zwF2aDFU++da8+NFluCp9KJMHJQXKBcpBNvWHhYEN+olBhkDHBB X2UL0x3e5RhJJ+a8KWiPRQ5ImvLMrDM2C5Hf/F0I3BlHGDVuWZP8gA5m+oKPLfvurG2Y xr65XG8tPutSnH0GGJKj74icX2t40auGYcTMb6f8XGlWGUC2ZE6etsv9XpYVrjcJAtx/ ZxV/Z31OS2Qbg8/D2EWgHm0Q8NsjK4nIKsRJNxPt2dTUkdurd/LO4MAziuM1nNQdfSXx YOafsRjDERfdUpiA0t/ArFuuslDi5q8ncMx1Qtj/MXCsQipAVCix0ITUq+PZ9+Ljz9Q1 Fh6g== X-Forwarded-Encrypted: i=1; AKwUvBxrlgeFT6syZ8u+tImY7Ub4GXmSJujA78hTPrLmpROdiUS007aAXNkRo8NC9cBxMkv/tkfPbvmzHlVlcTV7nw==@lists.infradead.org X-Gm-Message-State: AFq9FYKrBUrtq1iNMGKxznOs7mthMxsW6Y0vXoOE4JT9HC1dOWnmSlen VRRMts2pJcCWU6GkZEL8gaq8iDQVQqIbrl6NMWcKWu9qUfZ6q6vND6eL X-Gm-Gg: AYBFou1zRvreA0uBPqhE1baIZLAzKVsFekKY7OJaUrmkW8PctYWAhaTSWwLY1O5CF2l mqiRgV2jCWNq9Wp7z8n3KcfiRaDw6jt1e33YoWTklONGupQqSXGtOav7G6qM3NnMRSoJ5gD8aUJ 3RfqyvsNbWqW2hJR23edk/1y1U39//F+VoQo6nQVBxnaQHGWsdcTzM+C5D5cw0WdjsDd47ZrSxg YmBaUxUUdGclucZVEgtDOzEOGcsRs0qBuxhzFnHcj2EWETTrDAfcix7rY/L4/LZieCdhEgWSOnh x74y+OBytQrRALlR4TeAZQMZSHUl+mOYatZHdsvt/VtIsN7SfGya5tugJJPXFY+93kzd8JzoZKK RCQMv5NeHH641RaEeyCH/jhQ0SbvgSiZUQnkvQD3uHIceSc7XdKyaAJH0+6VauivJ9TKQiZEgbw WXdIk8yKDAFKFiHyO1fTe5722/Egy+I0q8GBo6AvXtGDhgrgfQhMcqR9rLPkOtbtX/mfTZK/8St 3M4NbrhYPcBSBXdkkOuFEPSFuZwFnckU0WmSJ0iep8lAXc2sQC+P9lWCLp3PsnH0YLZhwyHoNch ZJhH+STmVjVHlA== X-Received: by 2002:a17:902:ef4f:b0:2e5:c563:c0dc with SMTP id d9443c01a7336-2e842cdb0f8mr158108285ad.42.1792028993312; Wed, 14 Oct 2026 18:49:53 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.49.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:49:52 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Subject: [PATCH v2 21/25] ASoC: renesas: msiof: Remove redundant period constraint Date: Thu, 15 Oct 2026 08:43:20 +0700 Message-ID: <20261015014324.5569-22-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261014_184954_177862_CCE4C5F0 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, wangdicheng , Kees Cook , Sang-Heon Jeon , Pengpeng Hou , Bo Shen , Neo Chang , linux-rockchip@lists.infradead.org, bui duc phuc , Chris Bainbridge , Charles Keepax , linux-sound@vger.kernel.org, u.kleine-koenig@baylibre.com, Zain Aboobacker , Bjorn Helgaas , Md Shofiqul Islam , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , patches@opensource.cirrus.com, Linus Walleij , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , asahi@lists.linux.dev, Hemanth Selam , linuxppc-dev@lists.ozlabs.org, Syed Saba Kareem Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: bui duc phuc snd_pcm_hw_constraint_integer() is already called by snd_dmaengine_pcm_open(). Calling it again in msiof_open() is unnecessary, as the constraint is already applied and the second call returns 0. Remove the redundant constraint call. Signed-off-by: bui duc phuc --- Changes in v2: - Remove redundant integer constraints already applied by snd_dmaengine_pcm_open(). sound/soc/renesas/rcar/msiof.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/soc/renesas/rcar/msiof.c b/sound/soc/renesas/rcar/msiof.c index 128543fc4fc9..11a6f22ec0ad 100644 --- a/sound/soc/renesas/rcar/msiof.c +++ b/sound/soc/renesas/rcar/msiof.c @@ -419,18 +419,14 @@ static int msiof_open(struct snd_soc_component *component, return PTR_ERR(chan); ret = snd_dmaengine_pcm_open(substream, chan); - if (ret < 0) - goto open_err_dma; - - snd_soc_set_runtime_hwparams(substream, &msiof_pcm_hardware); - - ret = snd_pcm_hw_constraint_integer(substream->runtime, SNDRV_PCM_HW_PARAM_PERIODS); - -open_err_dma: - if (ret < 0) + if (ret < 0) { dma_release_channel(chan); + return ret; + } - return ret; + snd_soc_set_runtime_hwparams(substream, &msiof_pcm_hardware); + + return 0; } static int msiof_close(struct snd_soc_component *component, -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip