From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CD8C26C385 for ; Thu, 15 Oct 2026 01:44:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028692; cv=none; b=Yc3Br7ylxLc16l5tFAQpeq5Z1Bzv9kdqpvNcRckmfFYfP+Om/wdoYT7Dw/WKqUaib4JJpacci90mTI0sWguxEn7Hpu427ZuZyNHAYuo2CLtkWXoCk9+3xFyo/yhB5y31o+zwRDVYUZ3XERIlAnYJbSMmX+R+Z1rYZT/frd1Tvdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028692; c=relaxed/simple; bh=Km52EVNDvQaSKwDMYVVG/cG2sOqJGio6RIBlU/DT6nc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tTQkLBsbDP4mPV19jRmWcfV2jdZJKo2QXb1VgBdzpMQs11MDSu5YC9V8iTedfVwOtWdXV/GCtJIlpOXwEk2azP98WQZ0WcfeP9jOJSGP224Cqwmgum6lfmkfmOWwfd3HROWAgrMfnzFIGR+YTVhCmPl/lzkQLsdqwdDaFlqSgvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fg1NLXca; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fg1NLXca" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2e7e742a2c7so32161825ad.0 for ; Wed, 14 Oct 2026 18:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028690; x=1792633490; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YmTMAPFx5up6qhPC8f6eIWZ+fqRc0pF4DtGB7TtfWew=; b=Fg1NLXca0VxVEBzRgyhLVWlNQgTIaJWJfzSiJoYSzmdYLo/7kgJKOGhw4gPgJ1RaRl 86lzomUwX9fOhSyGw5Q/qlP0YMfKt/USHT5WRByY3+KNNG1G/EAZI6Zzy+OJ+/hjBw6h 75HRlPuuDfcuJnMg6Tl2HK5xw8/vHygeIaQMMpcS7T/Qrz57bL/H3Xgl+NvCFjGhRxU1 9BuIJ/oVZWcQwkzJqpMJWigXDL00Qq/LMh/Y924+/vs/FK66IH57pyRtKcWElOCA/PSP RlMM+KZTtNXfGtTWfQaB3YEIGGbuh8i/eBNXuyInnlKsIgGKuEPj7/ZVkXhO+wJGs26b hvOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028690; x=1792633490; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=YmTMAPFx5up6qhPC8f6eIWZ+fqRc0pF4DtGB7TtfWew=; b=Zs7GB9vawzvbsgkTu+NaQl7lb+ew7gFo2JP0w5cwK7JItK6WnFcVuBzivNNMQ6LodQ fMoluTLqjPdscQlbmjbNger1MQRPQ66R/jDG6DQcIuyJkrZNPID26HXJ9reB36vY0rfJ ZPwkOsIAtVLWSZO8YM+SYVv2LBs5l06Auv3A2+FhvqyCv5/ZuQ/o6IdAe6v/MEJ2ls+J dMR4AWyKSw7QvINn3JaMKdTY9sCvKr/9rT4wXMYK5aCjvWSuVHtD5fVc8I38WNFmYaB2 nMBpFUJW5n39gFron1NobU4Qy7LLrfhSVFeU/cZdDTsGUChttGUNmSlKjlIl+eGUmFTK oJPw== X-Forwarded-Encrypted: i=1; AKwUvByB3kbprR1UZp2zg123f8C+fV4hIqDMhWH++Hdgb+nf9vF0OlR55e+NfAiQPdNt8c7iHD8=@lists.linux.dev X-Gm-Message-State: AFq9FYIuA+VUpBj0QzO5zBNB8XxjORFAqF5r26nOpaqSLiCnf+jN2jdI Z4dwCwT0Jtk4P3KLC7hUsj/YHZQ9Knvgbut01dwt+N3hxmNLGFWXLWn+ X-Gm-Gg: AYBFou1vti89TvN4+sYXAlUHM7HFeSbBHmCw+bCa/5ygF7s+QcOWgfWeIdfgP4U7W6a SOltngWHXn4OgZ2ceIfO8iNWLrMoDUuu9PTM1cnNWG7XrbGCSUeZniMMPAbLJgIsfDCcFghAnQR TCRueCa5ZiQyLhC539VwR9L6zKws3XDSxuH/Pe4wbK1QXFWRBfciT3R4jxs2BYYaa6GrQS+Tzgf hkJybak4XVUhs01XT5DibCRtzbEIlEjbsI8O1Br/KITgV5M/0XMkfpvFpYcnV94rOW7jTOutddG tubma46ziQyoW0xjw0kN6+30US05++PgEYQvPBFp+/bdPpHXinQk/kXwKzFbJL84NtEpZiqzH1T y8CUBL4ZW84Q2FwoyXxNgoCQV29qYkpLsByuXgLfzxSvW5arGzB5YtOTkUJNtLNWRIkmwoDjjZO 0w2771vNFNxQaQ/gspMGQAtryyhA31R6p1cC7ugjksUZPZ7Io11MGn1s516JWC5xTYwVjOHVwgk fJ9tmw8XDJQ5OzjwpZZ2e0MUfgPH5wo3nuKVJ1cvPBNnkbF2jBkjHSUpYkY3+xCmEBzdRivoQ0a Thol1zPFZ99PiQ== X-Received: by 2002:a17:903:3295:b0:2e8:dd9c:99e0 with SMTP id d9443c01a7336-2e8dd9ca60cmr47644535ad.40.1792028690053; Wed, 14 Oct 2026 18:44:50 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:44:49 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 02/25] ASoC: amd: ps: Fix acp63_pdm_dma_close() being skipped on rollback Date: Thu, 15 Oct 2026 08:43:01 +0700 Message-ID: <20261015014324.5569-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp63_pdm_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: 5137305662ef ("ASoC: amd: add acp6.2 pdm driver dma ops") Reviewed-by: Vijendar Mukunda Signed-off-by: bui duc phuc --- sound/soc/amd/ps/ps-pdm-dma.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sound/soc/amd/ps/ps-pdm-dma.c b/sound/soc/amd/ps/ps-pdm-dma.c index 04c014349347..12c341e89bce 100644 --- a/sound/soc/amd/ps/ps-pdm-dma.c +++ b/sound/soc/amd/ps/ps-pdm-dma.c @@ -211,7 +211,13 @@ static int acp63_pdm_dma_open(struct snd_soc_component *component, pdm_data->acp63_base = adata->acp63_base; runtime->private_data = pdm_data; - return ret; + + /* + * ASoC only marks the component as opened when .open() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure .close() is not skipped on rollback. + */ + return 0; } static int acp63_pdm_dma_hw_params(struct snd_soc_component *component, -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32E01CC6B2D for ; Thu, 15 Oct 2026 01:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hVSYiae/vRcvOES/uAXtOV6WNC9Xuw/i4nSdh5uQ9c4=; b=jrgOpOBOOCcWmV 0/UthaLFriTmNSowX6DwgDBHC3TnDlnF6WRISEE3DfSFJbs7obzdEyHVq2dvJGwYyQrK3LvVI26FI /JMDh2jEAxI8r62sY68Fe3Smpnskrqb7YoKTOGcWN/OSt4qU0MDanMvsR4TgG4L+CgQZX5Y8t1inl 4uWEv3ALxIeuiLF2KjYJ066MIHAAkfTXPZKT5SwSUKPh1NtwCHE3F7MlJszgLqgsA/UIohIdf8drc AWZAiM81gWwzLVMlVOA0kYB0q6MDClQfy23YxSAyhy/wGd7Lzi2ANoQ/ClxXsH8x0Zq7Uc0FL/8gU vW4vDaN8n4kR6UQTdM0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHAWd-0000000Gb5p-3zzp; Thu, 15 Oct 2026 01:44:55 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHAWZ-0000000Gb4d-1tWb for linux-rockchip@lists.infradead.org; Thu, 15 Oct 2026 01:44:54 +0000 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-2e7e742a2c7so32161735ad.0 for ; Wed, 14 Oct 2026 18:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028690; x=1792633490; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YmTMAPFx5up6qhPC8f6eIWZ+fqRc0pF4DtGB7TtfWew=; b=mbPbCNHb2Nu1Sjtt8zc0ttZ3fiRSNL+Wsngs3d1n4GvG5X1Xd6R0BHEp+/eXyndMZD JeN6uL56E7jVAIsrvw5dYlmvPAxlQBjJgtL1cSRD48TopLS4gtnzPsxQEqDzxf7uq/RX jYyRppum0GKMQPeexLY9YyTQMtNuTCZfQUaX05T+BiskBwDGqgB+P71IROl/NmFePlfg WB5TS11lF2g+eB0EuIlk1bOdijRvkeDjDFMSBeCxu06u3LFxBMyJyPO2ro8LXJim/DIc O/IAbwwMG5DhbGOEb4MTZsIBjEx6UMFmwjeiLVHmXA0fr1L+ORqOVVnbDX7PJ69x53HQ eZzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028690; x=1792633490; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=YmTMAPFx5up6qhPC8f6eIWZ+fqRc0pF4DtGB7TtfWew=; b=M1QCjM9Ly63vIc1DBOjRFyUyhtKF824QonCcNO1QOMRvjnYVy8+P6XaYJgooeYHlIb Gjqqun497O3ROMUktOHPJTsoD/88uLHknj4QwU2ZDU8k15JSmqZt/9bPQGwGudCkDhZc wGdA7lBdNM1ZIMPcy3Nxs4xynJ5UrvMPZfHRl1k7uzII7Osvj/v2fNzAUyVe0rvP/5EA LcNimp5s473MLYnhDLmZm/G5DHIhv35E/8faEEzMVcgk8bE5mFBLYZs3R0JcTT1EPmWW puxZUEouL6V1pzNeM8RxZJe+GCImxMQhcKSv4QBuN347ZB0NVGsmSON+9SPTPufQcQnl BBQQ== X-Forwarded-Encrypted: i=1; AKwUvBz0g8GOWm0lR8ey8uGAdFJu4+iDVXpUL+eXHTZ6SNA3HvJC/na+xPwQfKizf+zc6UbyN+0SIRIfFKhidkGCEQ==@lists.infradead.org X-Gm-Message-State: AFq9FYKuJO7YiX9LEdoL7uysZFrAGO51U1jJ+Mpxj0Z4DT77CjX4v3oH nRgO8ubu0EGOIPL9nUCinTxalWIsBvo0XjewQGBN5/C6dYzmpvwsmoWW X-Gm-Gg: AYBFou2vpc2tKTXkFao3ouk6FUZKySdYnDAnSQxHGg6hfjbMe5fTALuNJV08njIBmDn oWqBAq3r+ZmIbu9cgUFB0vLSDiLD37593VSEukvy6LYQaKenX0PIWztn8biFJX4vAeWrxDXFEi0 bOcSeWdfmynOIi9Xr4rPdZdxe7m5Nlob5TunDpAieWOIW5HS32EEFD1DIjVuISYt4BRiHTfLH7r B2xDeGh841FwEKtf78ya0ig3t4HWtLGs7QotQ7E7nO1VwBzIi7/Vra3Jke6q+qX6VFic9ZIPe6U sNpxKL74+qYIZFwy9vwHkGW56F8VNeM/7EJJwVUK4iBXp0fBt1mIBBnqWUfjZ68trNaQ0MM15X9 EB8l3TF/h1xcBuAyQHPNKBdHuP7+oi7Ve3GHgECTNT6bgvWCXgUhJ2RfmsLpf1evcslC5zIBQ0o XSQF4XRvGLkUHga2Nx58BA4/CA4I+aMJb0GW2FFmQ62nIF0Ji0Dxxuj6iYgBxuJIBx8H0iXNZq9 3LSAd0t2xRw4h0fnajgB9pEcrT6SFd8vD+8T5tnWtQ2+/uZFHEh6fH5yUHjMWp6NRCtWExuFsNM mtEyiJLPWwK/9A== X-Received: by 2002:a17:903:3295:b0:2e8:dd9c:99e0 with SMTP id d9443c01a7336-2e8dd9ca60cmr47644535ad.40.1792028690053; Wed, 14 Oct 2026 18:44:50 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:44:49 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Subject: [PATCH v2 02/25] ASoC: amd: ps: Fix acp63_pdm_dma_close() being skipped on rollback Date: Thu, 15 Oct 2026 08:43:01 +0700 Message-ID: <20261015014324.5569-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261014_184453_461839_F3A2E7CA X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, wangdicheng , Kees Cook , Sang-Heon Jeon , Pengpeng Hou , Bo Shen , Neo Chang , linux-rockchip@lists.infradead.org, bui duc phuc , Chris Bainbridge , Charles Keepax , linux-sound@vger.kernel.org, u.kleine-koenig@baylibre.com, Zain Aboobacker , Bjorn Helgaas , Md Shofiqul Islam , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , patches@opensource.cirrus.com, Linus Walleij , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , asahi@lists.linux.dev, Hemanth Selam , linuxppc-dev@lists.ozlabs.org, Syed Saba Kareem Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp63_pdm_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: 5137305662ef ("ASoC: amd: add acp6.2 pdm driver dma ops") Reviewed-by: Vijendar Mukunda Signed-off-by: bui duc phuc --- sound/soc/amd/ps/ps-pdm-dma.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sound/soc/amd/ps/ps-pdm-dma.c b/sound/soc/amd/ps/ps-pdm-dma.c index 04c014349347..12c341e89bce 100644 --- a/sound/soc/amd/ps/ps-pdm-dma.c +++ b/sound/soc/amd/ps/ps-pdm-dma.c @@ -211,7 +211,13 @@ static int acp63_pdm_dma_open(struct snd_soc_component *component, pdm_data->acp63_base = adata->acp63_base; runtime->private_data = pdm_data; - return ret; + + /* + * ASoC only marks the component as opened when .open() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure .close() is not skipped on rollback. + */ + return 0; } static int acp63_pdm_dma_hw_params(struct snd_soc_component *component, -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip