Re: [PATCH v11 2/2] clk: qcom: Add LPASS VA CSR heartbeat pulse clock

[kernel test robot <lkp@intel.com>]

Hi Sarath,

kernel test robot noticed the following build warnings:

[auto build test WARNING on becb95e45ef0dda9ffb35156d909d3da7a2789c3]

url:    https://github.com/intel-lab-lkp/linux/commits/Sarath-Ganapathiraju-via-B4-Relay/dt-bindings-clock-qcom-Add-LPASS-VA-CSR-HeartBeat-pulse-clock/20261012-172258
base:   becb95e45ef0dda9ffb35156d909d3da7a2789c3
patch link:    https://lore.kernel.org/r/20261012-master-v11-2-15009e3ecac3%40oss.qualcomm.com
patch subject: [PATCH v11 2/2] clk: qcom: Add LPASS VA CSR heartbeat pulse clock
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20261015/202610150234.1B8DywxX-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261015/202610150234.1B8DywxX-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610150234.1B8DywxX-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/posix_types.h:5,
                    from include/uapi/linux/types.h:14,
                    from include/linux/types.h:5,
                    from include/linux/kasan-checks.h:5,
                    from include/asm-generic/rwonce.h:26,
                    from ./arch/m68k/include/generated/asm/rwonce.h:1,
                    from include/linux/compiler.h:391,
                    from include/linux/build_bug.h:5,
                    from include/linux/bits.h:30,
                    from include/linux/clk-provider.h:10,
                    from drivers/clk/qcom/lpass-va-csr.c:6:
   drivers/clk/qcom/lpass-va-csr.c: In function 'lpass_va_csr_runtime_resume':
   include/linux/stddef.h:8:14: error: called object is not a function or function pointer
       8 | #define NULL ((void *)0)
         |              ^
   include/linux/pm_clock.h:78:25: note: in expansion of macro 'NULL'
      78 | #define pm_clk_resume   NULL
         |                         ^~~~
   drivers/clk/qcom/lpass-va-csr.c:61:15: note: in expansion of macro 'pm_clk_resume'
      61 |         ret = pm_clk_resume(dev);
         |               ^~~~~~~~~~~~~
   include/linux/stddef.h:8:14: error: called object is not a function or function pointer
       8 | #define NULL ((void *)0)
         |              ^
   include/linux/pm_clock.h:77:25: note: in expansion of macro 'NULL'
      77 | #define pm_clk_suspend  NULL
         |                         ^~~~
   drivers/clk/qcom/lpass-va-csr.c:77:9: note: in expansion of macro 'pm_clk_suspend'
      77 |         pm_clk_suspend(dev);
         |         ^~~~~~~~~~~~~~
   drivers/clk/qcom/lpass-va-csr.c: In function 'lpass_va_csr_runtime_suspend':
   include/linux/stddef.h:8:14: error: called object is not a function or function pointer
       8 | #define NULL ((void *)0)
         |              ^
   include/linux/pm_clock.h:77:25: note: in expansion of macro 'NULL'
      77 | #define pm_clk_suspend  NULL
         |                         ^~~~
   drivers/clk/qcom/lpass-va-csr.c:83:16: note: in expansion of macro 'pm_clk_suspend'
      83 |         return pm_clk_suspend(dev);
         |                ^~~~~~~~~~~~~~
   drivers/clk/qcom/lpass-va-csr.c: At top level:
>> drivers/clk/qcom/lpass-va-csr.c:81:12: warning: 'lpass_va_csr_runtime_suspend' defined but not used [-Wunused-function]
      81 | static int lpass_va_csr_runtime_suspend(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/clk/qcom/lpass-va-csr.c:55:12: warning: 'lpass_va_csr_runtime_resume' defined but not used [-Wunused-function]
      55 | static int lpass_va_csr_runtime_resume(struct device *dev)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/lpass_va_csr_runtime_suspend +81 drivers/clk/qcom/lpass-va-csr.c

    54	
  > 55	static int lpass_va_csr_runtime_resume(struct device *dev)
    56	{
    57		struct lpass_va_csr *csr = dev_get_drvdata(dev);
    58		const struct lpass_va_csr_data *data = csr->data;
    59		int ret;
    60	
    61		ret = pm_clk_resume(dev);
    62		if (ret)
    63			return ret;
    64	
    65		ret = regmap_write(csr->hb.regmap, LPASS_RATE_GEN_COUNTER_0,
    66				   data->counter_0);
    67		if (ret)
    68			goto err_pm_clk_suspend;
    69	
    70		ret = regmap_write(csr->hb.regmap, LPASS_RATE_GEN_DELAY, data->delay);
    71		if (ret)
    72			goto err_pm_clk_suspend;
    73	
    74		return 0;
    75	
    76	err_pm_clk_suspend:
    77		pm_clk_suspend(dev);
    78		return ret;
    79	}
    80	
  > 81	static int lpass_va_csr_runtime_suspend(struct device *dev)
    82	{
  > 83		return pm_clk_suspend(dev);
    84	}
    85	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki