All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests <fstests@vger.kernel.org>,
	xfs <linux-xfs@vger.kernel.org>,
	Andrey Albershteyn <aalbersh@kernel.org>
Subject: [PATCH] generic/805: mask unmount failures on cleanup
Date: Wed, 14 Oct 2026 20:32:36 -0700	[thread overview]
Message-ID: <20261015033236.GV6253@frogsfrogsfrogs> (raw)

From: Darrick J. Wong <djwong@kernel.org>

On (what's left of) my NFS-booted QA fleet I get test "failures" like
this:

 --- a/generic/805.out	2026-09-22 13:33:18.326820071 -0700
 +++ b/generic/805.out.bad	2026-10-14 18:58:34.438866321 -0700
 @@ -1,2 +1,4 @@
  QA output created by 805
  Silence is golden
 +umount.nfs: remote share not in 'host:dir' format
 +umount.nfs: /mnt/s: not mounted

This is caused by the _unmount call in _cleanup getting cranky about the
scratch mount not being mounted despite the -q flag.  I think this is
because umount(8) detects the underlying fs as NFS and delegates
entirely to umount.nfs, and that program whines.

So fix the test by redirecting the output.  We've already decided if the
test passes or not before we get to cleanup.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>
---
 tests/generic/805 |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/805 b/tests/generic/805
index 401829c4c6fcdf..fa454310137a29 100755
--- a/tests/generic/805
+++ b/tests/generic/805
@@ -25,7 +25,7 @@ _cleanup()
 {
 	xfs_freeze -u $SCRATCH_MNT 2>/dev/null
 	$DMSETUP_PROG resume $lvdev >> $seqres.full 2>&1
-	_unmount -q $SCRATCH_MNT
+	_unmount -q $SCRATCH_MNT &>> $seqres.full
 	_dmsetup_remove $node
 	cd /
 	rm -f $tmp.*

             reply	other threads:[~2026-10-15  3:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15  3:32 Darrick J. Wong [this message]
2026-10-15  5:59 ` [PATCH] generic/805: mask unmount failures on cleanup Christoph Hellwig
2026-10-15 14:36   ` Darrick J. Wong
2026-10-15 14:54     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261015033236.GV6253@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=aalbersh@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.