All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Charles <daniel.charles@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: x.wang@intel.com, jia.yao@intel.com, jonathan.cavitt@intel.com,
	matthew.brost@intel.com,
	Daniel Charles <daniel.charles@intel.com>
Subject: [PATCH v3 0/3] FD close cleanup for XE
Date: Wed, 14 Oct 2026 22:01:33 -0700	[thread overview]
Message-ID: <20261015050136.1069815-1-daniel.charles@intel.com> (raw)

This series adds the suggested logic to synchronously wait for the queue
kill to complete on FD close. This is needed to avoid a race condition
where the scheduler may still be processing messages for a queue that
has been closed, which can lead to errors.

v3:
    - Patch 3 only, fix GT reset seen in CI (xe_create@create-contexts).
      See the patch 3 changelog for details.

v2:
    - Bound the wait with a timeout, GT reset on timeout (Sashiko, Matt B)
    - Drop the flush_work() loop (Matt B)
    - Use xe_assert() for the killed-queue check (Matt B)
    - Merge the put loop into the kill_sync loop (Matt B)

Daniel Charles (1):
  drm/xe: Synchronously wait for queue kill on FD close

Matthew Brost (2):
  drm/xe: Read scheduler message opcode under lock
  drm/xe: Disable scheduling early on FD close to avoid CAT error
    cascade

 drivers/gpu/drm/xe/xe_device.c               |   5 +
 drivers/gpu/drm/xe/xe_exec_queue.c           |  13 +++
 drivers/gpu/drm/xe/xe_exec_queue.h           |   1 +
 drivers/gpu/drm/xe/xe_exec_queue_types.h     |   2 +
 drivers/gpu/drm/xe/xe_gpu_scheduler.c        |  13 ++-
 drivers/gpu/drm/xe/xe_gpu_scheduler_types.h  |   2 +-
 drivers/gpu/drm/xe/xe_gt_sriov_vf.c          |   1 +
 drivers/gpu/drm/xe/xe_guc_exec_queue_types.h |   2 +-
 drivers/gpu/drm/xe/xe_guc_submit.c           | 101 +++++++++++++++++--
 drivers/gpu/drm/xe/xe_guc_submit.h           |   1 +
 drivers/gpu/drm/xe/xe_guc_types.h            |   6 ++
 11 files changed, 134 insertions(+), 13 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-10-15  5:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15  5:01 Daniel Charles [this message]
2026-10-15  5:01 ` [PATCH v3 1/3] drm/xe: Read scheduler message opcode under lock Daniel Charles
2026-10-15  5:01 ` [PATCH v3 2/3] drm/xe: Disable scheduling early on FD close to avoid CAT error cascade Daniel Charles
2026-10-15  5:01 ` [PATCH v3 3/3] drm/xe: Synchronously wait for queue kill on FD close Daniel Charles
2026-10-15  5:28   ` sashiko-bot
2026-10-15  5:13 ` ✗ CI.checkpatch: warning for FD close cleanup for XE (rev3) Patchwork
2026-10-15  5:15 ` ✓ CI.KUnit: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261015050136.1069815-1-daniel.charles@intel.com \
    --to=daniel.charles@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jia.yao@intel.com \
    --cc=jonathan.cavitt@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=x.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.