From: Maciej Kucharek <qchcio@gmail.com>
To: amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com
Cc: christian.koenig@amd.com, Maciej Kucharek <qchcio@gmail.com>
Subject: [PATCH v2 0/3] drm/amdgpu: reset SI/CIK/VI ASIC on Apple boards with VRAM at 0
Date: Thu, 15 Oct 2026 11:57:10 +0200 [thread overview]
Message-ID: <20261015095713.20560-1-qchcio@gmail.com> (raw)
In-Reply-To: <BN9PR12MB514681E5EDA768CB4497EACFF79D2@BN9PR12MB5146.namprd12.prod.outlook.com>
On MacBookPros with switchable graphics, the firmware puts VRAM at MC
address 0 when the iGPU is enabled. A later post (S3 resume, GPU
reset) moves VRAM back to the VBIOS default, and the driver keeps
using the old layout. This series resets and posts the ASIC at driver
load on Apple boards with VRAM at 0. As Alex asked in the review of
v1, it adds the same test to si.c, cik.c and vi.c.
Testing:
- Patch 1 (SI) is tested on a MacBookPro11,5: 4 of 4 S3 cycles resume.
- Patches 2 (CIK) and 3 (VI) are only compile-tested.
- No MacBookPro has a CIK GPU, so patch 2 is for consistency only.
- Patch 3 also resets other Polaris MacBookPros with VRAM at 0, for
example the MacBookPro13,3. This is not tested.
- The series does not change Vega or Navi.
Patch 3 keeps vi_reset_quirks[]. Its MacBookPro15,1 entries fix a
module reload after S3, when VRAM is no longer at 0. The new test may
not cover that case. The new test also catches the MacBookPro14,3, so
its entry is now redundant. I can remove it in a follow-up if you
prefer.
Changes in v2:
- Add the same test to cik.c and vi.c (Alex).
- SI commit message: cite only the MacBookPro14,3 quirk as the same
cause. The MacBookPro15,1 quirk fixes a different failure.
- Code comment: add the iGPU condition.
v1: https://lore.kernel.org/amd-gfx/20261014192030.10611-1-qchcio@gmail.com/
Maciej Kucharek (3):
drm/amdgpu: reset SI ASIC on MacBookPros with VRAM at 0
drm/amdgpu: reset CIK ASIC on Apple boards with VRAM at 0
drm/amdgpu: reset VI ASIC on Apple boards with VRAM at 0
drivers/gpu/drm/amd/amdgpu/cik.c | 10 ++++++++++
drivers/gpu/drm/amd/amdgpu/si.c | 10 ++++++++++
drivers/gpu/drm/amd/amdgpu/vi.c | 10 ++++++++++
3 files changed, 30 insertions(+)
--
2.55.0
next prev parent reply other threads:[~2026-10-15 12:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 19:20 [PATCH] drm/amdgpu: reset SI ASIC on MacBookPros with VRAM at 0 Maciej Kucharek
2026-10-14 21:39 ` Deucher, Alexander
2026-10-15 9:57 ` Maciej Kucharek [this message]
2026-10-15 9:57 ` [PATCH v2 1/3] " Maciej Kucharek
2026-10-15 9:57 ` [PATCH v2 2/3] drm/amdgpu: reset CIK ASIC on Apple boards " Maciej Kucharek
2026-10-15 9:57 ` [PATCH v2 3/3] drm/amdgpu: reset VI " Maciej Kucharek
2026-10-15 13:26 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015095713.20560-1-qchcio@gmail.com \
--to=qchcio@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.