All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
To: Srirangan Madhavan <smadhavan@nvidia.com>
Cc: mark.rutland@arm.com, lpieralisi@kernel.org,
	sudeep.holla@kernel.org, conor@kernel.org, jic23@kernel.org,
	catalin.marinas@arm.com, will@kernel.org, andre.przywara@arm.com,
	aneesh.kumar@kernel.org, Souvik.Chakravarty@arm.com,
	treding@nvidia.com, jonathanh@nvidia.com, bence.csokas@arm.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v4 2/2] cache: add SMCCC-backed cache invalidate provider
Date: Thu, 15 Oct 2026 11:30:19 -0700	[thread overview]
Message-ID: <20261015113019.000050e3@oss.qualcomm.com> (raw)
In-Reply-To: <20261013070205.3566865-3-smadhavan@nvidia.com>

On Tue, 13 Oct 2026 07:02:05 +0000
Srirangan Madhavan <smadhavan@nvidia.com> wrote:

> Add a cache maintenance provider for the cache clean+invalidate interface
> defined by Arm DEN0028 v1.7.
> 
> Register the interface attributes function as an SMCCC device and bind the
> provider through the SMCCC bus. The provider reads the firmware attributes
> during probe and serializes cache maintenance calls. It handles transient
> BUSY and RATE_LIMITED responses with bounded retries. It also registers
> with the generic cache coherency framework used by memregion callers.
> 
> Signed-off-by: Srirangan Madhavan <smadhavan@nvidia.com>

I'm fine with the changes to put it on the bus and Andre's suggestion to drop
the latency value handling. So with that done

Reviewed-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>

I'd probably not have bothered with the mutex_destroy() given limited
utility vs code added (I mind that less if devm is appropriate, but doing
that here would be messy).  If we ever see a use of that after the destroy
then something exceedingly weird is going on!

Anyhow, doesn't really matter either way.

Jonathan


      parent reply	other threads:[~2026-10-15 18:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13  7:02 [PATCH v4 0/2] Add SMCCC cache clean/invalidate provider Srirangan Madhavan
2026-10-13  7:02 ` [PATCH v4 1/2] arm64: smccc: add cache clean/invalidate IDs and return codes Srirangan Madhavan
2026-10-13  7:02 ` [PATCH v4 2/2] cache: add SMCCC-backed cache invalidate provider Srirangan Madhavan
2026-10-14 15:38   ` Andre Przywara
2026-10-15  7:43     ` Bence Csókás
2026-10-15 10:03       ` Andre Przywara
2026-10-15 18:30   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261015113019.000050e3@oss.qualcomm.com \
    --to=jonathan.cameron@oss.qualcomm.com \
    --cc=Souvik.Chakravarty@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=aneesh.kumar@kernel.org \
    --cc=bence.csokas@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=conor@kernel.org \
    --cc=jic23@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=smadhavan@nvidia.com \
    --cc=sudeep.holla@kernel.org \
    --cc=treding@nvidia.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.