From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71A69CC6B34 for ; Thu, 15 Oct 2026 12:22:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xHKTF-0004md-Cq; Thu, 15 Oct 2026 08:22:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHKTC-0004bY-Gt for qemu-arm@nongnu.org; Thu, 15 Oct 2026 08:22:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHKTA-0005WL-94 for qemu-arm@nongnu.org; Thu, 15 Oct 2026 08:22:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792066919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GpVJAmlJwramNm3qfiT4Q7sCEUthF+ooqYIvVl17HUA=; b=I2zVzrk49qdLFQ6b8GFVvL3c4VsWBgnef/XlXQLrnRY52oVuepBUMCzZ2HxJwqqaavEt8u zPqe82uveWBXCpKSTXxoo06NGSJyCzkkBeF7eSldMPknFWpNeNUC46QzKL/177PgS8UPjg ZCJQv6eCcU+DlBXzwvlvt8A86U9UitY= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-149-xxRPv0g5OwaSdwUKZRzb8g-1; Thu, 15 Oct 2026 12:21:58 +0000 X-MC-Unique: xxRPv0g5OwaSdwUKZRzb8g-1 X-Mimecast-MFC-AGG-ID: xxRPv0g5OwaSdwUKZRzb8g_1792066917 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E4C2D19560B8; Thu, 15 Oct 2026 12:21:56 +0000 (UTC) Received: from corto.redhat.com (unknown [10.44.48.67]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 05EF77D5; Thu, 15 Oct 2026 12:21:54 +0000 (UTC) From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Christopher Boker , Jamin Lin Subject: [PULL 01/21] hw/misc/aspeed_hace: Fix OOB read in has_padding() Date: Thu, 15 Oct 2026 14:21:31 +0200 Message-ID: <20261015122151.889017-2-clg@redhat.com> In-Reply-To: <20261015122151.889017-1-clg@redhat.com> References: <20261015122151.889017-1-clg@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-MFC-PROC-ID: 3iaDykHXdY_qPWpBEIboivWUkPNT4lFyp_fWpufTxTE_1792066917 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org When total_msg_len equals total_req_len, padding_size is 0, making pad_offset equal to req_len. The subsequent padding[pad_offset] read accesses one byte past the buffer. Return false early when padding_size is zero. Fixes: 5cd7d8564a8b ("aspeed/hace: Support AST2600 HACE") Reported-by: Christopher Boker Reviewed-by: Jamin Lin Link: https://lore.kernel.org/qemu-devel/20260908053101.1149625-1-clg@redhat.com Signed-off-by: Cédric Le Goater --- hw/misc/aspeed_hace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index 8de05a9d98b3..bf8af710335d 100644 --- a/hw/misc/aspeed_hace.c +++ b/hw/misc/aspeed_hace.c @@ -225,7 +225,7 @@ static bool has_padding(AspeedHACEState *s, struct iovec *iov, uint32_t padding_size = s->total_req_len - *total_msg_len; uint8_t *padding = iov->iov_base; - if (padding_size > req_len) { + if (padding_size == 0 || padding_size > req_len) { return false; } -- 2.56.0