From: SJ Park <sj@kernel.org>
To: Manuel Ebner <manuelebnerli@mailbox.org>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/damon/lru_sort: fix grammar and stlye
Date: Thu, 15 Oct 2026 06:50:46 -0700 [thread overview]
Message-ID: <20261015135047.87355-1-sj@kernel.org> (raw)
In-Reply-To: <20261015072947.802821-2-manuelebnerli@mailbox.org>
On Thu, 15 Oct 2026 09:29:47 +0200 Manuel Ebner <manuelebnerli@mailbox.org> wrote:
> Fix tenses. Split long sentences thereby imporove readability.
> Replace 'set as' with 'set to'. Replace [] with () to make the file uniform.
checkpatch.pl warns as below.
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#10:
Replace 'set as' with 'set to'. Replace [] with () to make the file uniform.
If you don't mind, I will fix this on my end.
>
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
Assuming you don't mind me fixing the 75 columns warning on my end,
Reviewed-by: SJ Park <sj@kernel.org>
I applied this patch to damon/next [1] tree with the above mentioned commit
message line length fix. We are now quite close to next merge window. It may
better to focus on making mm.git more stabilized and therefore ready for the
next merge window, rather than adding more changes that are not really urgent.
I understand this series is not really urgent. Hence, Andrew might not add
this patch until next -rc1 release. In the case, I will request adding this to
mm.git after next -rc1 release. So, no action from your side is needed for
now. Let me know if you think this is really urgent.
> ---
Please add changelog on the commentary area [2], with links to the previous
revisions, from the next time.
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
[2] https://docs.kernel.org/process/submitting-patches.html#commentary
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-10-15 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 7:29 [PATCH v2] mm/damon/lru_sort: fix grammar and stlye Manuel Ebner
2026-10-15 13:50 ` SJ Park [this message]
2026-10-15 14:54 ` Manuel Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015135047.87355-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=damon@lists.linux.dev \
--cc=david@kernel.org \
--cc=liam@infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=manuelebnerli@mailbox.org \
--cc=mhocko@suse.com \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.