From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrey Albershteyn <aalbersh@kernel.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] libxfs: fix compilation errors
Date: Thu, 15 Oct 2026 07:43:02 -0700 [thread overview]
Message-ID: <20261015144302.GO2705364@frogsfrogsfrogs> (raw)
In-Reply-To: <atBrJO9owC7yXsRb@infradead.org>
On Wed, Oct 14, 2026 at 10:56:52PM -0700, Christoph Hellwig wrote:
> On Wed, Oct 14, 2026 at 11:42:12AM -0700, Darrick J. Wong wrote:
> > Add -Werror=missing-prototype (or -Werror) to WARNINGS in
> > include/builddefs.in:
> >
> > WARNINGS += -Werror
> >
> > Then rerun configure and make
>
> Ah. This is not "compiler apply the default function declaration",
> but the compiler warning about not having a prototype for a non-static
> definition. Which is still somewhat useful, so I think we should
> enable it as a warning (but not as an error like above) for xfsprogs
> as well to stay in sync.
Well if you really want I'll share my old debug patch that tries to
enable as much of the kernel's W=3e as one can do sanely.
--D
next prev parent reply other threads:[~2026-10-15 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 17:44 [PATCH] libxfs: fix compilation errors Darrick J. Wong
2026-10-14 18:24 ` Christoph Hellwig
2026-10-14 18:42 ` Darrick J. Wong
2026-10-15 5:56 ` Christoph Hellwig
2026-10-15 14:43 ` Darrick J. Wong [this message]
2026-10-15 14:53 ` Christoph Hellwig
2026-10-15 5:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015144302.GO2705364@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=aalbersh@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.