Re: [PATCH v4 5/9] mfd: cgbc: Use real I2C bus names

[Lee Jones <lee@kernel.org>]

On Fri, 02 Oct 2026, Thomas Richard (congatec GmbH) wrote:

> The adapter names described the expected purpose of the buses ("General
> Purpose I2C adapter", "Power Management I2C adapter") on conga-sa7 board
> rather than their actual names on the Board Controller.
> 
> Rename them to the real bus names "cgbc-i2c0" and "cgbc-ddc0", matching
> the naming used by Congatec, and update the variable names accordingly.
> 
> Signed-off-by: Thomas Richard (congatec GmbH) <thomas.richard@bootlin.com>
> ---
>  drivers/mfd/cgbc-core.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/mfd/cgbc-core.c b/drivers/mfd/cgbc-core.c
> index 8522df882509..a58d9ffdc277 100644
> --- a/drivers/mfd/cgbc-core.c
> +++ b/drivers/mfd/cgbc-core.c
> @@ -55,13 +55,13 @@
>  
>  static struct platform_device *cgbc_pdev;
>  
> -static const struct cgbc_i2c_platform_data cgbc_i2c_gp_pdata = {
> -	.name = "Congatec General Purpose I2C adapter",

This is odd.  We only just added these.

This should be fixed up into the original patch.

> +static const struct cgbc_i2c_platform_data cgbc_i2c_i2c0_pdata = {
> +	.name = "cgbc-i2c0",
>  	.cgbc_bus_id = 0,
>  };
>  
> -static const struct cgbc_i2c_platform_data cgbc_i2c_pm_pdata = {
> -	.name  = "Congatec Power Management I2C adapter",
> +static const struct cgbc_i2c_platform_data cgbc_i2c_ddc0_pdata = {
> +	.name  = "cgbc-ddc0",
>  	.cgbc_bus_id = 4,
>  };
>  
> @@ -71,13 +71,13 @@ static const struct mfd_cell cgbc_devs[] = {
>  	MFD_CELL_NAME("cgbc-hwmon"),
>  	{
>  		.name = "cgbc-i2c",
> -		.platform_data = &cgbc_i2c_gp_pdata,
> -		.pdata_size = sizeof(cgbc_i2c_gp_pdata),
> +		.platform_data = &cgbc_i2c_i2c0_pdata,
> +		.pdata_size = sizeof(cgbc_i2c_i2c0_pdata),
>  	},
>  	{
>  		.name = "cgbc-i2c",
> -		.platform_data = &cgbc_i2c_pm_pdata,
> -		.pdata_size = sizeof(cgbc_i2c_pm_pdata),
> +		.platform_data = &cgbc_i2c_ddc0_pdata,
> +		.pdata_size = sizeof(cgbc_i2c_ddc0_pdata),
>  	},
>  	MFD_CELL_NAME("cgbc-wdt"),
>  };
> 
> -- 
> 2.53.0
> 

-- 
Lee Jones