All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Vishal Badole <Vishal.Badole@amd.com>
Cc: bp@alien8.de, tony.luck@intel.com, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] EDAC/amd64: Add support for Family 1Ah models 0x88 ... 0x8f
Date: Thu, 15 Oct 2026 11:54:00 -0400	[thread overview]
Message-ID: <20261015155400.GC5279@yaz-khff2.amd.com> (raw)
In-Reply-To: <20261014085720.1471993-3-Vishal.Badole@amd.com>

On Wed, Oct 14, 2026 at 02:27:20PM +0530, Vishal Badole wrote:
> Family 1Ah models 0x88 ... 0x8f use the default settings for the 1Ah
> family: 2 UMCs using the 'v2' register layout.
> 
> Add these models to the supported list so the module can decode and
> report memory errors on them.
> 
> Suggested-by: Yazen Ghannam <yazen.ghannam@amd.com>

I don't think this ^^^ is necessary.

> Signed-off-by: Vishal Badole <Vishal.Badole@amd.com>
> ---
>  drivers/edac/amd64_edac.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index 7ba347bfd9a0..21ce1caa7151 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -3894,6 +3894,7 @@ static int per_family_init(struct amd64_pvt *pvt)
>  			pvt->max_mcs            = 12;
>  			break;
>  		case 0x40 ... 0x4f:
> +		case 0x88 ... 0x8f:
>  			break;
>  		case 0x50 ... 0x57:
>  		case 0xc0 ... 0xc7:
> -- 

Otherwise, LGTM.

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks,
Yazen

      reply	other threads:[~2026-10-15 15:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14  8:57 [PATCH 0/2] EDAC/amd64: Consolidate Family 1Ah setup and add support for models 0x88 ... 0x8f Vishal Badole
2026-10-14  8:57 ` [PATCH 1/2] EDAC/amd64: Consolidate Family 1Ah model setup Vishal Badole
2026-10-15 15:49   ` Yazen Ghannam
2026-10-14  8:57 ` [PATCH 2/2] EDAC/amd64: Add support for Family 1Ah models 0x88 ... 0x8f Vishal Badole
2026-10-15 15:54   ` Yazen Ghannam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261015155400.GC5279@yaz-khff2.amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=Vishal.Badole@amd.com \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.