From: Jakub Kicinski <kuba@kernel.org>
To: Quanye Yang via B4 Relay <devnull+quanyeyang.proton.me@kernel.org>
Cc: quanyeyang@proton.me, John Fastabend <john.fastabend@gmail.com>,
Sabrina Dubroca <sd@queasysnail.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jakub Sitnicki <jakub@cloudflare.com>,
Jiayuan Chen <jiayuan.chen@linux.dev>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/2] tls: annotate lockless access to sk->sk_err
Date: Thu, 15 Oct 2026 19:04:14 -0700 [thread overview]
Message-ID: <20261015190414.000e83dd@kernel.org> (raw)
In-Reply-To: <20261010-tls-fix-sk-kcsan-err-v3-1-e28aadeb31ad@proton.me>
On Sat, 10 Oct 2026 07:46:28 -0700 Quanye Yang via B4 Relay wrote:
> + if (has_copied) {
> + int err = READ_ONCE(sk->sk_err);
> +
> + if (err)
> + return -err;
> + } else {
> + int err = sock_error(sk);
> +
> + if (err)
> + return err;
the int err declaration force you to add ugly empty
lines, just decl skerr at the top level of the func
and use it here and in the chunk below
--
pw-bot: cr
next prev parent reply other threads:[~2026-10-16 2:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 14:46 [PATCH net-next v3 0/2] net: annotate remaining lockless sk->sk_err accesses Quanye Yang via B4 Relay
2026-10-10 14:46 ` Quanye Yang
2026-10-10 14:46 ` [PATCH net-next v3 1/2] tls: annotate lockless access to sk->sk_err Quanye Yang via B4 Relay
2026-10-10 14:46 ` Quanye Yang
2026-10-11 15:10 ` netdev-bot+sashiko
2026-10-15 10:12 ` quanyeyang
2026-10-16 2:04 ` Jakub Kicinski [this message]
2026-10-10 14:46 ` [PATCH net-next v3 2/2] net: annotate lockless writes " Quanye Yang via B4 Relay
2026-10-10 14:46 ` Quanye Yang
2026-10-11 15:10 ` netdev-bot+sashiko
2026-10-15 10:04 ` quanyeyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015190414.000e83dd@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=devnull+quanyeyang.proton.me@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=jakub@cloudflare.com \
--cc=jiayuan.chen@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quanyeyang@proton.me \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.