All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Frank.Li@oss.nxp.com
Cc: Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Mikulas Patocka <mpatocka@redhat.com>,
	Benjamin Marzinski <bmarzins@redhat.com>,
	Song Liu <song@kernel.org>, Yu Kuai <yukuai@fygo.io>,
	Li Nan <magiclinan@didiglobal.com>, Xiao Ni <xiao@kernel.org>,
	Dan Williams <djbw@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-doc@vger.kernel.org, Anatolij Gustschin <agust@denx.de>,
	Saeed Bishara <saeed@marvell.com>,
	Rameshwar Prasad Sahu <rsahu@apm.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Anup Patel <anup.patel@broadcom.com>, Frank Li <Frank.Li@nxp.com>
Subject: Re: [PATCH RFC 0/4] async_tx/md: Remove async_tx framework
Date: Thu, 15 Oct 2026 19:51:17 +0000	[thread overview]
Message-ID: <20261015195117.GI2170687@google.com> (raw)
In-Reply-To: <20261015-asycn_tx_remove-v1-0-056a7085e0a1@nxp.com>

On Thu, Oct 15, 2026 at 03:22:24PM -0400, Frank.Li@oss.nxp.com wrote:
> This RFC is collecting more feedbacks to device when is good time to remove
> whole async_tx framework and how to remove it safely. And is overall
> direction correction.
> 
> Little to no real hardware acceleration usage:
>   Most systems run RAID5/6 parity calculations on the CPU using optimized
>   XOR/PQ implementations, while DMAEngine-backed async_tx acceleration is
>   rarely present or exercised.
> 
> Added abstraction and maintenance cost:
>   async_tx introduces an extra layer between MD RAID and parity operations,
>   making the code harder to understand, debug, and maintain.
> 
> Modern CPUs outperform DMA offload:
>   SIMD implementations (SSE/AVX/NEON and architecture-specific RAID
>   routines) often provide better performance than DMA descriptor setup and
>   completion handling overhead.
> 
> Obsolete hardware dependencies:
>   Many async_tx acceleration backends were designed for older DMA/XOR
>   engines that are no longer common in contemporary systems.
> 
> Complex asynchronous execution model:
>   Dependency chains, callback handling, and DMA transaction management
>   increase code complexity without corresponding performance benefits on
>   typical deployments.Simplifies RAID code paths: Removing async_tx allows
>   direct use of synchronous XOR/PQ helpers, reducing indirection in raid5.c
>   source code [linux/drivers/md/raid5.c].
> 
> Reduces testing burden:
>   Eliminates rarely used code paths that are difficult to validate and more
>   likely to accumulate latent bugs.
> 
> Aligns implementation with actual usage:
>   The vast majority of MD RAID deployments already rely on software parity
>   generation rather than DMA offload.
[..]
>  17 files changed, 281 insertions(+), 2843 deletions(-)

I haven't been paying much attention to the crypto/async_tx/ directory,
but this makes sense to me.  This mirrors similar trends that we've seen
with the crypto and CRC algorithms.  For these types of algorithms, just
using the CPU is faster and much simpler than trying to offload the
operation to some external hardware engine (which rarely even exist).

- Eric

      parent reply	other threads:[~2026-10-15 19:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 19:22 [PATCH RFC 0/4] async_tx/md: Remove async_tx framework Frank.Li
2026-10-15 19:22 ` [PATCH RFC 1/4] md/dm-integrity: replace async_tx with synchronous xor for journal Frank.Li
2026-10-15 19:22 ` [PATCH RFC 2/4] md/raid5-ppl: replace async_tx with synchronous xor Frank.Li
2026-10-15 19:22 ` [PATCH RFC 3/4] md/raid5: replace async_tx with synchronous xor/pq operations Frank.Li
2026-10-15 19:22 ` [PATCH RFC 4/4] crypto: remove async_tx framework Frank.Li
2026-10-15 19:51 ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261015195117.GI2170687@google.com \
    --to=ebiggers@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=Frank.Li@oss.nxp.com \
    --cc=agk@redhat.com \
    --cc=agust@denx.de \
    --cc=anup.patel@broadcom.com \
    --cc=bmarzins@redhat.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=djbw@kernel.org \
    --cc=dm-devel@lists.linux.dev \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=magiclinan@didiglobal.com \
    --cc=mpatocka@redhat.com \
    --cc=rdunlap@infradead.org \
    --cc=rsahu@apm.com \
    --cc=saeed@marvell.com \
    --cc=skhan@linuxfoundation.org \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=xiao@kernel.org \
    --cc=yukuai@fygo.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.