Re: [PATCH v4 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard

[Rob Herring <robh@kernel.org>]

On Thu, Oct 15, 2026 at 06:08:58AM -0500, wyibo6109@gmail.com wrote:
> From: Yibo Wang <wyibo6109@gmail.com>
> 
> Binding for the OnePlus Pad 3 Pro / Pad 4 and OPPO Pad 5 Pro pogo-pin
> smart keyboards, built around a Tinno keyboard MCU and attached to a
> tablet UART.  Describes the supply, TX-gate and wake GPIOs, with a
> MAINTAINERS entry.
> 
> The compatible names the tablet project the pogo port belongs to
> (caihong, erhai or iceland), which pins the keyboard generation and
> with it the protocol extensions the host may use: the 0x3A general
> sub-commands grew over time, from the caihong (sm8650 era) keyboards
> with neither wake notification nor backlight, through erhai (sm8750
> era, wake notification) to iceland (sm8850 era, keyboard backlight).
> 
> The keyboard is a fixed physical device, so the touchpad geometry and
> the product names are per-project constants and live in the driver;
> the common touchscreen properties (touchscreen-size-x/y,
> touchscreen-x-mm/y-mm) remain as an optional override if a variant
> ever needs one.
> 
> Signed-off-by: Yibo Wang <wyibo6109@gmail.com>
> ---
>  .../bindings/input/oneplus,pogo-keyboard.yaml | 73 +++++++++++++++++++
>  MAINTAINERS                                   |  6 ++
>  2 files changed, 79 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/oneplus,pogo-keyboard.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/oneplus,pogo-keyboard.yaml b/Documentation/devicetree/bindings/input/oneplus,pogo-keyboard.yaml
> new file mode 100644
> index 000000000..bab9ff3d3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/oneplus,pogo-keyboard.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (c) 2026 Yibo Wang <wyibo6109@gmail.com>
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/oneplus,pogo-keyboard.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OnePlus / OPPO Pad pogo-pin smart keyboard
> +
> +maintainers:
> +  - Yibo Wang <wyibo6109@gmail.com>
> +
> +description: |

Don't need '|'.

> +  The OnePlus Pad 3 Pro / Pad 4 and OPPO Pad 5 Pro pogo-pin smart
> +  keyboards, built around a Tinno keyboard MCU.  The keyboard is
> +  attached to a tablet UART and speaks a framed half-duplex protocol
> +  over a shared single wire; host transmission is gated onto the wire
> +  by a PMIC GPIO for the duration of a frame.  It provides a keyboard
> +  matrix, a touchpad and a keyboard backlight.

Wrap lines at 80 char.

> +
> +allOf:
> +  - $ref: /schemas/serial/serial-peripheral-props.yaml#
> +  - $ref: /schemas/input/touchscreen/touchscreen.yaml#
> +
> +properties:
> +  compatible:
> +    description: |
> +      Names the tablet project the pogo port belongs to, which pins the
> +      keyboard generation and the protocol extensions the host may
> +      use: caihong (sm8650 era) supports neither the wake notification
> +      nor a backlight, erhai (sm8750 era) adds the wake notification,
> +      iceland (sm8850 era) adds the keyboard backlight.
> +    enum:
> +      - oneplus,caihong-pogo-keyboard
> +      - oneplus,erhai-pogo-keyboard
> +      - oneplus,iceland-pogo-keyboard
> +
> +  power-gpios:
> +    description: GPIO enabling the keyboard supply, held high while attached.
> +    maxItems: 1
> +
> +  tx-enable-gpios:
> +    description: GPIO gating host TX onto the shared one-wire bus.
> +    maxItems: 1
> +
> +  wake-gpios:
> +    description: GPIO signalling attach/detach, also used as the wake line.
> +    maxItems: 1
> +
> +  touchscreen-size-x: true
> +  touchscreen-size-y: true
> +  touchscreen-x-mm: true
> +  touchscreen-y-mm: true
> +
> +required:
> +  - compatible
> +  - power-gpios
> +  - tx-enable-gpios
> +  - wake-gpios
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +

As this goes under 'serial' nodes:

serial {

> +    keyboard {
> +        compatible = "oneplus,iceland-pogo-keyboard";
> +        power-gpios = <&pmic_gpios 12 GPIO_ACTIVE_HIGH>;
> +        tx-enable-gpios = <&pmic2_gpios 6 GPIO_ACTIVE_HIGH>;
> +        wake-gpios = <&tlmm 151 GPIO_ACTIVE_LOW>;
> +    };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8014b9f82..9c29eb961 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20156,6 +20156,12 @@ S:	Maintained
>  F:	Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-dev
>  F:	drivers/usb/misc/onboard_usb_dev.c
>  
> +ONEPLUS POGO-PIN KEYBOARD DRIVER
> +M:	Yibo Wang <wyibo6109@gmail.com>
> +L:	linux-input@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/input/oneplus,pogo-keyboard.yaml
> +
>  ONENAND FLASH DRIVER
>  M:	Kyungmin Park <kyungmin.park@samsung.com>
>  L:	linux-mtd@lists.infradead.org
> -- 
> 2.53.0
>