Re: [PATCH net-next v3 04/13] dt-bindings: net: dsa: renesas,rzn1-a5psw: Disallow ports beyond port@4

[Rob Herring <robh@kernel.org>]

On Thu, Oct 15, 2026 at 01:19:31PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dt-bindings: net: dsa: incomplete schema validation allows bypassing port restrictions via ports node
> --
> 
> commit b100423001348cf87abe9e11b4f74d424451c2db
> Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> dt-bindings: net: dsa: renesas,rzn1-a5psw: Disallow ports beyond port@4
> 
> Restrict the A5PSW ethernet-ports node to ports 0 through 4, matching the
> hardware configuration of four external ports and one CPU/management port.
> 
> > diff --git a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> > index fab6aa6237e93..c5e652c057a94 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> > @@ -61,7 +61,14 @@ properties:
> >  
> >    ethernet-ports:
> >      type: object
> > -    additionalProperties: true
> > +    additionalProperties: false
> 
> [Severity: Low]
> Does this schema allow bypassing the port restrictions if a device tree uses
> a node named ports instead of ethernet-ports?
> 
> Because dsa.yaml allows either ports or ethernet-ports, and the schema
> doesn't list ethernet-ports in the required properties, a devicetree could
> define a ports node with a port outside the 0-4 range (e.g. port@5) and
> silently pass validation.

You should use 'additionalProperties' at the top-level to fix this.

Rob