From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE6113C1D7E; Thu, 15 Oct 2026 22:58:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792105101; cv=none; b=R9OSZBzSxAt+XFsjBZMYgwfhyv7kLNG2DyFSuTUxKjHy6QysXcUiprLgmOaPcniVbPOEQM1fysrhVAg76UdKIfgFMPHfBh+cCOpnOiSSsykA6I0xMQ9X3jq1hElMOqQ53vS0JY7Bl55yrj2BNg7SwHYnra63Nalrbbt/j4vHQzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792105101; c=relaxed/simple; bh=Xbma7a4OiHmw+brIGl3XV001oD62IJ6YkwJpWnwKWBA=; h=Date:To:From:Subject:Message-Id; b=rO09RfYUO83p61EonObwl3OLkiHDORQ0SwQBoiWJUV63O0vZ86TiXlciAOWviLjSeXrH7NpvVd4SNluZZYjT4n/U+SigBqF9pbtyfMhPp/zU65Svme6yfaTX71n25javTgS25wZlpIjbgnjwYLvt/sfTQbDACy1NgUF8sULPfq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=aHnpBPqL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="aHnpBPqL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5279B1F000C5; Thu, 15 Oct 2026 22:58:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1792105098; bh=RBBYKDU9OoOfMAfhL9s1zqDdjyJuT+PGV3X3QHbnm9k=; h=Date:To:From:Subject; b=aHnpBPqLejRjQ3PCcaGjqrrVIlSRMpoVW9A69VrpmzRgUhOyoKN6ui1vpv0Ak4DI1 eShrv2YgECMGm5RrtXmryEWu1OZwLMgrJwGQ0Vtn6Mifce4PqYeotz84WkL3DUSgRv 3shM+qpPGHiiRusea3hUUONupTXlLpM6q5WnaXoM= Date: Thu, 15 Oct 2026 15:58:17 -0700 To: mm-commits@vger.kernel.org,vbabka@kernel.org,stable@vger.kernel.org,rppt@kernel.org,riel@surriel.com,pfalcato@suse.de,peterx@redhat.com,osalvador@suse.de,nao.horiguchi@gmail.com,muchun.song@linux.dev,mel@csn.ul.ie,ljs@kernel.org,linmiaohe@huawei.com,liam@infradead.org,kas@kernel.org,jannh@google.com,david@kernel.org,agl@us.ibm.com,josef@toxicpanda.com,akpm@linux-foundation.org From: Andrew Morton Subject: + mm-hugetlb-fix-use-after-free-of-a-new-anon-folio.patch added to mm-hotfixes-unstable branch Message-Id: <20261015225818.5279B1F000C5@smtp.kernel.org> Precedence: bulk X-Mailing-List: mm-commits@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The patch titled Subject: mm/hugetlb: fix use-after-free of a new anon folio has been added to the -mm mm-hotfixes-unstable branch. Its filename is mm-hugetlb-fix-use-after-free-of-a-new-anon-folio.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-hugetlb-fix-use-after-free-of-a-new-anon-folio.patch This patch will later appear in the mm-hotfixes-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via various branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there most days ------------------------------------------------------ From: Josef Bacik Subject: mm/hugetlb: fix use-after-free of a new anon folio Date: Thu, 15 Oct 2026 18:07:08 +0200 For a fault in a private mapping with nothing in the page cache, hugetlb_no_page() allocates a folio, locks it and maps it. The folio has one reference, which belongs to the page table entry from then on. After dropping the page table lock the function still sets the migratable flag of the folio and unlocks it. Whoever zaps the entry in between frees the folio. The fault holds the fault mutex and the lock of the vma. MADV_DONTNEED and the first unmap of a hole punch, hugetlb_vmdelete_list(), do not take the fault mutex, and a private vma only has a lock if it owns a reservation map: not with MAP_NORESERVE, and not in the child after fork(). Then the flag is set in, and folio_unlock() is called on, a folio that is free or has a new owner. A surplus page goes back to the page allocator while it is locked: BUG: Bad page state in process init pfn:108e00 flags: 0x200000000000059(locked|uptodate|dirty|head|node=0|zone=2) page dumped because: PAGE_FLAGS_CHECK_AT_FREE flag(s) set A page of the pool can be given to the next user, of any file, who locks it and loses the lock to the late folio_unlock(): kernel BUG at mm/filemap.c:1532! hugetlb_no_page+0x111b/0x23e0 hugetlb_fault+0x3a9/0x14a0 An unprivileged process is enough: threads that write to a MAP_PRIVATE | MAP_NORESERVE hugetlb mapping, threads that call MADV_DONTNEED on it, and one that takes the freed pages for another file. Until commit 3a47c54f09c4 ("hugetlbfs: revert use i_mmap_rwsem for more pmd sharing synchronization") the fault held i_mmap_rwsem for reading, which everybody who zaps takes for writing. The lock that commit bf4916922c60 ("hugetlbfs: extend hugetlb_vma_lock to private VMAs") gave to private vmas closed the window again, but only for those with a reservation map. Be done with the folio before the page table lock is dropped, as hugetlb_wp() is with its copy. The function already unlocks page cache folios under that lock. Original fix generated by an LLM and sent in private by Josef. Link: https://lore.kernel.org/20261015-urgent_fixes-v1-2-42796911043b@kernel.org Fixes: 3a47c54f09c4 ("hugetlbfs: revert use i_mmap_rwsem for more pmd sharing synchronization") Signed-off-by: Josef Bacik Signed-off-by: David Hildenbrand (Arm) Signed-off-by: Andrew Morton Reviewed-by: Lorenzo Stoakes (ARM) Cc: Liam R. Howlett Cc: Vlastimil Babka Cc: Jann Horn Cc: Pedro Falcato Cc: Muchun Song Cc: Oscar Salvador Cc: Miaohe Lin Cc: Naoya Horiguchi Cc: Adam Litke Cc: Mel Gorman Cc: Rik van Riel Cc: Peter Xu Cc: Kiryl Shutsemau Cc: Mike Rapoport Cc: [ david: simplify+move comment ] --- mm/hugetlb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/mm/hugetlb.c~mm-hugetlb-fix-use-after-free-of-a-new-anon-folio +++ a/mm/hugetlb.c @@ -5960,8 +5960,6 @@ static vm_fault_t hugetlb_no_page(struct ret = hugetlb_wp(vmf); } - spin_unlock(vmf->ptl); - /* * Only set hugetlb_migratable in newly allocated pages. Existing pages * found in the pagecache may not have hugetlb_migratable if they have @@ -5972,6 +5970,12 @@ static vm_fault_t hugetlb_no_page(struct if (folio_locked) folio_unlock(folio); + + /* + * Hold the PTL until we're done with the folio: the page table owns the + * folio reference now. + */ + spin_unlock(vmf->ptl); out: hugetlb_vma_unlock_read(vma); _ Patches currently in -mm which might be from josef@toxicpanda.com are mm-vma-dont-leak-the-commit-charge-on-mmap-failure.patch mm-hugetlb-fix-use-after-free-of-a-new-anon-folio.patch mm-hugetlb-unmap-the-page-where-the-other-vma-maps-it.patch mm-hugetlb-dont-clear-the-resv_map-of-a-vma-whose-lock-is-held.patch mm-hugetlb-fix-endless-write-fault-on-a-leftover-uffd-bit.patch mm-hugetlb-dont-leave-a-uffd-wp-marker-when-zapping-an-rwp-entry.patch