From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44D0CCC6B38 for ; Fri, 16 Oct 2026 07:32:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D73E112623; Fri, 16 Oct 2026 07:32:14 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B3EE112623 for ; Fri, 16 Oct 2026 07:32:08 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id C1AAA40474; Fri, 16 Oct 2026 07:32:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D7411F000C4; Fri, 16 Oct 2026 07:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792135927; bh=+5JlYCPOjs2Z7BXDEhIgV/W5EOCC9AIQbjCj+aN5IlI=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=KQ5yzkFfqvb4fF6iLOu+ZeRW2yPqMHXqDHKGpAC8pfesHoohIFxC9gALXAvvHocbW yAcfI2r+pKYipStt91NbzkllCdhkrQuzTCQN2ize3Tht6T6sXO5ONQKmi9pMjTlTz6 U8R6Z3uPADGN/DsFFaw/XiWRb0HgaGLycP8cnsq7lYxz41Ziy13zxVU2BmDHD6XHLW FNrseHmeUWT6HcSpwJ87fxuS7/a+ozuCHSsyvKakrMGUL4HjtNFLL8YN2/fJSr9Iaj NxSLnz7IMRFj8qd234npOBSt00HdJxQxsA5tssaWOf7kjg+CxUPULx5VIOZrBnCTCG dVbg3eDLCz37Q== From: Maxime Ripard Date: Fri, 16 Oct 2026 09:31:35 +0200 Subject: [PATCH v5 03/14] drm/atomic: Use __GFP_ZERO instead of explicit memset in drm_atomic_get_connector_state() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261016-drm-reset-state-flag-v5-3-dad2d64b693b@kernel.org> References: <20261016-drm-reset-state-flag-v5-0-dad2d64b693b@kernel.org> In-Reply-To: <20261016-drm-reset-state-flag-v5-0-dad2d64b693b@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Louis Chauvet , Haneen Mohammed , Melissa Wen Cc: Daniel Stone , Harry Wentland , Jocelyn Falempe , =?utf-8?q?Jonas_=C3=85dahl?= , =?utf-8?q?Michel_D=C3=A4nzer?= , Pekka Paalanen , Sebastian Wick , Simon Ser , Victoria Brekenfeld , Xaver Hugl , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1611; i=mripard@kernel.org; h=from:subject:message-id; bh=Eosq4HSwlZnbxs+Sj3CugmJo42pZqa8ZJ7QvTYvOScs=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDFkXLz1y9j/BF1ScfvBT5drCu6m3C30TXnpcYd1gxbty9 1OtK2KhHVNZGIQ5GWTFFFmeyISdXt6+uMrBfuUPmDmsTCBDGLg4BWAiOScZ6xMrOK3dptvbyvAV HJ3Z+cfat7FbYuG7o/unRUx32aK3qzXdTUSz08Ejln3+otnTBUScGeu0LHS8qrY3/v3NP+flgrr 761Xepfx8vmDvEwVdB/duuaB9134ovO21NYhM/vO7KXV2khYA X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The drm_atomic_get_connector_state() function grows the connectors array with krealloc_array() when the requested connector index exceeds the current allocation, then zeroes the new entries with a separate memset() call. Since krealloc_array() supports the __GFP_ZERO flag to zero newly allocated memory, the explicit memset() is unnecessary. Pass __GFP_ZERO to krealloc_array() and drop the manual memset(). Suggested-by: Thomas Zimmermann Reviewed-by: Daniel Stone Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 43b58e9b25e4..80436adcfb7f 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -1388,18 +1388,15 @@ drm_atomic_get_connector_state(struct drm_atomic_commit *state, if (index >= state->num_connector) { struct __drm_connnectors_state *c; int alloc = max(index + 1, config->num_connector); c = krealloc_array(state->connectors, alloc, - sizeof(*state->connectors), GFP_KERNEL); + sizeof(*state->connectors), GFP_KERNEL | __GFP_ZERO); if (!c) return ERR_PTR(-ENOMEM); state->connectors = c; - memset(&state->connectors[state->num_connector], 0, - sizeof(*state->connectors) * (alloc - state->num_connector)); - state->num_connector = alloc; } connector_state = drm_atomic_get_new_connector_state(state, connector); if (connector_state) -- 2.55.0