From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,viro@zeniv.linux.org.uk,stable@vger.kernel.org,kbusch@kernel.org,hare@kernel.org,axboe@kernel.dk,4ncienth@gmail.com,akpm@linux-foundation.org
Subject: + iov_iter-validate-extracted-segment-for-bvec-alignment.patch added to mm-hotfixes-unstable branch
Date: Thu, 15 Oct 2026 18:18:16 -0700 [thread overview]
Message-ID: <20261016011817.3506B1F000C4@smtp.kernel.org> (raw)
The patch titled
Subject: iov_iter: validate extracted segment for bvec alignment
has been added to the -mm mm-hotfixes-unstable branch. Its filename is
iov_iter-validate-extracted-segment-for-bvec-alignment.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/iov_iter-validate-extracted-segment-for-bvec-alignment.patch
This patch will later appear in the mm-hotfixes-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: Daehyeon Ko <4ncienth@gmail.com>
Subject: iov_iter: validate extracted segment for bvec alignment
Date: Thu, 15 Oct 2026 15:19:07 +0900
iov_iter_extract_bvecs() validates iter_iov_addr() and iter_iov_len()
before iov_iter_extract_pages() selects the first nonempty segment and
limits it by iter->count. The checks can therefore cover a different
range after a leading empty segment or iov_iter_truncate().
An unprivileged O_DIRECT preadv() reproduced the empty-segment case: an
aligned empty segment followed by a misaligned one completed 4096 bytes
instead of returning -EINVAL. A truncated iterator has the same mismatch
when its full segment length is aligned but its remaining count is not.
This can result in a misaligned segment getting fed to the device driver,
with unknown results.
Bound the normal fast-path length by iter->count. Keep
first_iovec_segment() for leading empty segments so validation covers the
remaining portion of the segment available for extraction.
Link: https://lore.kernel.org/20261015061907.2713943-1-4ncienth@gmail.com
Fixes: 14b007e17881 ("block: validate user space vectors during extraction")
Signed-off-by: Daehyeon Ko <4ncienth@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Closes: https://lore.kernel.org/r/20261012065520.1089147-1-4ncienth@gmail.com
Assisted-by: LLM
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Keith Busch <kbusch@kernel.org>
Cc: Hannes Reinecke <hare@kernel.org>
Cc: <stable@vger.kernel.org>
---
lib/iov_iter.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
--- a/lib/iov_iter.c~iov_iter-validate-extracted-segment-for-bvec-alignment
+++ a/lib/iov_iter.c
@@ -1022,7 +1022,7 @@ static ssize_t iter_xarray_get_pages(str
return maxsize;
}
-/* must be done on non-empty ITER_UBUF or ITER_IOVEC one */
+/* must be used on a non-empty ITER_UBUF, ITER_IOVEC or ITER_KVEC */
static unsigned long first_iovec_segment(const struct iov_iter *i, size_t *size)
{
size_t skip;
@@ -1938,8 +1938,13 @@ ssize_t iov_iter_extract_bvecs(struct io
iter_is_iovec(iter) ||
iov_iter_is_kvec(iter))) {
unsigned long start = (unsigned long)iter_iov_addr(iter);
+ size_t seg_size = min(iter_iov_len(iter), iter->count);
- if ((start | iter_iov_len(iter)) & mem_align_mask)
+ if (unlikely(!seg_size && iter->count)) {
+ seg_size = iter->count;
+ start = first_iovec_segment(iter, &seg_size);
+ }
+ if ((start | seg_size) & mem_align_mask)
return -EINVAL;
} else if (iov_iter_alignment(iter) & mem_align_mask) {
return -EINVAL;
_
Patches currently in -mm which might be from 4ncienth@gmail.com are
assoc_array-discard-shortcut-when-collapsing-a-leaf-only-node.patch
iov_iter-validate-extracted-segment-for-bvec-alignment.patch
reply other threads:[~2026-10-16 1:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016011817.3506B1F000C4@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=4ncienth@gmail.com \
--cc=axboe@kernel.dk \
--cc=hare@kernel.org \
--cc=kbusch@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.