From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17D2BCC6B38 for ; Fri, 16 Oct 2026 04:12:32 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4j5Wk64Mdhz2yTH; Fri, 16 Oct 2026 15:12:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::635" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1792123950; cv=none; b=CFvuH9e1gmLmMMbFpX3a5Q8RAmf5vxi52SZGvRC89hxeXh9ah7QFGG8dpIpy5Fuh1mpI5s7vLg8KZIm3/e9UG5w8kwPy2MAPCqAiHpKdJ2ssfI4cDaOIpqCAT1pQp1K95GImNGCEVwlTVym3LtPazQRsrqnT8DN8enRf7V2Pa+1D+Q59V7eZFeH/97+BCnL992FSagXbLllCuNj5NBUaK0tg+eL2DbShckFG2BCMRaIT95c9mL4yXE8iikZEv71VxZln1a63UxtSwxkBX5aT+YqHa/h17arIc2tR95os64KKNiZbyI+q4MEXDpeeKryRW5D+eP3YYSSKfcI0wYGXtg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1792123950; c=relaxed/relaxed; bh=tCZ6GoTFAN+ex1Ct3jpbL93IWIQW5JGKx6t1S7CNuas=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D2jqaD+Dp2EyGXi56ZTXs4Qw2EsA8wVMKu43GNScChHSkueVyUtrRFKa4gKWq2Aq5kNi5PBubua/J7dQP2WVCM63OLibR8wTqmBuxtnOpyLPSCu+Udg4Je1ROZqOjpBBh4yeq28NgFRAvqhuBogxuY6Z4R4JXSPgFW/ZvBLW6ugIuuXe5Avzq06dklskbUvTYZ5K1dlwab6WKWELH8c+z/KoEMJ2r3F+vRuyN3DdqpSRgQznn4VGqf9zVcyLJMcAt7nPy8HmFCD599iUr0JtnHm3jN9rsqSuG315zVyEJDW//4lt4tzD92GW1kPRotaA754b4DUZkr0tKyqdGjVZgg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=R0snaI0Z; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::635; helo=mail-pl1-x635.google.com; envelope-from=phucduc.bui@gmail.com; receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=R0snaI0Z; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::635; helo=mail-pl1-x635.google.com; envelope-from=phucduc.bui@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4j5Wk55xF8z2ySl for ; Fri, 16 Oct 2026 15:12:29 +1100 (AEDT) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-2e987a2ba0cso2041455ad.3 for ; Thu, 15 Oct 2026 21:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792123948; x=1792728748; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tCZ6GoTFAN+ex1Ct3jpbL93IWIQW5JGKx6t1S7CNuas=; b=R0snaI0ZSUmdJTh8EdiaALhEWRoKcx8WTFcLK20u5tSuTRFlfXHHd8B6M0m6EXuEmQ GE+3t0/hi5V5Iw+cvDCw23FjGOhm/WylKbmEXn1LrqorQ9l1Xkt15sjYKOkX3e/JPqHo ETYnBIAMAjMnPTCZyMQt7zPUntdbgX67+nAzeVn7wzuY07A/s1tEPyXHBXkPMGxiUsev +AJ3e22OeJK6/E06MN20TrAFwqsPYqzANFCVXd6Frf9MDMmubhe8XnUs+GqjxpP9q9aU fA6z18TilHO9DTehuZ15Tir3Q2fterPG2Kkg1Znt0pCM7/b2G5o8tFrqpW+ycsRkaykV gkXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792123948; x=1792728748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tCZ6GoTFAN+ex1Ct3jpbL93IWIQW5JGKx6t1S7CNuas=; b=A9oxwye1V0EEpBaR22zJa5HbcVq8CYK69YXyGXJKN6ESh8gN/0NPU3ZMhJKEnL0El5 WHBrYupAk6PcGuK0mRaftsz2xiRwSvDx75UQERqcE5nxLuRzuFf3NApazj4uqSAD8KXC NywPL/3xKqapEY9RvrdudHMnOjL8ioiLULNkkmMC7x7yaB4hkVPYNd/guFW77zqvGss8 +0VXo/ExQGO7k8Q3+ojBTLcS2qe68vYsQ/KjSC7rx41a4Qemt8fEKLaN5kHVIIeaah0o +PqQ5zUES1FUsj3ri9CzmspD53UFXfhApCQjA9FdlPktcl3iSw582CQp6pZzQZVCq5qd jkSQ== X-Forwarded-Encrypted: i=1; AKwUvByafpKfhzc//XC77ES6Wp0V4T+SfCmlvN2s8rCkGkjRFsSgtS9sBerNQwq1r9AbD31Gko2DvcPKMK8iO78=@lists.ozlabs.org X-Gm-Message-State: AFq9FYL82Z9jsegD80h431Gc+0Sc5aEWjgQOUSqR+CGBEAPlhxUR8dUD baT4U//fqybLoROUrmHhGwiyH+akhghrHFLQUUFF9Ydd1gf5dBdKw0AX X-Gm-Gg: AYBFou2l9BZC8m2pQbJYBs5oUZ/w0uXJ96cp9vzbqvT2L846ftfp3CUhNqQnnlWXM8P kbJCbAxUa/0D2IlIRR+VIEo0Ji7XUbFamXtYV6H89umerebGo4B02++7XwOcHrCdzbwjaD8cn3a mGpA/pXaNqb4f7lOAWl4Gm7jPRxYUBTouwCuh17b17T2FtYEVcE2ExZekBtpG4Xc1YlEWrbLv53 YLTPi0YcHNRhAg7ob23OicpLoqAi/e1Dn0MLxNmjYGNvG0SMxvXy8GRKW4O6GpoXQwQx9mleCBr QRdfMf0utw+kW9ROCwOqPerwveENxzV2+CGeFAWNa9K+iZgNsRzAlteid1WGfuqPfl8d3LFjlXt n9wERm3WECB2o7Ggx1GBTtFyAwz6e6XB1D+B1PaL8X8407J4zP4jeOsHVomOW0uedvhrExDxWdT VNXMrQ99tRIinVUmSlFfu4XZQ/HcRl0ebcTeDvb936aAAURkksfHzqHrf7WHJKDbbezkvcmKWsb A5eSn+d3/1k/qSuTGLcqI6xVGq1lh9HiegRzWdGVwQ/MhyXvB2S411/LK9SgYOjW9jMQnZVCYFM feRnPhHhBzATRA== X-Received: by 2002:a17:903:94e:b0:2e9:4243:431d with SMTP id d9443c01a7336-2e942434bd5mr63920435ad.30.1792123947778; Thu, 15 Oct 2026 21:12:27 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e97e8ab443sm3815785ad.65.2026.10.15.21.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 21:12:27 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 11/11] ASoC: rockchip: Explain DAI link startup return value handling Date: Fri, 16 Oct 2026 11:09:46 +0700 Message-ID: <20261016040946.521195-12-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016040946.521195-1-phucduc.bui@gmail.com> References: <20261016040946.521195-1-phucduc.bui@gmail.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Add comments explaining why the .startup() callbacks must return 0 on success to ensure the DAI link is correctly marked as started and prevent future changes from reintroducing the issue. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rk3399_gru_sound.c | 5 +++++ sound/soc/rockchip/rockchip_max98090.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c index 0ec80a4b8c59..d4a0daabfb42 100644 --- a/sound/soc/rockchip/rk3399_gru_sound.c +++ b/sound/soc/rockchip/rk3399_gru_sound.c @@ -266,6 +266,11 @@ static int rockchip_sound_startup(struct snd_pcm_substream *substream) if (ret < 0) return ret; + /* + * ASoC only marks the DAI link as started when .startup() returns 0. + * Since snd_pcm_hw_constraint_minmax() may return 1, explicitly + * return 0 to ensure the DAI link is correctly marked as started. + */ return 0; } diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip/rockchip_max98090.c index d54c36682415..de392b420ebd 100644 --- a/sound/soc/rockchip/rockchip_max98090.c +++ b/sound/soc/rockchip/rockchip_max98090.c @@ -202,6 +202,11 @@ static int rk_aif1_startup(struct snd_pcm_substream *substream) if (ret < 0) return ret; + /* + * ASoC only marks the DAI link as started when .startup() returns 0. + * Since snd_pcm_hw_constraint_minmax() may return 1, explicitly + * return 0 to ensure the DAI link is correctly marked as started. + */ return 0; } -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7865FCC6B2D for ; Fri, 16 Oct 2026 04:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u3zjrDnJC+PnSA4y4+eJWl4AioMAR2LL7Cg0tAmE41w=; b=fRTHO3Ni6jti39 B+9wV6f8Iy1ZnJqkT8q4QVr6fE9pCDhHpSoi5jj4KAFkIBY9pFf0/UMxaXx0IDlIxC9zzy3j6qyNO vCpSm14fSsYvEGvR3wzCDMoW0PYW7G/iNnoPHZLp5eq7dcJV+3Mi5n/AR8xd83jeIcMpoN6dSBFWk /it4isWV2VffGAcYMVdIU/BevsxaSvmQwx32IP7/+Z+YRhw6Bqpb0fg4s/gQyzbBwWN4Y0xxC/9d5 NIp/M0ApNKKthD5X4hA3+/aUPkdPjxDAghDqBzUeSSUHvg0POGBWFK6qtfJU29UrbE6C0clg2NWOY eAHIr9SY1oKXZKXlPThw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHZJ1-00000001xC5-2IKl; Fri, 16 Oct 2026 04:12:31 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHZIy-00000001xBK-3jx2 for linux-rockchip@lists.infradead.org; Fri, 16 Oct 2026 04:12:29 +0000 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-2e987a2ba0cso2041445ad.3 for ; Thu, 15 Oct 2026 21:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792123948; x=1792728748; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tCZ6GoTFAN+ex1Ct3jpbL93IWIQW5JGKx6t1S7CNuas=; b=qZclJIhgQNgNlLi+28gW251qdd5XWPeclT1TrTMrmoz+J+2+7h2lwpq/dImSzPqhBG j1z6VOxqZRwsI1HEMWFJP3epU0PFfZkUkWwrTW5hG6OA/TK3QncY8/iQi8KVfK2DkNN6 Ma7r2HMnvnm8Z1gggPvktsrbQX8o6kLff279r7Kr6dkBKPkIj1Vm4e9wqDrwbzY2xFX7 jOdJAvt/7Hqrv3cHJK8NSfzHuKYLfB83geUmEsaMxGRDIEoEtPT416lpRqGb1IcdEfGZ /V7K0qFNlVNNr17/Ko7FkceO9QUKa3YHBU38VtHItF8ik/6A2hf0rJ0lZO7gHa2gTZgL OmsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792123948; x=1792728748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tCZ6GoTFAN+ex1Ct3jpbL93IWIQW5JGKx6t1S7CNuas=; b=bDNh6hHmFdq0kWcRR3Z2NenByLh/vsATyjGVG8scJdH/kiMHgbEIFXmt+k7Xjorxj+ a1biqpQzXMzHDrMTJbEvqJWsRJLNA5pMUwWPr4f74tpU+oOrG0VbCr6EHyNuV1qgULpM xdOHpqrzfh+xQkXr3QL7BTXAzr/UExJ52cLs0YRpdUymi3lov/5/S4W2+nwC0Zd/biRc ScRAyZGU90JvqVC5PQazHlA82TaJsNFunOYb3esmjh8YhjBtwNRBdYCZHR2heMAnFmPK UfZT2l8djDAPqU7/LKHFaB+qnqP7As2zEmXnv34IxZOHizM6pP+dqEX0+Wymo4xVK2zn nKLg== X-Forwarded-Encrypted: i=1; AKwUvBzpM/6eezhAkIb9i95Utt10Ht6JSeejIoKKmzXNq4a6sx0eMKRdnC4qCBYMMysj28Ct1l+xXcyW1BRP/4yH1Q==@lists.infradead.org X-Gm-Message-State: AFq9FYIQiruUMdOiD4jM/Us/fsfX9I196TjoGHxK4wKJo7OXC3hUlnOo pwEcYz3/4XDSW+AftpDzmX7agVjAD0omIS7EPqiW36JBem7hNHSFqX1Z X-Gm-Gg: AYBFou0obygIUCS/Bx0MVM703JeHC9fxJuyjw83Y5FTcVE3U6VQNiM0T9W1lusCmjrO YP3nRW3T6B78F8znHWXgeFrpnNK2vX+oxzHOixPjy6PrHVF+G47re7TuYCTD7gMYIM16hCrhKDV A1ZQSiQrTG2+ieFIiI2uG3TVrYNx36E6NcobEDQqhqHrT4sOpPH1HSsPuDxZdQrYKNYjbIc23Ck Q3uNCd2+6n3VQnEeC2MiT5ylMELNQmDHTSA93PaTXWip8ee/FgdGryxnPnM5Do4mEuuITC1LFXa U7t0pThEGgsnXuZvW+F+tWoxdRoi2nVLiOtdDXdZvnpCxUby1H46kZOWtHXMYGDed4kWPnuKHA5 BIiMR1PRDVnmXNrLax9wPnkc3rH8hvOfzKHBwnQwHqFmpD0puTo3MT9YhSFw1ceiDIQRGS0lgbd GEVMYyQxzTVjo6hrtf+1DbIXrH6YlyZtfh6u7eSlkhVjGAu2xohS4BRciST8BZmRNYko63CAUQ1 tyW/FS2wScce9GpwLLi7lkQACtRivuaV+pNkI3masW1dMksTO/l7PZcasfqRlnW9cKIdBbKBmVB YnZGKOIcyj3Ohg== X-Received: by 2002:a17:903:94e:b0:2e9:4243:431d with SMTP id d9443c01a7336-2e942434bd5mr63920435ad.30.1792123947778; Thu, 15 Oct 2026 21:12:27 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e97e8ab443sm3815785ad.65.2026.10.15.21.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 21:12:27 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Subject: [PATCH 11/11] ASoC: rockchip: Explain DAI link startup return value handling Date: Fri, 16 Oct 2026 11:09:46 +0700 Message-ID: <20261016040946.521195-12-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016040946.521195-1-phucduc.bui@gmail.com> References: <20261016040946.521195-1-phucduc.bui@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261015_211228_933904_B52915E8 X-CRM114-Status: UNSURE ( 9.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, wangdicheng , Kees Cook , Sang-Heon Jeon , Pengpeng Hou , Bo Shen , Neo Chang , linux-rockchip@lists.infradead.org, bui duc phuc , Chris Bainbridge , Charles Keepax , linux-sound@vger.kernel.org, u.kleine-koenig@baylibre.com, Zain Aboobacker , Bjorn Helgaas , Md Shofiqul Islam , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , patches@opensource.cirrus.com, Linus Walleij , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Vinod Koul , asahi@lists.linux.dev, Hemanth Selam , linuxppc-dev@lists.ozlabs.org, Syed Saba Kareem Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: bui duc phuc Add comments explaining why the .startup() callbacks must return 0 on success to ensure the DAI link is correctly marked as started and prevent future changes from reintroducing the issue. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rk3399_gru_sound.c | 5 +++++ sound/soc/rockchip/rockchip_max98090.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c index 0ec80a4b8c59..d4a0daabfb42 100644 --- a/sound/soc/rockchip/rk3399_gru_sound.c +++ b/sound/soc/rockchip/rk3399_gru_sound.c @@ -266,6 +266,11 @@ static int rockchip_sound_startup(struct snd_pcm_substream *substream) if (ret < 0) return ret; + /* + * ASoC only marks the DAI link as started when .startup() returns 0. + * Since snd_pcm_hw_constraint_minmax() may return 1, explicitly + * return 0 to ensure the DAI link is correctly marked as started. + */ return 0; } diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip/rockchip_max98090.c index d54c36682415..de392b420ebd 100644 --- a/sound/soc/rockchip/rockchip_max98090.c +++ b/sound/soc/rockchip/rockchip_max98090.c @@ -202,6 +202,11 @@ static int rk_aif1_startup(struct snd_pcm_substream *substream) if (ret < 0) return ret; + /* + * ASoC only marks the DAI link as started when .startup() returns 0. + * Since snd_pcm_hw_constraint_minmax() may return 1, explicitly + * return 0 to ensure the DAI link is correctly marked as started. + */ return 0; } -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip