From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 590C13E5A2F for ; Fri, 16 Oct 2026 08:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792138032; cv=none; b=q92q+wbNGeNT1MPmzczq8mJ3cUTmltcCknkISzmb4bKR1QQUT6fOGB+18AK1p6s4XZZ65ZmIalVNYzGTkNxs8quU9y9EDlB7ZGPZl41T0vIAQB2UMozjsR/lZKkIle9Ij2MJZO+CUx5iAfsanAeaU5Zr+/E3QN+Z3m0J4Lgm2xo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792138032; c=relaxed/simple; bh=LZZj8EbkJxePHcJk6g7+hXx3EPc2QneIFCk15fTpCcE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=c+Y04wGkPlYsv6d+lrQhMCyAEU65HL/ggsC6RXervA++qSIy20go1ASJ/CJO8i3s4r7ORKs7fjZxesOoSmDKQj7Dy1VFvHNr44EWXhAvdJCmv986++Sdl6H6ZEYeUe2a9rfaNECSTlSElHa3Y81gExV7skrNsrdC9JU6SVnG5Wg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jiWsvQYS; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jiWsvQYS" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-49e73611928so4382005e9.1 for ; Fri, 16 Oct 2026 01:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792138029; x=1792742829; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=j3s7Y3rGbVQHjeQTGR22MPi3o+zLfgdO+VLKMqYAthE=; b=jiWsvQYShhF1RCEkGK+Jt03icI+0SY8Z3+GWoswmVjwiXAmbUvyjW+Am9OfTb/Z18Z 93ad0wjZ9EFf2GiMb3MIYYAOMAhSjN4e4s6Ij8FZyK1YDz5t5vwC6dm+XkxJ0lb+G8MJ +EnFz+VgbYDrVBnAwbiMSi8QgywgbzqHprbXk41da7kS6fKQx+1dKEOTXK292tyISPAS PwG05aTert/xwsXgLuTYOtqKkrb8ZE+JDl2Xp4t08IHxS4f4eTrYNAGIQCsGZMdKglzG Za8EZ2OKLlpwSsNUKEZ5y/blupofEecf73lYMrwh6EaebcBqQywygnPk18+DySSEsHJC SR/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792138029; x=1792742829; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=j3s7Y3rGbVQHjeQTGR22MPi3o+zLfgdO+VLKMqYAthE=; b=xVF+RpPheOnTDZWLxcK6ozxDrRRz3n7N3IcChSYdvSzKPDLkUcEVzyHq9heDcuWsyM GW5c02rlT8yTSLfkTnZMuKWrQ5qwRPTFO1OXs3PiMm4S2oSSYK+LmmD8Gq0pdlktdC1D mw27bWPTuf+2ejjz6lhIQuoN9CATKntcmOUtDjPs9PSjCb8Ex0pvafVi7evh45KvfzEW ZLXcrR+PYqaYxiIaUBiSSwEak23tqu1k37nQ1gmtCYpfPvFQzZfpwkMUvljIchwkCYyo lvn99sqd8QTRVDThYrXVZ9Dvn8Q9sEZbiiQryqhmt/uZl+aEkukSdcqVA4J4jl9S+Y/i gsqA== X-Forwarded-Encrypted: i=1; AKwUvBw1YbCxeoXvT2iYcqcdLvXnl+Ab5t0iF0nc+RrHuD70PZBe3R7LVSnQGqhFdgPnCL3PC6gEH/cfQ8o=@vger.kernel.org X-Gm-Message-State: AFq9FYKcLXMwa9h7nsDDmDet0gZODVx3twk9XXDl3IFHlpECSm7L7+U2 OwvRq3iv3I/k+rOXaaOJDUN6nGbgackvQJ1JcUVamckke66h8vLBTjx3 X-Gm-Gg: AYBFou1QGOAinb4QWzVgtCfS0avwHideofi38xlF9wC++1bphN53xBglogPyo/9fhDc 7ucewa/IATt+SsB3ACoebU1bl1FqVrGbB48GqCiZgL2U8OrJmBAp5Bt3jE3nYX224MM9Zr0haOn jdF9uO/mS2AfM/Stu7+O4FaueYBy/0ogLdz00cJTCxmtGaWI+D9ttcNxXuoCyJgNxNDrrzG5X3Q dKNa7DxyjuHs6XtTB4qdunghq5BV6nJB2CkkYeqWJ8NCSo8dEJbVS4/JJt6Hb+h52ZahasYeWz7 Rab6fYcBE04ckeLh3XuJIp8hylSqXQ7eD5n0YCS5/EYMCiB+yM4rcdyBkMbAH0IIJYfBp6E24CE 6iwp/0cf/cTK1He8q0nIIcEsaPjcoJoGTFss4TXII9t5qED3+MUYfEy7nEjhG+StbTfaYt1F7Ne NyNMG9H1YUe8ZxtGI9bazokR/e1DXMFmwf6AFetqOsZ6BZXmo/dtXie1nm4ycR5a2GRTuxDk18y 7J2sKrWVy5BjC3EVLcpN/O2vqWuRatzUiXzjzASW9nuHeYl0YiypSlmVrN3XKxfiK6bqVE99DKZ 2oMuwfs+JALHDIvPFdlU1YiMBzkPgRrFRPk5Ne66TQ== X-Received: by 2002:a05:600c:2154:b0:4a1:ac66:604b with SMTP id 5b1f17b1804b1-4a1c6635d20mr38433285e9.1.1792138029035; Fri, 16 Oct 2026 01:07:09 -0700 (PDT) Received: from cachyos.tailab2f6.ts.net ([217.180.53.138]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a1c91c68b4sm17340125e9.1.2026.10.16.01.07.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 01:07:08 -0700 (PDT) From: Chaz Bailey To: Heikki Krogerus , Greg Kroah-Hartman Cc: Dmitry Baryshkov , linux-usb@vger.kernel.org, stable@vger.kernel.org, Chaz Bailey Subject: [PATCH] usb: typec: nb7vpq904m: Set client data in probe to avoid crash on remove Date: Fri, 16 Oct 2026 09:05:17 +0100 Message-ID: <20261016080517.156248-1-charles.s.bailey@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit nb7vpq904m_probe() allocates struct nb7vpq904m but neglects to call i2c_set_clientdata(client, nb7). In nb7vpq904m_remove(), i2c_get_clientdata(client) returns NULL, leading to a NULL pointer dereference when accessing nb7->retimer or nb7->sw. Set client data upon successful allocation in probe. Fixes: 88d8f3ac9c67 ("usb: typec: add support for the nb7vpq904m Type-C Linear Redriver") Cc: stable@vger.kernel.org Signed-off-by: Chaz Bailey --- drivers/usb/typec/mux/nb7vpq904m.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/typec/mux/nb7vpq904m.c b/drivers/usb/typec/mux/nb7vpq904m.c index d1fa26ff44..52e3c9db35 100644 --- a/drivers/usb/typec/mux/nb7vpq904m.c +++ b/drivers/usb/typec/mux/nb7vpq904m.c @@ -396,6 +396,7 @@ static int nb7vpq904m_probe(struct i2c_client *client) return -ENOMEM; nb7->client = client; + i2c_set_clientdata(client, nb7); nb7->regmap = devm_regmap_init_i2c(client, &nb7_regmap); if (IS_ERR(nb7->regmap)) { -- 2.55.0