From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCB7FCCA462 for ; Fri, 16 Oct 2026 09:44:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xHeUD-00017J-6K; Fri, 16 Oct 2026 05:44:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHeTu-0000xQ-4K for qemu-devel@nongnu.org; Fri, 16 Oct 2026 05:44:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHeTs-0007Ki-8H for qemu-devel@nongnu.org; Fri, 16 Oct 2026 05:44:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792143842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ivfnCDvhT9JT3JpGJzLa6a8hUIXgO0RkZN6sYAk2Pq4=; b=fb4AFWTdfhHoBeFwhNeypVTA6WqrUT/dtYDRgQ4MeOBSalQ5wweW9pkHvGKYrXB5/ANozC OYxFOPYXfJ8ulGnd/ct/iqah1P7ivVl6yYtpJBHmKnuOsCnoqnlDh61cyCh11/abu4Fb+c 1I/yh63m7Ko94/8Nnnag0u26Y+DhhcM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-ONpOchyOMA-S2ce-8S7lnw-1; Fri, 16 Oct 2026 09:43:59 +0000 X-MC-Unique: ONpOchyOMA-S2ce-8S7lnw-1 X-Mimecast-MFC-AGG-ID: ONpOchyOMA-S2ce-8S7lnw_1792143838 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7DF3F1955BDF; Fri, 16 Oct 2026 09:43:58 +0000 (UTC) Received: from berrange.csb (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 113DF3000B78; Fri, 16 Oct 2026 09:43:56 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 4/8] qom: deprecate use of instance level properties Date: Fri, 16 Oct 2026 10:43:44 +0100 Message-ID: <20261016094348.2616374-5-berrange@redhat.com> In-Reply-To: <20261016094348.2616374-1-berrange@redhat.com> References: <20261016094348.2616374-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Add API docs to object_property_(add/try_add/del) to recommend use of class properties instead. Reviewed-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- include/qom/object.h | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index 4c0645817a5..90c1a34e49a 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -1171,6 +1171,16 @@ void object_unref(void *obj); * @opaque: an opaque pointer to pass to the callbacks for the property * @errp: pointer to error object * + * Further use of this method is deprecated. Properties for an + * object should be statically declared against the class, and + * not be permitted to vary at runtime. Use the + * object_class_property_add() method (and its variants) instead. + * + * If usage scenarios require differing subsets of properties + * to be present, this should be handled by creating further + * specialized subclasses instead of dynamically registering + * properties against instances. + * * Returns: The #ObjectProperty; this can be used to set the @resolve * callback for child and link properties. */ @@ -1183,9 +1193,6 @@ ObjectProperty *object_property_try_add(Object *obj, const char *name, /** * object_property_add: - * Same as object_property_try_add() with @errp hardcoded to - * &error_abort. - * * @obj: the object to add a property to * @name: the name of the property. This can contain any character except for * a forward slash. In general, you should use hyphens '-' instead of @@ -1202,6 +1209,12 @@ ObjectProperty *object_property_try_add(Object *obj, const char *name, * meant to allow a property to free its opaque upon object * destruction. This may be NULL. * @opaque: an opaque pointer to pass to the callbacks for the property + * + * Same as object_property_try_add() with @errp hardcoded to + * &error_abort. + * + * Further use of this method is deprecated, see + * object_property_try_add() for details. */ ObjectProperty *object_property_add(Object *obj, const char *name, const char *type, @@ -1210,6 +1223,14 @@ ObjectProperty *object_property_add(Object *obj, const char *name, ObjectPropertyRelease *release, void *opaque); +/** + * object_property_del: + * @obj: the object to remove a property from + * @name: the property to be deleted + * + * Further use of this method is deprecated, see + * object_property_try_add() for details. + */ void object_property_del(Object *obj, const char *name); ObjectProperty *object_class_property_add(ObjectClass *klass, const char *name, -- 2.56.0