From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 635B7CCF2C1 for ; Fri, 16 Oct 2026 14:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MXys7ckdfZsaSqIv9WG3c/zyDXcn3l1gqjz0lpcesqU=; b=ggz8/GdGs6uGXYqE1MerEZxwn9 ddQOiBSg6vLGs0lqTxVt4DOpLOfFRBORez560M0crCqJo+B8W1UkIJzkcOhFpHkSZhEtArcSqc4OM yPm/pvLuLbAIsxlnwp3DyvmF0VVuKY40po7ZVXCALRbEuQdlYY8p4RfAeKRvR7ij+lzgapcI5n5SS s4tO5dd6IP2oljyRWvj36AQE1DpZIDSuNIdCf7YdoWA+Qw5bCNbZxW/OeVZd9lh8pf8pC07gavael 011sro81EgtgfFBaPJE2pLgBuAyFx286lgCMY6p4cXa50fBD+Vnm0BAkp+DMGmbbZ31xyx6Id8ByN tnIQpHNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHiUo-000000035j3-0kml; Fri, 16 Oct 2026 14:01:18 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHiUm-000000035ie-3MHv; Fri, 16 Oct 2026 14:01:16 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 53AE643BD0; Fri, 16 Oct 2026 14:01:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12F121F000C4; Fri, 16 Oct 2026 14:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792159276; bh=MXys7ckdfZsaSqIv9WG3c/zyDXcn3l1gqjz0lpcesqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=HZkt9gnOetdK3cwJqZfyf/TaDWY69f6OurRre/WUGRspavzKJHxiM/DA5SgOexPGZ QRM4nwBBkDe3HPz4PednxZVmccKXPcMmcWatazO0SKDJDa37pAdak66NbQF9qef0Gp yAYJXMbhivsxdxsLds6zAp+mpjn3GRmPgcnNO5gac331CmQc+6oawJiflBx2SB0HE+ 1plY9j94/R430Bpu1i86kczeeRrqHuWJ2xQgnmN9rq8jxFkZn/kV/q4FI4QhnA2E0j HpTDYraqKa0RFdHemRUoFCYHwKgOrMevxLyB4fhP03tZTli8/Hpvv6p27NSZwNkyZv Pj6kQhag62uWg== Date: Fri, 16 Oct 2026 09:01:15 -0500 From: Rob Herring To: Jason Yang Cc: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Guochun Huang , Philipp Zabel , Michael Riesch , Sebastian Reichel , Bryan O'Donoghue , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/8] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: Add a cell to select TX or RX Message-ID: <20261016140115.GA1798470-robh@kernel.org> References: <20261016-dcphy-rx-v1-v5-0-e63b49eabe2d@gmail.com> <20261016-dcphy-rx-v1-v5-2-e63b49eabe2d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261016-dcphy-rx-v1-v5-2-e63b49eabe2d@gmail.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 16, 2026 at 04:56:36PM +0800, Jason Yang wrote: > The Samsung MIPI D-/C-PHY block on RK3588 and RK3576 has a transmitter > for DSI and a receiver for CSI-2, and two consumers can use them at the > same time. The single cell of this binding selects the mode and refers > to the transmitter, so the receiver cannot be described. > > Allow a second cell that selects the transmitter or the receiver. With > D-PHY: > > /* the MIPI DSI host, driving the transmitter */ > phys = <&mipidcphy0 PHY_TYPE_DPHY PHY_DIRECTION_TX>; > > /* the MIPI CSI-2 host, driving the receiver */ > phys = <&mipidcphy0 PHY_TYPE_DPHY PHY_DIRECTION_RX>; > > and with C-PHY: > > phys = <&mipidcphy0 PHY_TYPE_CPHY PHY_DIRECTION_TX>; > phys = <&mipidcphy0 PHY_TYPE_CPHY PHY_DIRECTION_RX>; > > The transmitter and the receiver cannot operate in different modes [1], > so the first cell must match in both consumers. > > Two cells describe the receiver as well. A single cell keeps referring > to the transmitter, so existing device trees are unaffected. > > [1] RK3588 TRM: section 22.1 (overview): "The TX and RX only support > operate in the same PHY mode." The problem here is this is an ABI break. An existing OS will not know what to do with 2 cells. Perhaps adding flags to the upper bits of the existing cell would work. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 649EBCCA462 for ; Fri, 16 Oct 2026 14:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ts+RtcmAMpbQfP1amo3SjLwN5EHMy9c8/SzDsjfwKKw=; b=gOWPX+6f0JPxfe JIWGOkkev989ZYZFBqo4t2YOz//+LUfgXo2CsVLa4ElkVwD4lNEORbIUjefCZwOtAKp+MzCuUd9M+ T/DbsYSxzUcTl8VKNrX7vrJyTEABsRFALjsWZ2Vyooda4PSK+H21SB9sD1tuBIYqDCTnJdVPUL55i gIK8TdRUoknJGbT+njvOzDHslunJmHa4nzSDP3KAnyxFoKiB/RNrE2qDCkwKJcNVavidPs+95tqNj wJpf+ptlZ4eGbmrTBrKCl6HxQBE2JAHV3iEK99+baj6VzU0uco1XSk967xhx/TY1YcXxwHu/0i1U4 ElCSkXbXjM95GzhsaJUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHiUo-000000035jR-1eEW; Fri, 16 Oct 2026 14:01:18 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHiUm-000000035ie-3MHv; Fri, 16 Oct 2026 14:01:16 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 53AE643BD0; Fri, 16 Oct 2026 14:01:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12F121F000C4; Fri, 16 Oct 2026 14:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792159276; bh=MXys7ckdfZsaSqIv9WG3c/zyDXcn3l1gqjz0lpcesqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=HZkt9gnOetdK3cwJqZfyf/TaDWY69f6OurRre/WUGRspavzKJHxiM/DA5SgOexPGZ QRM4nwBBkDe3HPz4PednxZVmccKXPcMmcWatazO0SKDJDa37pAdak66NbQF9qef0Gp yAYJXMbhivsxdxsLds6zAp+mpjn3GRmPgcnNO5gac331CmQc+6oawJiflBx2SB0HE+ 1plY9j94/R430Bpu1i86kczeeRrqHuWJ2xQgnmN9rq8jxFkZn/kV/q4FI4QhnA2E0j HpTDYraqKa0RFdHemRUoFCYHwKgOrMevxLyB4fhP03tZTli8/Hpvv6p27NSZwNkyZv Pj6kQhag62uWg== Date: Fri, 16 Oct 2026 09:01:15 -0500 From: Rob Herring To: Jason Yang Cc: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Guochun Huang , Philipp Zabel , Michael Riesch , Sebastian Reichel , Bryan O'Donoghue , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/8] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: Add a cell to select TX or RX Message-ID: <20261016140115.GA1798470-robh@kernel.org> References: <20261016-dcphy-rx-v1-v5-0-e63b49eabe2d@gmail.com> <20261016-dcphy-rx-v1-v5-2-e63b49eabe2d@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261016-dcphy-rx-v1-v5-2-e63b49eabe2d@gmail.com> X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, Oct 16, 2026 at 04:56:36PM +0800, Jason Yang wrote: > The Samsung MIPI D-/C-PHY block on RK3588 and RK3576 has a transmitter > for DSI and a receiver for CSI-2, and two consumers can use them at the > same time. The single cell of this binding selects the mode and refers > to the transmitter, so the receiver cannot be described. > > Allow a second cell that selects the transmitter or the receiver. With > D-PHY: > > /* the MIPI DSI host, driving the transmitter */ > phys = <&mipidcphy0 PHY_TYPE_DPHY PHY_DIRECTION_TX>; > > /* the MIPI CSI-2 host, driving the receiver */ > phys = <&mipidcphy0 PHY_TYPE_DPHY PHY_DIRECTION_RX>; > > and with C-PHY: > > phys = <&mipidcphy0 PHY_TYPE_CPHY PHY_DIRECTION_TX>; > phys = <&mipidcphy0 PHY_TYPE_CPHY PHY_DIRECTION_RX>; > > The transmitter and the receiver cannot operate in different modes [1], > so the first cell must match in both consumers. > > Two cells describe the receiver as well. A single cell keeps referring > to the transmitter, so existing device trees are unaffected. > > [1] RK3588 TRM: section 22.1 (overview): "The TX and RX only support > operate in the same PHY mode." The problem here is this is an ABI break. An existing OS will not know what to do with 2 cells. Perhaps adding flags to the upper bits of the existing cell would work. Rob _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA56CCCF2C2 for ; Fri, 16 Oct 2026 14:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6v3XNZ3UFluZNume8ukjKZgNqFTHfOOksSrqWmW1www=; b=RN7W9X+VeoECfB GntPFbB2qxLQTIcpt0p3gm3NG9wz8bVs61JjF4dvVqkrBbB6tSpSkyhcCDDrakU0OIjQ4OhLBLdfB H7LEEANgPEdkijqPH9vMsrEefF3cR0ZNaX43cYZDeIjN/2Ejox95j1F5YsGBNEWTK879ixSxbX5Yv ZYLj6jCoFbzex8jD7A6MBRvd6KIKnO5O3Wh+mLjUjhscfPLXhGT1Tn0x5tNUO2c892CS1mxnVT33P pM5aTeu222WrDFGxSzfEe32tmS9PnLvT1ESGaG15GBDv3hd5Y8Hz36OAkrE6ZCTxS4ROUDW3MkD7n PGkVcH0GoVydEEMXQ2Ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHiUo-000000035jL-1FiB; Fri, 16 Oct 2026 14:01:18 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHiUm-000000035ie-3MHv; Fri, 16 Oct 2026 14:01:16 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 53AE643BD0; Fri, 16 Oct 2026 14:01:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12F121F000C4; Fri, 16 Oct 2026 14:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792159276; bh=MXys7ckdfZsaSqIv9WG3c/zyDXcn3l1gqjz0lpcesqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=HZkt9gnOetdK3cwJqZfyf/TaDWY69f6OurRre/WUGRspavzKJHxiM/DA5SgOexPGZ QRM4nwBBkDe3HPz4PednxZVmccKXPcMmcWatazO0SKDJDa37pAdak66NbQF9qef0Gp yAYJXMbhivsxdxsLds6zAp+mpjn3GRmPgcnNO5gac331CmQc+6oawJiflBx2SB0HE+ 1plY9j94/R430Bpu1i86kczeeRrqHuWJ2xQgnmN9rq8jxFkZn/kV/q4FI4QhnA2E0j HpTDYraqKa0RFdHemRUoFCYHwKgOrMevxLyB4fhP03tZTli8/Hpvv6p27NSZwNkyZv Pj6kQhag62uWg== Date: Fri, 16 Oct 2026 09:01:15 -0500 From: Rob Herring To: Jason Yang Cc: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Guochun Huang , Philipp Zabel , Michael Riesch , Sebastian Reichel , Bryan O'Donoghue , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/8] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: Add a cell to select TX or RX Message-ID: <20261016140115.GA1798470-robh@kernel.org> References: <20261016-dcphy-rx-v1-v5-0-e63b49eabe2d@gmail.com> <20261016-dcphy-rx-v1-v5-2-e63b49eabe2d@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261016-dcphy-rx-v1-v5-2-e63b49eabe2d@gmail.com> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Fri, Oct 16, 2026 at 04:56:36PM +0800, Jason Yang wrote: > The Samsung MIPI D-/C-PHY block on RK3588 and RK3576 has a transmitter > for DSI and a receiver for CSI-2, and two consumers can use them at the > same time. The single cell of this binding selects the mode and refers > to the transmitter, so the receiver cannot be described. > > Allow a second cell that selects the transmitter or the receiver. With > D-PHY: > > /* the MIPI DSI host, driving the transmitter */ > phys = <&mipidcphy0 PHY_TYPE_DPHY PHY_DIRECTION_TX>; > > /* the MIPI CSI-2 host, driving the receiver */ > phys = <&mipidcphy0 PHY_TYPE_DPHY PHY_DIRECTION_RX>; > > and with C-PHY: > > phys = <&mipidcphy0 PHY_TYPE_CPHY PHY_DIRECTION_TX>; > phys = <&mipidcphy0 PHY_TYPE_CPHY PHY_DIRECTION_RX>; > > The transmitter and the receiver cannot operate in different modes [1], > so the first cell must match in both consumers. > > Two cells describe the receiver as well. A single cell keeps referring > to the transmitter, so existing device trees are unaffected. > > [1] RK3588 TRM: section 22.1 (overview): "The TX and RX only support > operate in the same PHY mode." The problem here is this is an ABI break. An existing OS will not know what to do with 2 cells. Perhaps adding flags to the upper bits of the existing cell would work. Rob -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy