Re: [PATCH v2 1/3] virtio: rtc: Add virtio RTC driver

[Hung-Chun Tseng <alan.tseng.cs@gmail.com>]

Hi Kuan-Wei,

On Thu, Oct 15, 2026 at 03:46:03AM +0800, Kuan-Wei Chiu wrote:
> Actually, when I sent out the qemu virtio-rtc code, I also had a local
> dirty version of the virtio-rtc u-boot driver, but it has been sitting
> on my TODO list. I might take a closer look at this patch in a day or
> two.

Thanks for taking a look, and for the QEMU device that made this easy
to test. If your local version handles something mine doesn't, I'm
happy to fold it in.

> I would suggest leaving more time between sending out new patch
> versions to give people a chance to review and reply, which helps avoid
> spamming the list with rapid revisions.

Understood, sorry about that. I'll hold v3 until you and others have
had time to go through v2.

> IIRC, when I sent out the virtio-9p driver for review, Simon made the
> same suggestion to add a timeout mechanism to the loop here to prevent
> potential hangs.

Good point. For v3 I have the loop bounded with get_timer(), giving up
with -ETIMEDOUT after one second, as virtio_9p does.

For your comments on 2/3, v3 also turns the device types into a
bulleted list and retitles the patch to "doc: virtio: List the
supported device types".

Thanks,
Hung-Chun