From: Jakub Kicinski <kuba@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: acassen@corp.free.fr, jhs@mojatatu.com, jiri@resnulli.us,
davem@davemloft.net, edumazet@kernel.org, pabeni@redhat.com,
horms@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net/sched: act_tunnel_key: skip dst cache for skip_sw actions
Date: Fri, 16 Oct 2026 17:30:25 -0700 [thread overview]
Message-ID: <20261016173025.2a25da8e@kernel.org> (raw)
In-Reply-To: <179161061150.434549.17402573349623469379@kernel.org>
On Sat, 10 Oct 2026 05:36:51 +0000 netdev-bot+sashiko@kernel.org wrote:
> Could the filter's skip_sw reach ->init()? One way would be to OR
> TCA_ACT_FLAGS_SKIP_SW into the flags given to tcf_action_init_1() when
> tc_skip_sw(fl_flags) is set. Otherwise, could the commit message mention
> this limit?
>
> The commit message also doesn't say why the change is wanted (presumably
> to save per-CPU memory). Could that be added?
Both asks seem reasonable, and I think you fixed the issue from patch 1
already so a repost will also clear it up.
--
pw-bot: cr
next prev parent reply other threads:[~2026-10-17 0:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 5:19 [PATCH net-next 0/2] net/sched: let hardware only actions drop per CPU stats Alexandre Cassen
2026-10-09 5:19 ` [PATCH net-next 1/2] net/sched: honor TCA_ACT_FLAGS_NO_PERCPU_STATS in more actions Alexandre Cassen
2026-10-10 5:36 ` netdev-bot+sashiko
2026-10-09 5:19 ` [PATCH net-next 2/2] net/sched: act_tunnel_key: skip dst cache for skip_sw actions Alexandre Cassen
2026-10-10 5:36 ` netdev-bot+sashiko
2026-10-17 0:30 ` Jakub Kicinski [this message]
2026-10-09 9:25 ` [PATCH net-next 0/2] net/sched: let hardware only actions drop per CPU stats Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016173025.2a25da8e@kernel.org \
--to=kuba@kernel.org \
--cc=acassen@corp.free.fr \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.