From: Simon Horman <horms@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, davem@davemloft.net,
edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
jiri@resnulli.us, bpf@vger.kernel.org, victor@mojatatu.com
Subject: Re: [PATCH net v2 3/3] selftests: net: exercise dev-bound cls_bpf on shared blocks
Date: Fri, 16 Oct 2026 19:23:25 +0100 [thread overview]
Message-ID: <20261016182325.GM363352@horms.kernel.org> (raw)
In-Reply-To: <QDISC-PYC7.v2.20261010165947-4@mojatatu.com>
On Sat, Oct 10, 2026 at 05:02:50PM -0400, Jamal Hadi Salim wrote:
> The issue:
> bpf_offload.py only exercises per-device ingress qdiscs today, so neither
> the shared-block accept path nor the late-join replay is tested.
>
> The Fix:
> Add a test for a device-bound SCHED_CLS program attached through a shared
> block. It loads a dev-bound SCHED_CLS program for a netdevsim device and
> checks:
> - the program attaches to a shared block owned by its device, and the
> filter teardown leaves the device unloaded;
> - a block that also holds an independently backed device rejects the
> attach, because the offload path broadcasts the program to all
> members;
> - an independently backed device that joins a populated block is not
> loaded by the bind/replay path, and the driver's extack is asserted;
> - a second port of the same netdevsim device (same offload device) is
> accepted together with the bound port.
>
> The program is loaded from the existing sample_ret0.bpf.o with an explicit
> `type classifier` override, so no new sample object is needed.
>
> Reviewed-by: Victor Nogueira <victor@mojatatu.com>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-10-16 18:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 21:02 [PATCH net v2 0/3] net/sched: cls_bpf: accept dev-bound programs on shared blocks Jamal Hadi Salim
2026-10-10 21:02 ` [PATCH net v2 1/3] netdevsim: reject cls_bpf programs bound to another device Jamal Hadi Salim
2026-10-11 21:03 ` netdev-bot+sashiko
2026-10-11 23:50 ` Jamal Hadi Salim
2026-10-16 18:22 ` Simon Horman
2026-10-10 21:02 ` [PATCH net v2 2/3] net/sched: cls_bpf: accept dev-bound programs on shared blocks Jamal Hadi Salim
2026-10-11 21:03 ` netdev-bot+sashiko
2026-10-11 23:51 ` Jamal Hadi Salim
2026-10-16 18:23 ` Simon Horman
2026-10-10 21:02 ` [PATCH net v2 3/3] selftests: net: exercise dev-bound cls_bpf " Jamal Hadi Salim
2026-10-11 21:03 ` netdev-bot+sashiko
2026-10-11 23:49 ` Jamal Hadi Salim
2026-10-11 23:50 ` Jamal Hadi Salim
2026-10-16 18:23 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016182325.GM363352@horms.kernel.org \
--to=horms@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=victor@mojatatu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.