From: Simon Horman <horms@kernel.org>
To: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Martin Varghese <martin.varghese@nokia.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] selftests: net: bareudp: Add stream tests with software GSO
Date: Fri, 16 Oct 2026 20:07:51 +0100 [thread overview]
Message-ID: <20261016190751.GO363352@horms.kernel.org> (raw)
In-Reply-To: <20261011104300.1606351-1-yanhaishuang@cmss.chinamobile.com>
On Sun, Oct 11, 2026 at 06:43:00PM +0800, Haishuang Yan wrote:
> The bareudp tests only send pings, which are not GSO packets, so the
> segmentation path of bareudp is not covered.
>
> Copy a file over TCP from NS0 to NS3 with socat after the IPv4 and IPv6
> ping tests, with UDP tunnel segmentation offload disabled on the
> underlay veths, so that the GSO packets encapsulated by bareudp are
> segmented in software. Raise the MTU of the underlay veths, so that full
> sized packets fit with the encapsulation, as there is no path MTU
> discovery through bareudp.
>
> The MPLS overlay gets no stream test: bareudp does not set
> mpls_features, so MPLS GSO packets are segmented by mpls_gso before
> they reach bareudp, and are dropped if mpls_gso is not available.
>
> The ping and stream tests share the result reporting, so move it into
> report_result(). Without socat or ethtool, the stream tests are skipped.
>
> Without commit c57b2e60d4bf ("bareudp: set the inner protocol to the
> protocol of the packet"), the IPv4 and IPv6 streams over UDPv6, and the
> IPv6 stream over UDPv4 in multiproto mode, time out.
>
> Suggested-by: Willem de Bruijn <willemb@google.com>
> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-10-16 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 10:43 [PATCH net-next v2] selftests: net: bareudp: Add stream tests with software GSO Haishuang Yan
2026-10-16 19:07 ` Simon Horman [this message]
2026-10-17 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016190751.GO363352@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.varghese@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=yanhaishuang@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.