Re: [PATCH 4/8] xfs: remove redundant stat check after rcbagbt_insert()

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Oct 16, 2026 at 02:29:04PM -0500, Eric Sandeen wrote:
> rcbagbt_insert() simply returns the error and status from
> xfs_btree_insert, which has already validated the insert
> or returned an error.
> 
> This makes this instance of this idiom:
> 
> 	error = rcbagbt_insert(cur, &bagrec, &has);
> 	if (error)
> 		goto out_cur;
> 	if (!has) {
> 		error = -EFSCORRUPTED;
> 		goto out_cur;
> 	}
> 
> unnecessary/unreachable code. Remove it.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/scrub/rcbag.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/xfs/scrub/rcbag.c b/fs/xfs/scrub/rcbag.c
> index 8f3a10f7c908..fd9ccb205725 100644
> --- a/fs/xfs/scrub/rcbag.c
> +++ b/fs/xfs/scrub/rcbag.c
> @@ -105,10 +105,6 @@ rcbag_add(
>  		error = rcbagbt_insert(cur, &bagrec, &has);
>  		if (error)
>  			goto out_cur;
> -		if (!has) {
> -			error = -EFSCORRUPTED;
> -			goto out_cur;
> -		}
>  	}
>  
>  	xfs_btree_del_cursor(cur, 0);
> -- 
> 2.55.0
> 
>