All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Alison Schofield <alison.schofield@intel.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
	Dave Jiang <dave.jiang@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <iweiny@kernel.org>, Li Ming <ming.li@zohomail.com>,
	Richard Cheng <icheng@nvidia.com>,
	linux-cxl@vger.kernel.org
Subject: Re: [PATCH 1/4] Documentation/driver-api/cxl: Add a testing page
Date: Fri, 16 Oct 2026 20:01:32 +0100	[thread overview]
Message-ID: <20261016200132.421bc751@jic23-hlaptop> (raw)
In-Reply-To: <7af9e1341a24928799d88adaa6144c1ca82091f7.1791949910.git.alison.schofield@intel.com>

On Tue, 13 Oct 2026 21:17:52 -0700
Alison Schofield <alison.schofield@intel.com> wrote:

> The CXL documentation does not describe the subsystem's testing
> infrastructure or provide guidance on choosing between cxl_test
> and KUnit.
> 
> Add a testing page that describes when to use each framework, how
> to run the tests, and how to add a CXL KUnit test.
> 
> Suggested-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>

> +- If the code under test depends on another configuration option, such as
> +  CONFIG_CXL_REGION, make the test build conditional on that option in tests/Makefile

Because we all love the trivial.  Line is a tiny bit long and I don't think it would
hurt readability much to keep to 80 chars in here.

> +  and enable it in drivers/cxl/.kunitconfig.
> +
> +- Use exported interfaces where possible, importing the CXL symbol namespace as needed.

As above. Few chars long.  Check the rest.

> +
> +When to add a test
> +==================
> +
> +New or modified self-contained logic should be accompanied by KUnit coverage where
> +practical. Extend an existing suite when possible, or introduce a new one for
> +functionality that is not yet covered.
> +
> +Bug fixes should include regression coverage that reproduces the problem without
> +the fix.
> +
> +Changes to topology-dependent behavior should be covered by cxl_test tests in ndctl.
> +KUnit coverage complements, but does not replace, cxl_test.


  parent reply	other threads:[~2026-10-16 19:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14  4:17 [PATCH 0/4] cxl: Add KUnit tests and documentation Alison Schofield
2026-10-14  4:17 ` [PATCH 1/4] Documentation/driver-api/cxl: Add a testing page Alison Schofield
2026-10-14 21:34   ` Alison Schofield
2026-10-16 19:02     ` Jonathan Cameron
2026-10-16 19:01   ` Jonathan Cameron [this message]
2026-10-19 20:44     ` Alison Schofield
2026-10-16 22:52   ` Anisa Su
2026-10-19 20:39     ` Alison Schofield
2026-10-14  4:17 ` [PATCH 2/4] cxl: Add KUnit tests for HDM decoder encoding helpers Alison Schofield
2026-10-15  9:16   ` Li Ming
2026-10-16 20:01   ` Jonathan Cameron
2026-10-19 21:09     ` Alison Schofield
2026-10-14  4:17 ` [PATCH 3/4] cxl/mbox: Treat unknown device return codes as errors Alison Schofield
2026-10-14 15:06   ` 黄高彬
2026-10-15  9:22   ` Li Ming
2026-10-19 21:01     ` Alison Schofield
2026-10-20  2:35       ` Li Ming
2026-10-16 20:03   ` Jonathan Cameron
2026-10-14  4:17 ` [PATCH 4/4] cxl/mbox: Add KUnit tests for cxl_internal_send_cmd() Alison Schofield
2026-10-15  9:37   ` Li Ming
2026-10-19 21:22     ` Alison Schofield
2026-10-20  2:34       ` Li Ming
2026-10-14 20:52 ` [PATCH 0/4] cxl: Add KUnit tests and documentation Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261016200132.421bc751@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=icheng@nvidia.com \
    --cc=iweiny@kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.