From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Myeonghun Pak <mhun512@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Ijae Kim" <ae878000@gmail.com>
Subject: Re: [PATCH] iio: proximity: hx9023s: Allocate trigger before requesting IRQ
Date: Fri, 16 Oct 2026 20:25:24 +0200 [thread overview]
Message-ID: <20261016202524.6193abcd@systembl0wer> (raw)
In-Reply-To: <20261016024735.3667060-1-mhun512@gmail.com>
On Thu, 15 Oct 2026 22:47:35 -0400
Myeonghun Pak <mhun512@gmail.com> wrote:
> An IRQ handler that already read trigger_enabled can poll data->trig
> after buffer disable. Detaching the virtual IRQ does not join this
> physical IRQ, and trigger deselection can drop the consumer reference.
> Devres may then free the trigger before joining the handler.
>
> Allocate the trigger before requesting the IRQ so devres joins the
> handler before dropping the allocation reference.
>
> This issue was identified as part of our ongoing research while
> reviewing kernel code.
>
> Fixes: 60df548277b7 ("iio: proximity: Add driver support for TYHX's HX9023S capacitive proximity sensor")
> Assisted-by: LLM
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> ---
LGTM.
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards,
Joshua Crofts
prev parent reply other threads:[~2026-10-16 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 2:47 [PATCH] iio: proximity: hx9023s: Allocate trigger before requesting IRQ Myeonghun Pak
2026-10-16 18:25 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016202524.6193abcd@systembl0wer \
--to=joshua.crofts1@gmail.com \
--cc=ae878000@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhun512@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.